From 2d4eaa67be8d0b50d38c59251e0ed4625262a1e2 Mon Sep 17 00:00:00 2001 From: Vladimir Sumarov Date: Mon, 5 Jan 2026 16:55:01 -0800 Subject: [PATCH 1/5] fix github actions warnings --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 416dd5a1c..f31450876 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -54,12 +54,12 @@ jobs: submodules: 'recursive' - name: Get the version id: get_version - run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT + run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV shell: bash - name: Install Node.js uses: actions/setup-node@v3 with: - node-version: '18.x' + node-version: '20.x' - name: Install dependencies shell: bash run: './ci/install-dependencies-osx.sh' @@ -278,7 +278,7 @@ jobs: id: get_version run: | $version = $env:GITHUB_REF -replace 'refs/tags/', '' - "VERSION=$version" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append + "VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append shell: pwsh - name: Install dependencies run: | From 2aced9c8fc2573ec19b3d65b4435be86fabeb129 Mon Sep 17 00:00:00 2001 From: Vladimir Sumarov Date: Mon, 5 Jan 2026 17:16:27 -0800 Subject: [PATCH 2/5] fix more warnings --- .github/workflows/main.yml | 2 +- ci/install-dependencies-osx.sh | 28 ++++++++++++++++++++++------ 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f31450876..4f6a82aa9 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -125,7 +125,7 @@ jobs: - name: Install Node.js uses: actions/setup-node@v3 with: - node-version: '18.x' + node-version: '20.x' - name: Install dependencies shell: bash run: './ci/install-dependencies-osx.sh' diff --git a/ci/install-dependencies-osx.sh b/ci/install-dependencies-osx.sh index 86cd99931..b4888abff 100755 --- a/ci/install-dependencies-osx.sh +++ b/ci/install-dependencies-osx.sh @@ -1,11 +1,27 @@ -# Install system dependencies +#!/bin/bash +set -e + +# Clean up Homebrew to remove deprecated/broken entries +brew cleanup 2>/dev/null || true +brew untap homebrew/core 2>/dev/null || true +brew untap homebrew/cask 2>/dev/null || true + +# Update Homebrew brew update -brew doctor +brew doctor || true + +# Install system dependencies (avoiding deprecated versions) +# Using explicit versions to prevent deprecated formula warnings brew install cmake -brew install python -brew install node@18 -export PATH="/usr/local/opt/node@18/bin:$PATH" -node -v +brew install python@3.11 +brew install openssl@3 + +# Export PATH for consistency +export PATH="/usr/local/opt/python@3.11/bin:$PATH" + +# Verify installations +python3 --version +cmake --version # Install module dependencies yarn install From 08dd244abe7a84df28506bb32846f19fe5a955ae Mon Sep 17 00:00:00 2001 From: Vladimir Sumarov Date: Mon, 5 Jan 2026 17:27:40 -0800 Subject: [PATCH 3/5] fix github actions warnings --- ci/install-dependencies-osx.sh | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/ci/install-dependencies-osx.sh b/ci/install-dependencies-osx.sh index b4888abff..7dd084001 100755 --- a/ci/install-dependencies-osx.sh +++ b/ci/install-dependencies-osx.sh @@ -1,7 +1,7 @@ #!/bin/bash set -e -# Clean up Homebrew to remove deprecated/broken entries +# Clean up Homebrew to remove deprecated/broken entries and broken symlinks brew cleanup 2>/dev/null || true brew untap homebrew/core 2>/dev/null || true brew untap homebrew/cask 2>/dev/null || true @@ -10,17 +10,14 @@ brew untap homebrew/cask 2>/dev/null || true brew update brew doctor || true -# Install system dependencies (avoiding deprecated versions) -# Using explicit versions to prevent deprecated formula warnings -brew install cmake -brew install python@3.11 -brew install openssl@3 +# Install minimal system dependencies +# Note: Node.js is managed by actions/setup-node, not Homebrew +# OpenSSL is built statically in libcurl (CURL_USE_OPENSSL is OFF in CMakeLists.txt) +# Python comes with macOS, no need to install -# Export PATH for consistency -export PATH="/usr/local/opt/python@3.11/bin:$PATH" +brew install cmake -# Verify installations -python3 --version +# Verify cmake installation cmake --version # Install module dependencies From d078ba92378b2309df7af5c69b02beaedb5a32dd Mon Sep 17 00:00:00 2001 From: Vladimir Sumarov Date: Mon, 5 Jan 2026 17:59:08 -0800 Subject: [PATCH 4/5] fix more warnings --- ci/install-dependencies-osx.sh | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/ci/install-dependencies-osx.sh b/ci/install-dependencies-osx.sh index 7dd084001..3397e8b36 100755 --- a/ci/install-dependencies-osx.sh +++ b/ci/install-dependencies-osx.sh @@ -1,23 +1,19 @@ #!/bin/bash set -e -# Clean up Homebrew to remove deprecated/broken entries and broken symlinks +# Remove preinstalled deprecated/disabled formulae and casks that trigger warnings +brew uninstall --ignore-dependencies openssl@1.1 node@20 2>/dev/null || true +brew uninstall --cask session-manager-plugin 2>/dev/null || true brew cleanup 2>/dev/null || true -brew untap homebrew/core 2>/dev/null || true -brew untap homebrew/cask 2>/dev/null || true -# Update Homebrew +# Update Homebrew (keep taps intact) brew update brew doctor || true -# Install minimal system dependencies -# Note: Node.js is managed by actions/setup-node, not Homebrew -# OpenSSL is built statically in libcurl (CURL_USE_OPENSSL is OFF in CMakeLists.txt) -# Python comes with macOS, no need to install - +# Install minimal system dependency (Node is provided by actions/setup-node) brew install cmake -# Verify cmake installation +# Verify cmake --version # Install module dependencies From fcf88f7cee84d653a34a4b8404251a2da98924dc Mon Sep 17 00:00:00 2001 From: Vladimir Sumarov Date: Mon, 5 Jan 2026 18:18:51 -0800 Subject: [PATCH 5/5] fix more warnings --- .github/workflows/main.yml | 4 ++-- ci/install-dependencies-osx.sh | 21 ++++++++++++++------- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4f6a82aa9..393d778a5 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -190,7 +190,7 @@ jobs: TARGET_ARTIFACT: ${{env.PACKAGE_NAME}}-${{ steps.get_version.outputs.VERSION }}-${{matrix.ReleaseName}}-${{env.OS_TAG}}-${{matrix.Architecture}} - name: Configure AWS credentials if: startsWith(github.ref, 'refs/tags/') - uses: aws-actions/configure-aws-credentials@v1 + uses: aws-actions/configure-aws-credentials@v4 with: aws-access-key-id: ${{secrets.AWS_RELEASE_ACCESS_KEY_ID}} aws-secret-access-key: ${{secrets.AWS_RELEASE_SECRET_ACCESS_KEY}} @@ -372,7 +372,7 @@ jobs: TARGET_ARTIFACT: ${{env.PACKAGE_NAME}}-${{ steps.get_version.outputs.VERSION }}-release-${{env.OS_TAG}} - name: Configure AWS credentials if: startsWith(github.ref, 'refs/tags/') - uses: aws-actions/configure-aws-credentials@v1 + uses: aws-actions/configure-aws-credentials@v4 with: aws-access-key-id: ${{secrets.AWS_RELEASE_ACCESS_KEY_ID}} aws-secret-access-key: ${{secrets.AWS_RELEASE_SECRET_ACCESS_KEY}} diff --git a/ci/install-dependencies-osx.sh b/ci/install-dependencies-osx.sh index 3397e8b36..4735afbc1 100755 --- a/ci/install-dependencies-osx.sh +++ b/ci/install-dependencies-osx.sh @@ -1,19 +1,26 @@ #!/bin/bash set -e -# Remove preinstalled deprecated/disabled formulae and casks that trigger warnings -brew uninstall --ignore-dependencies openssl@1.1 node@20 2>/dev/null || true +# Remove preinstalled deprecated/disabled formulae and casks +brew uninstall --ignore-dependencies openssl@1.1 2>/dev/null || true brew uninstall --cask session-manager-plugin 2>/dev/null || true + +# Remove unnecessary local taps (these cause warnings on GitHub runners) +brew untap homebrew/core 2>/dev/null || true +brew untap homebrew/cask 2>/dev/null || true + +# Clean up broken symlinks and outdated packages brew cleanup 2>/dev/null || true -# Update Homebrew (keep taps intact) +# Update Homebrew brew update -brew doctor || true -# Install minimal system dependency (Node is provided by actions/setup-node) -brew install cmake +# Only install cmake if not already present +if ! command -v cmake &> /dev/null; then + brew install cmake +fi -# Verify +# Verify cmake cmake --version # Install module dependencies