Commit 0846236
fix: address review feedback on C ABI codec registry
- codec_name_to_cstring: use expect() instead of unwrap_or_default()
to fail fast on programmer errors (matches lib.rs macro pattern)
- Add tracing::warn! when EncodedVideo null custom_type_id falls back
to Binary (aids debugging of new plugins vs backward compat)
- Simplify map_err to forward original from_c_name() error messages
- Add doc comments clarifying intentional field loss (bitstream_format,
codec_private, profile, level) through C ABI pin-type declarations
Signed-off-by: StreamKit Devin <devin@streamkit.dev>
Co-Authored-By: Claudio Costa <cstcld91@gmail.com>1 parent 8a4b074 commit 0846236
1 file changed
+3
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
| 77 | + | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
100 | | - | |
| 99 | + | |
101 | 100 | | |
102 | 101 | | |
103 | 102 | | |
| |||
0 commit comments