fix(e2e): stop console error collection before disconnect/destroy phase

WebTransport teardown emits benign 'The session is closed' errors
during disconnect. Assert and stop the collector before the
disconnect/destroy phase so shutdown noise does not cause false
failures.

Signed-off-by: StreamKit Devin <devin@streamkit.dev>
Co-Authored-By: Claudio Costa <devin@streamkit.dev>

Author: streamkit-devin

e2e/tests/stream.spec.ts

@@ -52,6 +52,10 @@ test.describe('Stream View - Dynamic Pipeline', () => {
     const sessionIdText = await page.getByText(/Session ID:/).textContent();
     sessionId = sessionIdText?.replace(/Session ID:\s*/, '').trim() ?? null;
 
+    const unexpected = collector.getUnexpected(MOQ_BENIGN_PATTERNS);
+    expect(unexpected, `Unexpected console errors: ${unexpected.join('; ')}`).toHaveLength(0);
+    collector.stop();
+
     const destroyButton = page.getByRole('button', {
       name: /Destroy Session/i,
     });
@@ -64,9 +68,6 @@ test.describe('Stream View - Dynamic Pipeline', () => {
 
     await expect(createButton).toBeVisible({ timeout: 15_000 });
     sessionId = null;
-
-    const unexpected = collector.getUnexpected(MOQ_BENIGN_PATTERNS);
-    expect(unexpected, `Unexpected console errors: ${unexpected.join('; ')}`).toHaveLength(0);
   });
 
   test('connects via MoQ, verifies connection status, then disconnects', async ({
@@ -136,6 +137,10 @@ test.describe('Stream View - Dynamic Pipeline', () => {
       ).toBeGreaterThan(0);
       expect(audioState.maxCurrentTime, 'AudioContext should have advanced').toBeGreaterThan(0);
 
+      const unexpected = collector.getUnexpected(MOQ_BENIGN_PATTERNS);
+      expect(unexpected, `Unexpected console errors: ${unexpected.join('; ')}`).toHaveLength(0);
+      collector.stop();
+
       const disconnectButton = page.getByRole('button', { name: /^Disconnect$/i }).first();
       await expect(disconnectButton).toBeVisible();
       await disconnectButton.click();
@@ -160,9 +165,6 @@ test.describe('Stream View - Dynamic Pipeline', () => {
     });
 
     sessionId = null;
-
-    const unexpected = collector.getUnexpected(MOQ_BENIGN_PATTERNS);
-    expect(unexpected, `Unexpected console errors: ${unexpected.join('; ')}`).toHaveLength(0);
   });
 
   test.afterEach(async ({ baseURL }) => {

e2e/tests/test-helpers.ts

@@ -15,21 +15,26 @@ export const MOQ_BENIGN_PATTERNS = [
 export interface ConsoleErrorCollector {
   readonly errors: string[];
   reset(): void;
+  stop(): void;
   getUnexpected(extraBenignPatterns?: string[]): string[];
 }
 
 export function createConsoleErrorCollector(page: Page): ConsoleErrorCollector {
   const errors: string[] = [];
-  page.on('console', (msg) => {
+  const handler = (msg: import('@playwright/test').ConsoleMessage) => {
     if (msg.type() === 'error') {
       errors.push(msg.text());
     }
-  });
+  };
+  page.on('console', handler);
   return {
     errors,
     reset() {
       errors.length = 0;
     },
+    stop() {
+      page.removeListener('console', handler);
+    },
     getUnexpected(extraBenignPatterns: string[] = []) {
       const allPatterns = [...ALWAYS_BENIGN, ...extraBenignPatterns];
       return errors.filter((msg) => !allPatterns.some((p) => msg.includes(p)));