From fbe0984ca21e2b6ae0f554bbc5b2819332e59afc Mon Sep 17 00:00:00 2001
From: Sjors Provoost <sjors@sprovoost.nl>
Date: Mon, 24 Nov 2025 15:08:43 +0100
Subject: [PATCH] Fix spurious tip changed detection

This was broken by #58 resulting in spurious "Tip changed" messages.

Worse however is that that this caused m_last_block_time to update too often. When -sv2interval is set to 10 seconds or less, this results in PruneBlockTemplateCache never running.
---
 src/sv2/template_provider.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sv2/template_provider.cpp b/src/sv2/template_provider.cpp
index f4e2a178..d308cc6a 100644
--- a/src/sv2/template_provider.cpp
+++ b/src/sv2/template_provider.cpp
@@ -366,7 +366,7 @@ void Sv2TemplateProvider::ThreadSv2ClientHandler(size_t client_id)
 
                 {
                     LOCK(m_tp_mutex);
-                    if (new_prev_hash != prev_hash) {
+                    if (new_prev_hash != m_best_prev_hash) {
                         LogPrintLevel(BCLog::SV2, BCLog::Level::Trace, "Tip changed, client id=%zu\n",
                             client_id);
                         future_template = true;