docs: add coinbase rotation documentation to config examples

Document the new coinbase rotation configuration options in testnet4
config examples for both pool and JD-client.

Author: average-gary

miner-apps/jd-client/config-examples/testnet4/jdc-config-local-infra-example.toml

@@ -35,8 +35,18 @@ jdc_signature = "Sv2MinerSignature"
 #     https://github.com/bitcoin/bips/blob/master/bip-0380.mediawiki#appendix-b-index-of-script-expressions
 # Although the `musig` descriptor is not yet supported and the legacy `combo` descriptor never
 # will be. If you have an address, embed it in a descriptor like `addr(<address here>)`.
+#
+# For automatic address rotation (quantum-resistant payout hygiene), use a wildcard descriptor:
+#   coinbase_reward_script = "wpkh(tpub.../0/*)"
+# This derives a fresh address for each block found. Requires coinbase_index_file.
 coinbase_reward_script = "addr(tb1qpusf5256yxv50qt0pm0tue8k952fsu5lzsphft)"
 
+# Coinbase rotation settings (only used when coinbase_reward_script has a wildcard)
+# Path to persist the current derivation index (required for rotation)
+# coinbase_index_file = "/var/lib/jdc/coinbase_index.dat"
+# Starting index if no persistence file exists (default: 0)
+# coinbase_start_index = 0
+
 # Enable this option to set a predefined log file path.
 # When enabled, logs will always be written to this file.
 # The CLI option --log-file (or -f) will override this setting if provided.

miner-apps/jd-client/src/lib/config.rs

@@ -81,7 +81,6 @@ pub struct JobDeclaratorClientConfig {
 fn default_monitoring_cache_refresh_secs() -> u64 {
     15
 }
-}
 
 impl JobDeclaratorClientConfig {
     #[allow(clippy::too_many_arguments)]

miner-apps/jd-client/src/lib/mod.rs

@@ -132,9 +132,7 @@ impl JobDeclaratorClient {
                 monitoring_addr,
                 Some(Arc::new(channel_manager.clone())), // SV2 channels opened with servers
                 Some(Arc::new(channel_manager.clone())), // SV2 channels opened with clients
-                std::time::Duration::from_secs(
-                    self.config.monitoring_cache_refresh_secs().unwrap_or(15),
-                ),
+                std::time::Duration::from_secs(self.config.monitoring_cache_refresh_secs()),
             )
             .expect("Failed to initialize monitoring server");
 
@@ -504,7 +502,7 @@ impl JobDeclaratorClient {
                                         monitoring_addr,
                                         Some(Arc::new(channel_manager_clone.clone())),
                                         Some(Arc::new(channel_manager_clone.clone())),
-                                        std::time::Duration::from_secs(self.config.monitoring_cache_refresh_secs().unwrap_or(15)),
+                                        std::time::Duration::from_secs(self.config.monitoring_cache_refresh_secs()),
                                     )
                                     .expect("Failed to initialize monitoring server");
 

pool-apps/pool/config-examples/testnet4/pool-config-local-sv2-tp-example.toml

@@ -8,8 +8,18 @@ listen_address = "0.0.0.0:43333"
 #     https://github.com/bitcoin/bips/blob/master/bip-0380.mediawiki#appendix-b-index-of-script-expressions
 # Although the `musig` descriptor is not yet supported and the legacy `combo` descriptor never
 # will be. If you have an address, embed it in a descriptor like `addr(<address here>)`.
+#
+# For automatic address rotation (quantum-resistant payout hygiene), use a wildcard descriptor:
+#   coinbase_reward_script = "wpkh(tpub.../0/*)"
+# This derives a fresh address for each block found. Requires coinbase_index_file.
 coinbase_reward_script = "addr(tb1qa0sm0hxzj0x25rh8gw5xlzwlsfvvyz8u96w3p8)"
 
+# Coinbase rotation settings (only used when coinbase_reward_script has a wildcard)
+# Path to persist the current derivation index (required for rotation)
+# coinbase_index_file = "/var/lib/pool/coinbase_index.dat"
+# Starting index if no persistence file exists (default: 0)
+# coinbase_start_index = 0
+
 # Server Id (number to guarantee unique search space allocation across different Pool servers)
 server_id = 1
 

pool-apps/pool/src/lib/config.rs

@@ -48,14 +48,14 @@ pub struct PoolConfig {
     monitoring_address: Option<SocketAddr>,
     #[serde(default = "default_monitoring_cache_refresh_secs")]
     monitoring_cache_refresh_secs: u64,
+    #[serde(default)]
+    jds: Option<JDSPartialConfig>,
 
     /// Starting derivation index for coinbase rotation (default: 0).
     ///
     /// Only used when `coinbase_reward_script` contains a wildcard descriptor
     /// (e.g., `wpkh(xpub.../0/*)`). Ignored for static addresses.
     #[serde(default)]
-    jds: Option<JDSPartialConfig>,
-    monitoring_cache_refresh_secs: Option<u64>,
     coinbase_start_index: u32,
 
     /// Path to persist the current coinbase derivation index.
@@ -72,7 +72,6 @@ pub struct PoolConfig {
 fn default_monitoring_cache_refresh_secs() -> u64 {
     15
 }
-}
 
 impl PoolConfig {
     /// Creates a new instance of the [`PoolConfig`].

pool-apps/pool/src/lib/mod.rs

@@ -171,9 +171,7 @@ impl PoolSv2 {
                 monitoring_addr,
                 None, // Pool doesn't have channels opened with servers
                 Some(Arc::new(channel_manager.clone())), // channels opened with clients
-                std::time::Duration::from_secs(
-                    self.config.monitoring_cache_refresh_secs().unwrap_or(15),
-                ),
+                std::time::Duration::from_secs(self.config.monitoring_cache_refresh_secs()),
             )
             .expect("Failed to initialize monitoring server");