Merge pull request #421 from Shourya742/2026-04-08-add-display-for-translator

Make sure to use display for types which implements it in Tproxy

Author: plebhash

miner-apps/translator/src/lib/sv1/downstream/data.rs

@@ -82,7 +82,7 @@ impl DownstreamData {
     pub fn set_upstream_target(&mut self, upstream_target: Target, downstream_id: DownstreamId) {
         self.upstream_target = Some(upstream_target);
         debug!(
-            "Downstream {downstream_id}: Set upstream target to {:?}",
+            "Downstream {downstream_id}: Set upstream target to {}",
             upstream_target
         );
     }

miner-apps/translator/src/lib/sv1/sv1_server/difficulty_manager.rs

@@ -113,15 +113,15 @@ impl Sv1Server {
                             // Case 1: new_target >= upstream_target, send set_difficulty
                             // immediately
                             trace!(
-                                "✅ Target comparison: new_target ({:?}) >= upstream_target ({:?}) for downstream {}, will send set_difficulty immediately",
+                                "✅ Target comparison: new_target ({}) >= upstream_target ({}) for downstream {}, will send set_difficulty immediately",
                                 new_target, upstream_target, downstream_id
                             );
                             immediate_updates.push((channel_id, Some(*downstream_id), new_target));
                         } else {
                             // Case 2: new_target < upstream_target, delay set_difficulty until
                             // SetTarget
                             trace!(
-                                "⏳ Target comparison: new_target ({:?}) < upstream_target ({:?}) for downstream {}, will delay set_difficulty until SetTarget",
+                                "⏳ Target comparison: new_target ({}) < upstream_target ({}) for downstream {}, will delay set_difficulty until SetTarget",
                                 new_target, upstream_target, downstream_id
                             );
                             self.pending_target_updates.super_safe_lock(|data| {
@@ -240,7 +240,7 @@ impl Sv1Server {
         };
 
         debug!(
-            "Sending aggregated UpdateChannel: channel_id={}, total_hashrate={}, min_target={:?}, downstreams={}, vardiff_updates={}",
+            "Sending aggregated UpdateChannel: channel_id={}, total_hashrate={}, min_target={}, downstreams={}, vardiff_updates={}",
             channel_id,
             total_hashrate,
             min_target,
@@ -270,7 +270,7 @@ impl Sv1Server {
             };
 
             debug!(
-                "Sending UpdateChannel for downstream {}: channel_id={}, hashrate={}, target={:?}",
+                "Sending UpdateChannel for downstream {}: channel_id={}, hashrate={}, target={}",
                 downstream_id, channel_id, new_hashrate, new_target
             );
 
@@ -297,7 +297,7 @@ impl Sv1Server {
         let new_upstream_target =
             Target::from_le_bytes(set_target.maximum_target.inner_as_ref().try_into().unwrap());
         debug!(
-            "Received SetTarget for channel {}: new_upstream_target = {:?}",
+            "Received SetTarget for channel {}: new_upstream_target = {}",
             set_target.channel_id, new_upstream_target
         );
 
@@ -406,7 +406,7 @@ impl Sv1Server {
                 } else {
                     // WARNING: Upstream gave us a target higher than what we requested
                     error!(
-                        "❌ Protocol issue: SetTarget response has target ({:?}) which is higher than requested target ({:?}) in UpdateChannel for channel {:?}. Ignoring this pending update for downstream {:?}.",
+                        "❌ Protocol issue: SetTarget response has target ({}) which is higher than requested target ({}) in UpdateChannel for channel {}. Ignoring this pending update for downstream {}.",
                         new_upstream_target, pending_update.new_target, channel_id, pending_update.downstream_id
                     );
                     false // remove from pending list (don't keep invalid requests)

miner-apps/translator/src/lib/sv1/sv1_server/downstream_message_handler.rs

@@ -23,10 +23,7 @@ impl IsServer<'static> for Sv1Server {
         let downstream_id = client_id.expect("Downstream id should exist");
 
         info!("Received mining.configure from SV1 downstream");
-        debug!(
-            "Downstream {downstream_id}: mining.configure = {:?}",
-            request
-        );
+        debug!("Downstream {downstream_id}: mining.configure = {}", request);
 
         let downstream = self
             .downstreams
@@ -66,7 +63,7 @@ impl IsServer<'static> for Sv1Server {
         let downstream_id = client_id.expect("Downstream id should exist");
 
         info!("Received mining.subscribe from Sv1 downstream");
-        debug!("Down: Handling mining.subscribe: {:?}", request);
+        debug!("Down: Handling mining.subscribe: {}", request);
 
         let set_difficulty_sub = (
             "mining.set_difficulty".to_string(),
@@ -88,7 +85,7 @@ impl IsServer<'static> for Sv1Server {
     ) -> bool {
         let downstream_id = client_id.expect("Downstream id should exist");
         info!("Received mining.authorize from Sv1 downstream {downstream_id}");
-        debug!("Down: Handling mining.authorize: {:?}", request);
+        debug!("Down: Handling mining.authorize: {}", request);
         true
     }
 

miner-apps/translator/src/lib/sv1/sv1_server/sv1_server.rs

@@ -356,10 +356,7 @@ impl Sv1Server {
 
             match response {
                 Ok(Some(response_msg)) => {
-                    debug!(
-                        "Down: Sending Sv1 message to downstream: {:?}",
-                        response_msg
-                    );
+                    debug!("Down: Sending Sv1 message to downstream: {}", response_msg);
                     downstream
                         .downstream_channel_state
                         .downstream_sv1_sender
@@ -877,7 +874,7 @@ impl Sv1Server {
         let new_target =
             Target::from_le_bytes(set_target.maximum_target.inner_as_ref().try_into().unwrap());
         debug!(
-            "Forwarding SetTarget to downstreams: channel_id={}, target={:?}",
+            "Forwarding SetTarget to downstreams: channel_id={}, target={}",
             set_target.channel_id, new_target
         );
 

miner-apps/translator/src/lib/sv2/channel_manager/channel_manager.rs

@@ -372,7 +372,7 @@ impl ChannelManager {
                 }
 
                 info!(
-                    "Sending OpenExtendedMiningChannel message to upstream: {:?}",
+                    "Sending OpenExtendedMiningChannel message to upstream: {}",
                     open_channel_msg
                 );
 
@@ -524,7 +524,7 @@ impl ChannelManager {
                             let sv2_frame = StandardSv2Frame::from_bytes(frame_bytes.into())
                                 .map_err(|missing| {
                                     error!(
-                                        "Failed to convert frame bytes to StandardSv2Frame: {:?}",
+                                        "Failed to convert frame bytes to StandardSv2Frame: {}",
                                         missing
                                     );
                                     TproxyError::shutdown(framing_sv2::Error::ExpectedSv2Frame)
@@ -550,7 +550,7 @@ impl ChannelManager {
                 }
             }
             Mining::UpdateChannel(mut m) => {
-                debug!("Received UpdateChannel from SV1Server: {:?}", m);
+                debug!("Received UpdateChannel from SV1Server: {}", m);
 
                 if is_aggregated() {
                     // Update the aggregated channel's nominal hashrate so
@@ -570,7 +570,7 @@ impl ChannelManager {
                 }
 
                 info!(
-                    "Sending UpdateChannel message to upstream for channel_id: {:?}",
+                    "Sending UpdateChannel message to upstream for channel_id: {}",
                     m.channel_id
                 );
                 // Forward UpdateChannel message to upstream
@@ -620,7 +620,7 @@ impl ChannelManager {
                     })?;
             }
             _ => {
-                warn!("Unhandled downstream message: {:?}", message);
+                warn!("Unhandled downstream message: {}", message);
             }
         }
 

miner-apps/translator/src/lib/sv2/upstream/upstream.rs

@@ -283,16 +283,16 @@ impl Upstream {
                 requested_extensions: Seq064K::new(self.required_extensions.clone()).unwrap(),
             };
 
+            info!(
+                "Sending RequestExtensions message to upstream: {}",
+                require_extensions
+            );
+
             let sv2_frame: Sv2Frame =
                 AnyMessage::Extensions(require_extensions.into_static().into())
                     .try_into()
                     .map_err(TproxyError::shutdown)?;
 
-            info!(
-                "Sending RequestExtensions message to upstream: {:?}",
-                sv2_frame
-            );
-
             self.upstream_channel_state
                 .upstream_sender
                 .send(sv2_frame)