Hoist calculation of side triple into parent class

Signed-off-by: mulhern <amulhern@redhat.com>

Author: mulkieran

src/stratis_cli/_actions/_list_filesystem.py

@@ -121,6 +121,13 @@ def display(self):
         List filesystems.
         """
 
+    @staticmethod
+    def size_triple(mofs: Any) -> SizeTriple:
+        """
+        Calculate size triple
+        """
+        return SizeTriple(Range(mofs.Size()), get_property(mofs.Used(), Range, None))
+
 
 class Table(ListFilesystem):  # pylint: disable=too-few-public-methods
     """
@@ -133,15 +140,14 @@ def display(self):
         """
 
         def filesystem_size_quartet(
-            total: Range, used: Optional[Range], limit: Optional[Range]
+            size_triple: SizeTriple, limit: Optional[Range]
         ) -> str:
             """
             Calculate the triple to display for filesystem size.
 
             :returns: a string a formatted string showing all three values
             :rtype: str
             """
-            size_triple = SizeTriple(total, used)
             triple_str = " / ".join(
                 (
                     TABLE_FAILURE_STRING if x is None else str(x)
@@ -165,8 +171,7 @@ def filesystem_size_quartet(
         )
         size_func = catch_missing_property(
             lambda mofs: filesystem_size_quartet(
-                Range(mofs.Size()),
-                get_property(mofs.Used(), Range, None),
+                ListFilesystem.size_triple(mofs),
                 get_property(mofs.SizeLimit(), Range, None),
             ),
             TABLE_UNKNOWN_STRING,
@@ -215,7 +220,7 @@ def display(self):
 
         fs = self.filesystems_with_props[0]
 
-        size_triple = SizeTriple(Range(fs.Size()), get_property(fs.Used(), Range, None))
+        size_triple = ListFilesystem.size_triple(fs)
         limit = get_property(fs.SizeLimit(), Range, None)
         created = (
             date_parser.isoparse(fs.Created()).astimezone().strftime("%b %d %Y %H:%M")

tests/integration/pool/test_list.py

@@ -331,7 +331,7 @@ def test_list_no_size(self):
             stratis_cli._actions._list_pool.Default,  # pyright: ignore
             "size_triple",
             autospec=True,
-            raises=DbusClientMissingPropertyError(
+            side_effect=DbusClientMissingPropertyError(
                 "oops",
                 stratis_cli._actions._constants.POOL_INTERFACE,  # pyright: ignore
                 "TotalPhysicalUsed",