[BUG?] the requested filesystems already exist; no action taken

[bsdooby]

Context: on Slackware (-current), after successful installation of stratis (latest) from source (adding all required dependencies), I want to create a filesystem on my test pool (2 x 7 GB USB keys)

Want: create new filesystem

Get: from stratisd: the requested filesystems already exist; no action taken

Observation: no fs is created on the pool, as can be investigated by stratis fs list mypool

What could cause this?

[mulkieran]

Please post the following if possible:

1. Command you invoked to create the pool.
2. Output of stratis report.
3. Output of stratis pool list --stopped.
4. Output of stratis report managed_objects_report (this will be D-Bus info, you'll probably have to upload it).
5. Output of lsblk.

Thanks!

[mulkieran]

Since the error is generated by stratis not stratisd we know that stratis is inferring from the information on the D-Bus that a filesystem with the name you specified already exists. stratis report will allow us to get at the ground truth of stratisd's picture of the world, stratis report managed_objects_report will allow us to get an understanding of what is on the D-Bus. Also, stratis is latest from source, if that is from git, can you give us a commit hash? If not, can you be as specific as possible about the source? What version of stratisd are you using?

[bsdooby]

I retested with only one physical disk (USB key).

$ stratis daemon version
3.7.0

Output of stratis report.:

{
    "name_to_pool_uuid_map": {},
    "partially_constructed_pools": [],
    "path_to_ids_map": {},
    "pools": [
        {
            "available_actions": "fully_operational",
            "blockdevs": {
                "cachedevs": [],
                "datadevs": [
                    {
                        "blksizes": "base: BLKSSSZGET: 512 bytes, BLKPBSZGET: 512 bytes, crypt: None",
                        "in_use": true,
                        "path": "/dev/sdb",
                        "size": "15728640 sectors",
                        "uuid": "7a53520f-d0b8-47a6-a92d-e35414905c58"
                    }
                ]
            },
            "filesystems": [],
            "fs_limit": 100,
            "name": "mypool",
            "uuid": "105c1762-a5a1-478d-8115-a9f620905cbb"
        }
    ],
    "stopped_pools": []
}

Output of stratis pool list --stopped:

$ stratis pool list --stopped
Name   UUID   # Devices   Key Description   Clevis

Output of stratis report managed_objects_report (this will be D-Bus info, you'll probably have to upload it).
(see attachment): managed_objects_report.txt

Output of lsblk (abbridged):

...
sdb                                                                       8:16   1   7.5G  0 disk    
└─stratis-1-private-105c1762a5a1478d8115a9f620905cbb-physical-originsub 252:0    0   7.5G  0 stratis 
  ├─stratis-1-private-105c1762a5a1478d8115a9f620905cbb-flex-thinmeta    252:1    0     6M  0 stratis 
  │ └─stratis-1-private-105c1762a5a1478d8115a9f620905cbb-thinpool-pool  252:3    0     7G  0 stratis 
  ├─stratis-1-private-105c1762a5a1478d8115a9f620905cbb-flex-thindata    252:2    0     7G  0 stratis 
  │ └─stratis-1-private-105c1762a5a1478d8115a9f620905cbb-thinpool-pool  252:3    0     7G  0 stratis 
  └─stratis-1-private-105c1762a5a1478d8115a9f620905cbb-flex-mdv         252:4    0   512M  0 stratis
...

[mulkieran]

Ok! What was the name of the filesystem you were expecting to create?

[bsdooby]

client version:

$ stratis --version
3.6.0

source versions (from git):
stratis-cli: c126fc24f9d707f360b...
stratisd: eca8bec033ec94d92b0...

[bsdooby]

Ok! What was the name of the filesystem you were expecting to create?

(?) The standard fs that is used for Stratis (XFS); I do not need to indicate this, right?

[mulkieran]

Ok! What was the name of the filesystem you were expecting to create?

(?) The standard fs that is used for Stratis (XFS); I do not need to indicate this, right?

When you create a new filesystem, you have to give it a name. The command is: stratis filesystem create <poolname> <filesystem name> [options]. So, can you tell me the exact command that you were using to create the filesystem?

[mulkieran]

By the way, I was mistaken formerly. The error is generated by stratisd, not stratis-cli. So the whole thing, the precise command you issued and the precise error reported would be a help.

[bsdooby]

I issued: stratis fs create mypool myfs and got:

Execution failed: stratisd reported that it did not execute every action that it would have been expected to execute as a result of the command that you requested: Expected to create the specified filesystems in pool mypool but stratisd reports that it did not actually create some or all of the filesystems requested

report from stratisd --with-log=info:

...stratisd::dbus_api::pool::pool_3_6::methods] The requested filesystems already exist; no action taken)

[bsdooby]

My platform is a non-systemd one; Slackware64 -current w/ thin-provisioning-tools 0.9

[mulkieran]

I issued: stratis fs create mypool myfs and got:

Execution failed: stratisd reported that it did not execute every action that it would have been expected to execute as a result of the command that you requested: Expected to create the specified filesystems in pool mypool but stratisd reports that it did not actually create some or all of the filesystems requested

report from stratisd --with-log=info:

...stratisd::dbus_api::pool::pool_3_6::methods] The requested filesystems already exist; no action taken)

Ok!

The error message on the command-line is from stratis, stratisd reported to it that it had not created any filesystems as part of the return value of the D-Bus method, and stratis reported that it found that very surprising.

Can you give more output from the stratisd logs up to the one log entry you quoted? That entry is emitted exactly when the D-Bus method returns, so log entries that precede that one should be valuable. Also, please set the log level to debug instead of info.

[jbaublitz]

@mulkieran I actually saw this error in my metadata rework PR but need to look back to see exactly what was happening. Either I had a mismatched version of stratis-cli and stratisd or there was a bug in the engine. I can't remember which it was, and I can't reproduce it on the master branch, but I'll take a look again.

[jbaublitz]

Aha! I think I tracked it down. What I think is happening is that stratis-cli is not updated. Because the pre-3.6 version of stratis-cli and post-3.6 version of stratis-cli both send an array as the only parameter, our D-Bus layer allows us to send an incorrectly formatted array from the pre-3.6 version of stratis-cli to the 3.6 version of stratisd. This results in an empty set of filesystem specs being passed to the engine. This trips of stratis-cli because due to being idempotent, the engine reports that creating no filesystems was successful.