Skip to content

fix(cli): fix bug where output gets truncated when too long #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knieczyszczak merged 5 commits into from
Jan 30, 2026
Merged

fix(cli): fix bug where output gets truncated when too long #2862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aeddde2
Fix bug where output gets truncated when too long
sidneyamani Oct 29, 2025
4825f39
fix tests
sidneyamani Oct 29, 2025
5a03740
Merge branch 'develop' into fix-trucated-output
MichakrawSB Jan 29, 2026
399592c
Fixing the linter problem: The Prettier linter is complaining about t…
knieczyszczak Jan 30, 2026
cfe770e
Merge branch 'develop' into fix-trucated-output
knieczyszczak Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/cli/src/services/__tests__/output.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,17 @@ describe('Output service', () => {

it('given <stdout>, print output to console', async () => {
const output = '{}';
const writeMock = jest.spyOn(process.stdout, 'write').mockImplementation((chunk: any, callback?: any) => {
if (typeof callback === 'function') {
callback();
}
return true;
});

expect(await writeOutput(output, '<stdout>')).toBeUndefined();
expect(process.stdout.write).toBeCalledWith(output);
expect(writeMock).toHaveBeenCalledWith(output, expect.any(Function));

writeMock.mockRestore();
});
});
});
9 changes: 8 additions & 1 deletion packages/cli/src/services/output.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ export async function writeOutput(outputStr: string, outputFile: string): Promis
if (outputFile !== '<stdout>') {
await fs.writeFile(outputFile, outputStr);
} else {
process.stdout.write(outputStr);
// Handle backpressure by using the callback parameter
// The callback is invoked when the data is flushed (or an error occurs)
return new Promise((resolve, reject) => {
process.stdout.write(outputStr, err => {
if (err) reject(err);
else resolve();
});
});
}
}