Skip to content

fix(core): make JSON Schemas at packages/core/src/ruleset/meta valid #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jviotti wants to merge 4 commits into
base: develop
Choose a base branch
from
+32 −11
Open

fix(core): make JSON Schemas at packages/core/src/ruleset/meta valid #2788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ab4963
fix(core): make JSON Schemas at `packages/core/src/ruleset/meta` valid
jviotti Feb 25, 2025
d41ff93
Merge branch 'develop' into develop
knieczyszczak Jan 29, 2026
8253b08
Merge branch 'develop' into develop
knieczyszczak Jan 30, 2026
55bf95a
Merge branch 'develop' into develop
tomek-tursa-sb Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/jsonschema.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Check JSON Schemas

on:
pull_request:
branches:
- master
- develop

jobs:
jsonschema-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
- uses: sourcemeta/jsonschema@v6.0.3
- run: jsonschema metaschema --verbose packages/core/src/ruleset/meta/*.json
- run: jsonschema lint --verbose packages/core/src/ruleset/meta/*.json

# As a smoke test to ensure the schemas at least reference each other well
- run: >
jsonschema bundle --verbose
packages/core/src/ruleset/meta/ruleset.schema.json
--resolve packages/core/src/ruleset/meta
--ignore packages/core/src/ruleset/meta/js-extensions.json
7 changes: 3 additions & 4 deletions packages/core/src/ruleset/meta/js-extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "@stoplight/spectral-core/meta/extensions",
"$defs": {
"Extends": {
Expand All @@ -20,13 +20,12 @@
{
"type": "array",
"minItems": 2,
"additionalItems": false,
"items": [
"items": false,
"prefixItems": [
{
"$ref": "ruleset"
},
{
"type": "string",
"enum": ["off", "recommended", "all"],
"errorMessage": "allowed types are \"off\", \"recommended\" and \"all\""
}
Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/ruleset/meta/json-extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "@stoplight/spectral-core/meta/extensions",
"$defs": {
"Extends": {
Expand All @@ -18,8 +18,8 @@
{
"type": "array",
"minItems": 2,
"additionalItems": false,
"items": [
"items": false,
"prefixItems": [
{
"type": "string"
},
Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/ruleset/meta/rule.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "@stoplight/spectral-core/meta/rule.schema",
"$defs": {
"Then": {
Expand Down Expand Up @@ -75,7 +75,6 @@
},
"type": {
"enum": ["style", "validation"],
"type": "string",
"errorMessage": "allowed types are \"style\" and \"validation\""
},
"extensions": {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/ruleset/meta/ruleset.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "@stoplight/spectral-core/meta/ruleset.schema",
"type": "object",
"additionalProperties": false,
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/ruleset/meta/shared.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "@stoplight/spectral-core/meta/shared",
"$defs": {
"Formats": {
Expand Down