From c8e8cf82ffd9c7b4240fbdbbb8f9dae985088f92 Mon Sep 17 00:00:00 2001 From: Steven Clarke Date: Tue, 10 Jan 2017 14:36:42 +0000 Subject: [PATCH 1/4] Added guard for n --- scripts/factorial.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/factorial.js b/scripts/factorial.js index 26d2a49..cd5fb30 100644 --- a/scripts/factorial.js +++ b/scripts/factorial.js @@ -1,8 +1,10 @@ function factorial(n) { n = parseInt(n); var result = 1; - for(i = 1; i <= n; i++) { - result = result * i; + if (n > 0) { + for (i = 1; i <= n; i++) { + result = result * i; + } } return result; } \ No newline at end of file From 177c6888a66cdafdd742ac90f18ae1d05b9e9980 Mon Sep 17 00:00:00 2001 From: Steven Clarke Date: Tue, 10 Jan 2017 14:41:07 +0000 Subject: [PATCH 2/4] Checked for equality --- scripts/factorial.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/factorial.js b/scripts/factorial.js index cd5fb30..fa3a47d 100644 --- a/scripts/factorial.js +++ b/scripts/factorial.js @@ -1,7 +1,7 @@ function factorial(n) { n = parseInt(n); var result = 1; - if (n > 0) { + if (n >= 0) { for (i = 1; i <= n; i++) { result = result * i; } From 05c29c544df9d5cb48085cf865768e0dd60bc635 Mon Sep 17 00:00:00 2001 From: Steven Clarke Date: Tue, 10 Jan 2017 18:04:00 +0000 Subject: [PATCH 3/4] Made a change --- scripts/factorial.js | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/factorial.js b/scripts/factorial.js index fa3a47d..a8dd682 100644 --- a/scripts/factorial.js +++ b/scripts/factorial.js @@ -1,3 +1,4 @@ +//Added a comment function factorial(n) { n = parseInt(n); var result = 1; From 7916671978f8f8edbbda4096637871dec0f0bbbb Mon Sep 17 00:00:00 2001 From: Steven Clarke Date: Tue, 10 Jan 2017 18:06:33 +0000 Subject: [PATCH 4/4] Added more detail --- scripts/factorial.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/factorial.js b/scripts/factorial.js index a8dd682..46248e1 100644 --- a/scripts/factorial.js +++ b/scripts/factorial.js @@ -1,4 +1,4 @@ -//Added a comment +//Added a comment - added more detail function factorial(n) { n = parseInt(n); var result = 1;