Exception module

[NDevox]

Does this have a use?

It is honestly just a single class, called Exception, which inherits Pythons Exception, and then does absolutely nothing.

This looks like a big waste of time and just obfuscates what it actually is when you could just use Python's standard Exception class.

Sorry if this isn't welcome! I just came to take a look from mu as I was interested in what fin is. Found the exception module quite curious.

[stestagg]

Hi, thanks for the comment. I think you're right.

At one time there was some extra stuff in this module, including some logic around exceptions that included user-oriented (non-traceback) formatting, and syntax-highlited exception messages. I think that was moved out a long time ago (pre-github maybe), and this was left as a relic. I don't believe it's usefully used any more, so should remove it.

As for why it ever existed, I'm not sure it actually obfuscates anything (except in the local module) because fin.exception.Exception is always different from Exception (provided you don't use from imports too much, which were much less common pre-django time).

The advantage is that you can (should you wish) understand that an exception came from a specific source more easily, allowing for 'did my error originate from fin' question to be answered, or similar. Admittedly this isn't that common a thing to want to do, but there are some use cases.

[NDevox]

I can appreciate the idea of having an error specific to fin. But maybe it could be named something different? FinError maybe?

[stestagg]

It's just a different coding style, either you can have:

from fin.exception import FinException
...
raise FinException()

or:

import fin.exception
...
raise fin.exception.Exception()

or, with a bit of init magic, just:

import fin
...
raise fin.Exception()

I've never particularly been a fan of from imports for several reasons, hence the alternate syntax.

However, I can see that this style has become more common these days, and the code should just go anyway :)