Use sse4_crc32 directly

[zbjornson]

This module tries to load fast-crc32c, which just re-exports functions from sse4_crc32. What do you think of cutting out fast-crc32c and using sse4_crc32 for simplicity?

Looks like fast-crc32c would have only been necessary before f675008 (where you moved the JS impl into this module directly).

The try/catch would still have to try fast-crc32c for at least some time since it's opportunistically loaded (i.e. this change wouldn't cascade down the dependency chain).

[stephenplusplus]

What do you think of cutting out fast-crc32c and using sse4_crc32 for simplicity?

That makes sense!

[ashi009]

🤣 It does make a lot of sense and should have been done a year ago. As otherwise, ashi009/node-fast-crc32c#14 won't be my issue to fix and ashi009/node-fast-crc32c#19 won't happen and circle back to a bug found in your code.

I don't quite follow why f675008 is necessary? As fast-crc32 should have already served as a guard to allow sse4_crc32 failed to install. As far as I know, npm always installs optional dependencies, and it won't produce any warning unless some of them are failed to install.

[stephenplusplus]

If I remember correctly, many users were failing to install sse4_crc32. We were getting hit with issues pretty regularly that would need to be funneled to their repo. We instead switched to the documentation suggestion that if the speed boost is important, the user can install your library directly.

I still think we should make this change to use sse4_crc32 directly, and thanks for being patient with your help!

[ashi009]

That's unfortunate. It's just an npm thing, and yarn handles this nicely -- it will run node-gyp quietly and won't say a thing if an optional dependency breaks.