Skip to content

Price struct integer overflow #228

@cuongph87

Description

@cuongph87

What version are you using?

Version 22.0.0. But it shouldn't matter.

What did you do?

While the XDR definition specifies int32, the actual Stellar network allows for prices with numerators and denominators exceeding the int32 range. This causes parsing failures when attempting to process such transactions.

A real-world example can be found in this trade:
https://horizon.stellar.org/trades?cursor=237504432974213121-0&limit=1

What did you expect to see?

Larger values observed in the network should be handled properly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions