Question: Should the StatsigClient.intialization call only happen from worker thread?

[josephjames26]

Looks like the StatsigClient initialization has some Gson processing that is not happening in the IO thread.

      at java.util.HashMap.getNode(HashMap.java:574)
       at java.util.LinkedHashMap.get(LinkedHashMap.java:554)
       at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:512)
       at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40)
       at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:200)
       at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:158)
       at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$2.readIntoField(ReflectiveTypeAdapterFactory.java:267)
       at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$FieldReflectionAdapter.readField(ReflectiveTypeAdapterFactory.java)
       at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:516)
       at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$2.readIntoField(ReflectiveTypeAdapterFactory.java:267)
       at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$FieldReflectionAdapter.readField(ReflectiveTypeAdapterFactory.java)
       at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:516)
       at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40)
       at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:200)
       at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:158)
       at com.google.gson.Gson.fromJson(Gson.java:1361)
       at com.google.gson.Gson.fromJson(Gson.java:1262)
       at com.google.gson.Gson.fromJson(Gson.java:1171)
       at com.google.gson.Gson.fromJson(Gson.java:1137)
       at com.statsig.androidsdk.Store.syncLoadFromLocalStorage(Store.kt:72)
       at com.statsig.androidsdk.StatsigClient.setup(StatsigClient.kt:1012)
       at com.statsig.androidsdk.StatsigClient.access$setup(StatsigClient.kt)
       at com.statsig.androidsdk.StatsigClient$initialize$2.invokeSuspend(StatsigClient.kt:153)
       at com.statsig.androidsdk.StatsigClient$initialize$2.invoke(StatsigClient.kt:2)
       at com.statsig.androidsdk.StatsigClient$initialize$2.invoke(StatsigClient.kt:1)
       at com.statsig.androidsdk.ErrorBoundary.captureAsync(ErrorBoundary.kt:72)
       at com.statsig.androidsdk.StatsigClient.initialize(StatsigClient.kt:151)
       at com.statsig.androidsdk.Statsig.initialize(Statsig.kt:76)

[xinlili-statsig]

Given the default behavior of loading from cache is sync, so it should be happening within the main thread

[josephjames26]

Thank you, @xinlili-statsig, for clarifying this. Could we also move the Gson functionality under io so that we can invoke it directly from the main thread? At the moment we’re using it on the main thread and are seeing ANRs.

Here is the sample of what I'm suggesting -> #22

[xinlili-statsig]

Sorry I missed following up this thread earlier
it's a valid suggestion. Are you calling initialize or initializeAsync()?
I have been thinking if the whole setupAsync function should happen with io thread.
I know that load from cache is not within setupAsync by default, but there is an option to load cache asynchronously.

[josephjames26]

@xinlili-statsig I'm calling StatsigClient.initialize() (not initializeAsync()). Is it ok if I change the PR from draft state to ready for review?

[josephjames26]

Closing due to inactivity

[josephjames26]

Closing due to inactivity