Server keeps getting stuck in infinite loops, seemingly related to "LoopingCueManager"

[Pfodge]

Describe the bug

Description
Server locks up in certain circumstances requiring restarting via docker compose restart before being able to continue playing

Steps to reproduce

• Honestly very hard to reproduce as it has happened in two very distinct circumstances:
  • Once after everyone (4 players) had gone to bed but before getting end of day results screens, in which the game was stuck with everyone in bed just after receiving "server has gone to sleep" message.
  • Once at around 9:20am on Spring 27, Year 1, in which the game became unresponsive to certain interactions (couldn't open containers, couldn't pick up items off the ground) but could still walk around

Expected behavior

In both instances of the issue the server console was constantly spitting out the following:

sdvd-server       | [app         ]    at StardewValley.Audio.LoopingCueManager.Update(GameLocation currentLocation) in D:\GitlabRunner\builds\Gq5qA5P4\1\ConcernedApe\stardewvalley\Farmer\Farmer\Audio\LoopingCueManager.cs:line 35
sdvd-server       | [app         ]    at StardewValley.Game1.UpdateLocations(GameTime time) in D:\GitlabRunner\builds\Gq5qA5P4\1\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 6111
sdvd-server       | [app         ]    at StardewValley.Game1._update(GameTime gameTime) in D:\GitlabRunner\builds\Gq5qA5P4\1\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 4326
sdvd-server       | [app         ]    at StardewValley.Game1.Update(GameTime gameTime) in D:\GitlabRunner\builds\Gq5qA5P4\1\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 3454
sdvd-server       | [app         ]    at StardewModdingAPI.Framework.SCore.OnPlayerInstanceUpdating(SGame instance, GameTime gameTime, Action runUpdate) in /home/runner/work/SMAPI/SMAPI/src/SMAPI/Framework/SCore.cs:line 1147

I could not clear the issue and was forced to restart the docker in order to continue playing

Additional Context

Including some of the server console messages up until the issue arose the second time (which was around around 9:20am on Spring 27, Year 1) :

sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:12 TRACE SMAPI]    task complete.
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:26 TRACE game] Warping to FarmHouse
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:26 TRACE SMAPI] Context: before save.
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:26 TRACE JunimoServer] Saving
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:26 TRACE JunimoServer] waiting 60 sec to kick non-ready players
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:27 TRACE JunimoServer] waited 20 sec to kick barrier. Was Canceled
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:42 TRACE game] SaveGame.Save() called.
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:42 TRACE SMAPI] Synchronizing 'Save' task...
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:42 TRACE game] Saving without compression...
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:42 TRACE SMAPI]    task complete.
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:42 TRACE game] SaveGame.Save() completed without exceptions.
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:46 TRACE SMAPI] Context: after save, starting spring 27 Y1.
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:24:46 TRACE game] Warping to Farm
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:25:07 INFO  JunimoServer] Clicking DialogBox
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:25:08 INFO  JunimoServer] Clicking DialogBox
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:25:26 TRACE JunimoServer] waited 60 sec to kick non-ready players. Was Canceled.
sdvd-server       | [app         ] �[39;49m�[39;49m�[30m[11:27:56 INFO  JunimoServer] Healthcheck ✓
sdvd-server       | [app         ] �[39;49m�[39;49m�[31m[11:28:48 ERROR game] An error occurred in the base update loop: NullReferenceException: Object reference not set to an instance of an object.
sdvd-server       | [app         ]    at StardewValley.Audio.LoopingCueManager.Update(GameLocation currentLocation) in D:\GitlabRunner\builds\Gq5qA5P4\1\ConcernedApe\stardewvalley\Farmer\Farmer\Audio\LoopingCueManager.cs:line 35
sdvd-server       | [app         ]    at StardewValley.Game1.UpdateLocations(GameTime time) in D:\GitlabRunner\builds\Gq5qA5P4\1\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 6111
sdvd-server       | [app         ]    at StardewValley.Game1._update(GameTime gameTime) in D:\GitlabRunner\builds\Gq5qA5P4\1\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 4326
sdvd-server       | [app         ]    at StardewValley.Game1.Update(GameTime gameTime) in D:\GitlabRunner\builds\Gq5qA5P4\1\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 3454
sdvd-server       | [app         ]    at StardewModdingAPI.Framework.SCore.OnPlayerInstanceUpdating(SGame instance, GameTime gameTime, Action runUpdate) in /home/runner/work/SMAPI/SMAPI/src/SMAPI/Framework/SCore.cs:line 1147

Environment

• OS: Ubuntu Server 24.04
• Docker: 29.3.0, build 5927d80
• JunimoServer: 1.5.0-preview.53
• Mods: TimeSpeed

Final checks

• Read the contribution guide.
• Check existing issues.

[Bombombur]

TimeSpeed cause less issues as IT's StardewTime / Time Master but it could be related to it.
(Issue track for that in Discord, link )

Can you try to reproduce it without the Mod?

As sound files are not loaded for the Server but the .dll isn't patch normally anymore it should not make issues.

And the last line of your log, is the issue normally which the "stuck"7"crash" and is all Time related.

[Pfodge]

Well I've gone about testing it a different way. I tried making the error happen with just myself on the server (so the server had 2 players, me and the server) with TimeSpeed cranked up really fast (SecondsPerMinute set to 0.1). I got all the way through Spring of Year 1 until the 2nd day of Summer without it producing the error once. I usually play with 4 - 5 people on the server so either it's something to do with that, or in our games a player has activated something that I did not in my test run

[Bombombur]

Well I've gone about testing it a different way. I tried making the error happen with just myself on the server (so the server had 2 players, me and the server) with TimeSpeed cranked up really fast (SecondsPerMinute set to 0.1). I got all the way through Spring of Year 1 until the 2nd day of Summer without it producing the error once. I usually play with 4 - 5 people on the server so either it's something to do with that, or in our games a player has activated something that I did not in my test run

Did it crash or the day didn't start on 2nd to 3rd of summer YR1 ( which is normally when the "Earthquake"/"Kabumm" interaction happen), which might could stuck then if the TimeMod did something. Based on that i would guess you might could add the Mod in the SMAPI logging to see what's happen if it not report the status in the cli/log.

About 27th Spring YR1.. i'm not aware of any event or random event which cause such issues. If you only have the TimeMod running ( also SDVE hasn't one) but hard to say if there not maybe someone of the players have a different Mod pack running which might adding something which cause an issue.

[JulianVallee]

Thanks for the detailed report, and top notch support 🙏

It's hard to tell the exact root-cause, but sounds pretty similar to what I ran into on my end. Given the random nature and that it tends to happen under load, it's most likely coming from a few race conditions I found in both the mod and game, and a smol misconception about the barrier sync handling on my side.

As I kept finding such things, I'm quite behind on my planned shedule and can't give an honest ETA for the next release, but definitely doing my best to resolve all this asap. But for now I would definitely consider it a bug on our end, and unlikely to be related to mods

[ssadras]

Any fix on this so far? I don't want to loose the progress but the docker compose restart also didn't help. Any ways to even get passed the issue?