Do not use "$" for text nodes

[hstaudacher]

When you want to get the text node of an element you can use the @SerializedName( "$" ) annotation which is pretty nice. Anyway, there are some problems with the "$".

Converting xml to objects works fine with this approach. But if you want to do a serialization back as json with plain Gson you may ran into problems. The field gets serialized with the name "$" because Gson also respects the @SerializedName annotation. This causes huge problems if you want to store the serialized object into databases e.g. MongoDB forbids to start keys with "$".

So, replacing the "$" would break API and is not an option I think. But would it be possible to make it configurable? By taking a first look at the code this should be doable, right?

[hstaudacher]

any opinion?

[roman-mazur]

Sorry for a delayed response. Yes, it should be doable. If you make an additional option and make XmlReader use it, it should work.