Broken npm symlink: Unable to call npm in scripts property

[s0x]

Gradle's tartree does not keep symbolic links. Therefore the symbolic link to npm got lost. This leads to the inability to use npm in the scripts property.

See issue: https://issues.gradle.org/browse/GRADLE-2844

[s0x]

This only applies if a local copy is downloaded and used

Steps to reproduce

1. Create package.json

{
  "name": "example",
  "version": "1.0.0",
  "scripts": {
    "myscript": "npm run script1 && npm run script2",
    "script1": "echo Script1",
    "script2": "echo Script2"
  }
}

2. Create build.gradle

...
apply plugin: "com.moowork.node"
node {
    download = true
}
task myTask(type: NpmTask) {
    args = ['run', 'myscript']
}

3. call gradle myTask

Resulting Output

> npm run script1 && npm run script2

BUILD SUCCESSFUL

Expected Output

> npm run script1 && npm run script2

> echo Script1
Script1

> echo Script2
Script2

BUILD SUCCESSFUL

[srs]

Hi.

I have tried what you describe here on existing code and it works as expected. What version of Gradle are you using? And what OS are you running on?

Running on Mac here and it's working as expected. The output is correct without the patch.

:myTask

> example@1.0.0 myscript /Users/srs/development/workspace/srs/gradle-node-example
> npm run script1 && npm run script2


> example@1.0.0 script1 /Users/srs/development/workspace/srs/gradle-node-example
> echo Script1

Script1

> example@1.0.0 script2 /Users/srs/development/workspace/srs/gradle-node-example
> echo Script2

Script2

BUILD SUCCESSFUL

[s0x]

I'm using Ubuntu 16.04LTS

Linux pc2307-linux 4.4.0-51-generic #72-Ubuntu SMP Thu Nov 24 18:29:54 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

I tried it with Gradle 2.10 and 3.2.1. Exactly the same result. I'll give it a try on a Mac and come back to you with the results.

[s0x]

I just tried it on a Mac and It doesn't work there either. Have you set download to true? As described, this only occurs if you use a local node installation. Alternatively you could use the attached files to reproduce it

project.zip

[s0x]

Digging a bit deeper into this it seems that this occures only in gradle-node-plugin >= 0.14 and was introduced by moving npm into the cache directory (00cc0c8).

[s0x]

@srs: Any update on this?

[sirianni]

We are hitting this issue as well. Would be great if the pull request could be accepted.