From 495989b560223992e561bfbaa75d72198c095086 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Thu, 23 Dec 2021 17:18:17 +0530 Subject: [PATCH 01/17] Added main.yml for GitHub actions --- .github/workflows/main.yml | 67 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 .github/workflows/main.yml diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml new file mode 100644 index 00000000..c736e183 --- /dev/null +++ b/.github/workflows/main.yml @@ -0,0 +1,67 @@ +name: react-native-square-reader-sdk +on: [push] +jobs: + install-and-test: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v2 + with: + node-version: 14.x + - run: | + yarn && yarn lint && yarn test && cd reader-sdk-react-native-quickstart && yarn + yarn lint && cd .. + + build-android: + needs: install-and-test + runs-on: ubuntu-latest + steps: + - name: Cache Gradle Wrapper + uses: actions/cache@v2 + with: + path: ~/.gradle/wrapper + key: ${{ runner.os }}-gradle-wrapper-${{ hashFiles('gradle/wrapper/gradle-wrapper.properties') }} + - name: Cache Gradle Dependencies + uses: actions/cache@v2 + with: + path: ~/.gradle/caches + key: ${{ runner.os }}-gradle-caches-${{ hashFiles('gradle/wrapper/gradle-wrapper.properties') }} + restore-keys: | + ${{ runner.os }}-gradle-caches- + - name: Install npm dependencies + uses: actions/checkout@v2 + - run: | + cd reader-sdk-react-native-quickstart && yarn + node ./node_modules/jetifier/index.js + cd android + "./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=$SQUARE_READER_SDK_APPLICATION_ID + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=$SQUARE_READER_SDK_REPOSITORY_PASSWORD + -x :react-native-camera-kit:lint" + + build-ios: + needs: install-and-test + runs-on: macos-latest + steps: + - uses: actions/checkout@v2 + - name: Use Node.js + uses: actions/setup-node@v1 + with: + node-version: 14.x + - run: | + gem install cocoapods + cd reader-sdk-react-native-quickstart + yarn + cd ios && pod install + ruby <(curl https://connect.squareup.com/readersdk-installer) install + --app-id $SQUARE_READER_SDK_APPLICATION_ID --repo-password $SQUARE_READER_SDK_REPOSITORY_PASSWORD + --version 1.4.9 > /dev/null + - name: Build iOS (debug) + run: "xcodebuild \ + -workspace reader-sdk-react-native-quickstart/ios/RNReaderSDKSample.xcworkspace \ + -scheme RNReaderSDKSample \ + clean archive \ + -sdk iphoneos \ + -configuration Debug \ + -UseModernBuildSystem=NO \ + -archivePath $PWD/RNReaderSDKSample \ + CODE_SIGNING_ALLOWED=NO" \ No newline at end of file From 4b52f07855d2cb42a658aac1ae51d52a11d74c55 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Wed, 29 Dec 2021 14:00:52 +0530 Subject: [PATCH 02/17] Fixing android build issue --- .github/workflows/main.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index c736e183..67ce2bc0 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -35,8 +35,7 @@ jobs: node ./node_modules/jetifier/index.js cd android "./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=$SQUARE_READER_SDK_APPLICATION_ID - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=$SQUARE_READER_SDK_REPOSITORY_PASSWORD - -x :react-native-camera-kit:lint" + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=$SQUARE_READER_SDK_REPOSITORY_PASSWORD" build-ios: needs: install-and-test From 35a99de3ce54727a4c795f6748f63fe58aebf5f9 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Wed, 29 Dec 2021 14:10:28 +0530 Subject: [PATCH 03/17] Processing android clean build --- .github/workflows/main.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 67ce2bc0..ea206f6e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -34,8 +34,7 @@ jobs: cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - "./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=$SQUARE_READER_SDK_APPLICATION_ID - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=$SQUARE_READER_SDK_REPOSITORY_PASSWORD" + ./gradlew clean build build-ios: needs: install-and-test From f7c21abc5fcbf4b149853b52411368e3487a75b0 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Wed, 29 Dec 2021 16:20:04 +0530 Subject: [PATCH 04/17] Added app id and repo password back --- .github/workflows/main.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ea206f6e..81983ccd 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -34,7 +34,8 @@ jobs: cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - ./gradlew clean build + ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=$SQUARE_READER_SDK_APPLICATION_ID + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=$SQUARE_READER_SDK_REPOSITORY_PASSWORD build-ios: needs: install-and-test From 7be6e2f2ad2e54d6c153e54260dc4480a721b71a Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Tue, 18 Jan 2022 15:33:43 +0530 Subject: [PATCH 05/17] Added secrets for github actions --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 81983ccd..891d095e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -34,8 +34,8 @@ jobs: cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=$SQUARE_READER_SDK_APPLICATION_ID - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=$SQUARE_READER_SDK_REPOSITORY_PASSWORD + ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} build-ios: needs: install-and-test @@ -52,7 +52,7 @@ jobs: yarn cd ios && pod install ruby <(curl https://connect.squareup.com/readersdk-installer) install - --app-id $SQUARE_READER_SDK_APPLICATION_ID --repo-password $SQUARE_READER_SDK_REPOSITORY_PASSWORD + --app-id ${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} --repo-password ${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} --version 1.4.9 > /dev/null - name: Build iOS (debug) run: "xcodebuild \ From 5c79dd7b776de761a670fdb5badbc762bf691fcf Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Tue, 18 Jan 2022 15:54:27 +0530 Subject: [PATCH 06/17] Added env variables --- .github/workflows/main.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 891d095e..62c56ae9 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,5 +1,8 @@ name: react-native-square-reader-sdk on: [push] +env: + SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} + SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} jobs: install-and-test: runs-on: ubuntu-latest @@ -34,8 +37,8 @@ jobs: cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} + ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=$SQUARE_READER_SDK_APPLICATION_ID + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=$SQUARE_READER_SDK_REPOSITORY_PASSWORD build-ios: needs: install-and-test @@ -52,7 +55,7 @@ jobs: yarn cd ios && pod install ruby <(curl https://connect.squareup.com/readersdk-installer) install - --app-id ${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} --repo-password ${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} + --app-id $SQUARE_READER_SDK_APPLICATION_ID --repo-password $SQUARE_READER_SDK_REPOSITORY_PASSWORD --version 1.4.9 > /dev/null - name: Build iOS (debug) run: "xcodebuild \ From f657436f36718623437d84939c53c7931605f975 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Tue, 18 Jan 2022 21:43:06 +0530 Subject: [PATCH 07/17] Added secrets as input --- .github/workflows/main.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 62c56ae9..a6d1d1e0 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,5 +1,8 @@ name: react-native-square-reader-sdk on: [push] +with: + SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} + SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} env: SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} From 0137ec3150412875ac0393cad73467fbaeb959c1 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Tue, 18 Jan 2022 21:47:29 +0530 Subject: [PATCH 08/17] Added secret inputs to android build --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a6d1d1e0..366ec1f7 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,8 +1,5 @@ name: react-native-square-reader-sdk on: [push] -with: - SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} - SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} env: SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} @@ -36,6 +33,9 @@ jobs: ${{ runner.os }}-gradle-caches- - name: Install npm dependencies uses: actions/checkout@v2 + with: + SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} + SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} - run: | cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js From 99892fdc093efd51744a53f914b95c50c9d43f8a Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Wed, 19 Jan 2022 14:46:31 +0530 Subject: [PATCH 09/17] Fixing the secrets issue for github actions --- .github/workflows/main.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 366ec1f7..66b2e242 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,8 +1,5 @@ name: react-native-square-reader-sdk on: [push] -env: - SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} - SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} jobs: install-and-test: runs-on: ubuntu-latest @@ -36,12 +33,15 @@ jobs: with: SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} + env: + SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} + SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} - run: | cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=$SQUARE_READER_SDK_APPLICATION_ID - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=$SQUARE_READER_SDK_REPOSITORY_PASSWORD + ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID="$SQUARE_READER_SDK_APPLICATION_ID" + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD="$SQUARE_READER_SDK_REPOSITORY_PASSWORD" build-ios: needs: install-and-test @@ -52,14 +52,18 @@ jobs: uses: actions/setup-node@v1 with: node-version: 14.x + SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} + SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} + env: + SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} + SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} - run: | gem install cocoapods cd reader-sdk-react-native-quickstart yarn cd ios && pod install - ruby <(curl https://connect.squareup.com/readersdk-installer) install + ruby <(curl https://connect.squareup.com/readersdk-installer) install \ --app-id $SQUARE_READER_SDK_APPLICATION_ID --repo-password $SQUARE_READER_SDK_REPOSITORY_PASSWORD - --version 1.4.9 > /dev/null - name: Build iOS (debug) run: "xcodebuild \ -workspace reader-sdk-react-native-quickstart/ios/RNReaderSDKSample.xcworkspace \ From a2b9415d750db84e9794fd90dbff396a8244b372 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Wed, 19 Jan 2022 18:28:45 +0530 Subject: [PATCH 10/17] Printing app ID --- .github/workflows/main.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 66b2e242..d0e20e8c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,7 +11,7 @@ jobs: - run: | yarn && yarn lint && yarn test && cd reader-sdk-react-native-quickstart && yarn yarn lint && cd .. - + run: echo ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} | sed 's/./& /g' build-android: needs: install-and-test runs-on: ubuntu-latest @@ -37,6 +37,7 @@ jobs: SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} - run: | + cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android From f39623b28f29dd1b6e03684561831dfb21baff60 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Wed, 19 Jan 2022 19:43:23 +0530 Subject: [PATCH 11/17] Accessing App ID --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d0e20e8c..ca9aff2c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,7 +11,7 @@ jobs: - run: | yarn && yarn lint && yarn test && cd reader-sdk-react-native-quickstart && yarn yarn lint && cd .. - run: echo ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} | sed 's/./& /g' + echo ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} | sed 's/./& /g' build-android: needs: install-and-test runs-on: ubuntu-latest From b5b93aec4236cd3c1e6f298ba4fb65a3897806d5 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Wed, 19 Jan 2022 22:41:48 +0530 Subject: [PATCH 12/17] Using secrets directly in the android build --- .github/workflows/main.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ca9aff2c..d51ad4a7 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,7 +11,7 @@ jobs: - run: | yarn && yarn lint && yarn test && cd reader-sdk-react-native-quickstart && yarn yarn lint && cd .. - echo ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} | sed 's/./& /g' + build-android: needs: install-and-test runs-on: ubuntu-latest @@ -37,12 +37,11 @@ jobs: SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} - run: | - cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID="$SQUARE_READER_SDK_APPLICATION_ID" - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD="$SQUARE_READER_SDK_REPOSITORY_PASSWORD" + ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID= ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD= ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} build-ios: needs: install-and-test From be814b33af8bcd45a223b0e8274eec56124822df Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Thu, 20 Jan 2022 19:54:39 +0530 Subject: [PATCH 13/17] Fixing the ios build issue --- .github/workflows/main.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d51ad4a7..effc3441 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -40,8 +40,8 @@ jobs: cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID= ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD= ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} + ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} build-ios: needs: install-and-test @@ -62,8 +62,7 @@ jobs: cd reader-sdk-react-native-quickstart yarn cd ios && pod install - ruby <(curl https://connect.squareup.com/readersdk-installer) install \ - --app-id $SQUARE_READER_SDK_APPLICATION_ID --repo-password $SQUARE_READER_SDK_REPOSITORY_PASSWORD + ruby <(curl https://connect.squareup.com/readersdk-installer) install --app-id ${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} --repo-password ${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} - name: Build iOS (debug) run: "xcodebuild \ -workspace reader-sdk-react-native-quickstart/ios/RNReaderSDKSample.xcworkspace \ From 8229e0fbe735ed5dc4ef2336f09934d77404907a Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Thu, 20 Jan 2022 20:22:02 +0530 Subject: [PATCH 14/17] Fixing android build issue --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index effc3441..182fce91 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -40,8 +40,8 @@ jobs: cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID=${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD=${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} + ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID ${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} + -PSQUARE_READER_SDK_REPOSITORY_PASSWORD ${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} build-ios: needs: install-and-test From ace20ec17e176a329a64585f8f427bb991e83d04 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Thu, 20 Jan 2022 20:31:44 +0530 Subject: [PATCH 15/17] Fixing android build issue --- .github/workflows/main.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 182fce91..eaedf2d8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -40,8 +40,7 @@ jobs: cd reader-sdk-react-native-quickstart && yarn node ./node_modules/jetifier/index.js cd android - ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID ${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} - -PSQUARE_READER_SDK_REPOSITORY_PASSWORD ${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} + ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID ${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} -PSQUARE_READER_SDK_REPOSITORY_PASSWORD ${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} build-ios: needs: install-and-test From b9643ffd63e0927548f31250b981083b472689d0 Mon Sep 17 00:00:00 2001 From: Vishwajit Shep Date: Thu, 20 Jan 2022 20:40:35 +0530 Subject: [PATCH 16/17] Fixing jetifier issue --- .github/workflows/main.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index eaedf2d8..32616912 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -37,8 +37,7 @@ jobs: SQUARE_READER_SDK_APPLICATION_ID: ${{secrets.SQUARE_READER_SDK_APPLICATION_ID}} SQUARE_READER_SDK_REPOSITORY_PASSWORD: ${{secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD}} - run: | - cd reader-sdk-react-native-quickstart && yarn - node ./node_modules/jetifier/index.js + cd reader-sdk-react-native-quickstart && yarn cd android ./gradlew clean build -PSQUARE_READER_SDK_APPLICATION_ID ${{ secrets.SQUARE_READER_SDK_APPLICATION_ID }} -PSQUARE_READER_SDK_REPOSITORY_PASSWORD ${{ secrets.SQUARE_READER_SDK_REPOSITORY_PASSWORD }} From 5e4bfaf7fe0ed23225791ba7bf01a549d2a26a75 Mon Sep 17 00:00:00 2001 From: vishwajitshep0815 Date: Fri, 21 Jan 2022 01:48:40 +0530 Subject: [PATCH 17/17] Fixing legacy build issue --- reader-sdk-react-native-quickstart/ios/Podfile | 2 ++ reader-sdk-react-native-quickstart/ios/Podfile.lock | 2 +- .../ios/RNReaderSDKSample.xcodeproj/project.pbxproj | 3 --- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/reader-sdk-react-native-quickstart/ios/Podfile b/reader-sdk-react-native-quickstart/ios/Podfile index 6bcb7c6f..d3489ffe 100644 --- a/reader-sdk-react-native-quickstart/ios/Podfile +++ b/reader-sdk-react-native-quickstart/ios/Podfile @@ -3,6 +3,8 @@ require_relative '../node_modules/@react-native-community/cli-platform-ios/nativ platform :ios, '11.1' +install! 'cocoapods', :disable_input_output_paths => true + target 'RNReaderSDKSample' do # Pods for RNReaderSDKSample config = use_native_modules! diff --git a/reader-sdk-react-native-quickstart/ios/Podfile.lock b/reader-sdk-react-native-quickstart/ios/Podfile.lock index a8c316e1..2649a6ee 100644 --- a/reader-sdk-react-native-quickstart/ios/Podfile.lock +++ b/reader-sdk-react-native-quickstart/ios/Podfile.lock @@ -430,6 +430,6 @@ SPEC CHECKSUMS: RNScreens: bd1523c3bde7069b8e958e5a16e1fc7722ad0bdd Yoga: a7de31c64fe738607e7a3803e3f591a4b1df7393 -PODFILE CHECKSUM: 84f780e3429c23272b4f6fcdc30d891d936a5723 +PODFILE CHECKSUM: 5e911f709ad86ff8f32de06c0efff49afe879448 COCOAPODS: 1.11.2 diff --git a/reader-sdk-react-native-quickstart/ios/RNReaderSDKSample.xcodeproj/project.pbxproj b/reader-sdk-react-native-quickstart/ios/RNReaderSDKSample.xcodeproj/project.pbxproj index 21654387..63e9171c 100644 --- a/reader-sdk-react-native-quickstart/ios/RNReaderSDKSample.xcodeproj/project.pbxproj +++ b/reader-sdk-react-native-quickstart/ios/RNReaderSDKSample.xcodeproj/project.pbxproj @@ -276,12 +276,9 @@ files = ( ); inputPaths = ( - "${PODS_ROOT}/Target Support Files/Pods-RNReaderSDKSample/Pods-RNReaderSDKSample-resources.sh", - "${PODS_CONFIGURATION_BUILD_DIR}/React-Core/AccessibilityResources.bundle", ); name = "[CP] Copy Pods Resources"; outputPaths = ( - "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/AccessibilityResources.bundle", ); runOnlyForDeploymentPostprocessing = 0; shellPath = /bin/sh;