The reference to process here seems to result in issues in browsers since it isn't available there. I think this can be resolved with a rollup plugin but this wouldn't help in Svelte's repl. Perhaps it's better to test if typeof process === 'undefined' instead?
|
if (!process) console.warn(message) |
Also, we should standardize our logging/warning logic here. I would argue we would want to warn during dev and not in production but this seems only include 'test'?
|
if (process && process.env.NODE_ENV !== 'test') { |
The reference to
processhere seems to result in issues in browsers since it isn't available there. I think this can be resolved with a rollup plugin but this wouldn't help in Svelte's repl. Perhaps it's better to test iftypeof process === 'undefined'instead?florence-datacontainer/src/helpers/logging.js
Line 2 in 2db2341
Also, we should standardize our logging/warning logic here. I would argue we would want to warn during dev and not in production but this seems only include 'test'?
florence-datacontainer/src/helpers/logging.js
Line 4 in 2db2341