From 48a7f24e5373a98fe7ccbb400b2d85efcf4113b7 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 20 Jan 2024 17:33:34 +0100
Subject: [PATCH 01/39] Windows seems done

---
 PublishFiles/SS14.desktop                     |  2 +
 SS14.Launcher.Bootstrap/Program.cs            |  2 +-
 SS14.Launcher/ProtocolSetup.cs                | 89 +++++++++++++++++++
 .../Views/MainWindowTabs/OptionsTabView.xaml  |  2 +
 .../MainWindowTabs/OptionsTabView.xaml.cs     | 16 ++++
 5 files changed, 110 insertions(+), 1 deletion(-)
 create mode 100644 SS14.Launcher/ProtocolSetup.cs

diff --git a/PublishFiles/SS14.desktop b/PublishFiles/SS14.desktop
index a6dc97476..5f6ffefd0 100755
--- a/PublishFiles/SS14.desktop
+++ b/PublishFiles/SS14.desktop
@@ -5,3 +5,5 @@ Version=1.0
 Type=Application
 Exec=env ./SS14.Launcher %u
 Name=Space Station 14
+MimeType=x-scheme-handler/ss14s;
+MimeType=x-scheme-handler/ss14;
diff --git a/SS14.Launcher.Bootstrap/Program.cs b/SS14.Launcher.Bootstrap/Program.cs
index 7d745d594..4bc61e93f 100644
--- a/SS14.Launcher.Bootstrap/Program.cs
+++ b/SS14.Launcher.Bootstrap/Program.cs
@@ -19,7 +19,7 @@ public static void Main(string[] args)
             var exeDir = Path.Combine(ourDir, "bin", "SS14.Launcher.exe");
 
             Environment.SetEnvironmentVariable("DOTNET_ROOT", dotnetDir);
-            Process.Start(new ProcessStartInfo(exeDir));
+            Process.Start(new ProcessStartInfo(exeDir, args[0]));
         }
 
         private static void UnfuckDotnetRoot()
diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
new file mode 100644
index 000000000..d4960b0c9
--- /dev/null
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -0,0 +1,89 @@
+using System;
+using System.Diagnostics;
+using Microsoft.Win32;
+using Serilog;
+
+namespace SS14.Launcher;
+
+public static class ProtocolSetup
+{
+    public static bool CheckExisting()
+    {
+        var result = false;
+        if (OperatingSystem.IsWindows())
+        {
+            using var key1 = Registry.ClassesRoot.OpenSubKey("ss14s", false);
+            using var key2 = Registry.ClassesRoot.OpenSubKey("ss14", false);
+            result = key1 != null && key2 != null;
+        }
+
+        if (OperatingSystem.IsMacOS())
+        {
+        }
+
+        if (OperatingSystem.IsLinux())
+        {
+        }
+
+        return result;
+    }
+
+
+    public static void RegisterProtocol()
+    {
+        // Windows registration
+        if (OperatingSystem.IsWindows())
+        {
+            try
+            {
+                var proc = new Process();
+                proc.StartInfo.FileName = "powershell.exe";
+                proc.StartInfo.Arguments = $"-executionpolicy bypass -windowstyle hidden -noninteractive -nologo " +
+                                           $"-file \"{AppDomain.CurrentDomain.BaseDirectory}windows_protocol_register.ps1\"";
+                proc.StartInfo.UseShellExecute = true;
+                proc.StartInfo.Verb = "runas";
+                proc.Start();
+            }
+            catch (System.ComponentModel.Win32Exception)
+            {
+                // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
+                Log.Warning("User declined UAC or doesn't have admin rights.");
+            }
+        }
+        if (OperatingSystem.IsMacOS())
+        {
+        }
+
+        if (OperatingSystem.IsLinux())
+        {
+        }
+    }
+    public static void UnregisterProtocol()
+    {
+        if (OperatingSystem.IsWindows())
+        {
+            try
+            {
+                var proc = new Process();
+                proc.StartInfo.FileName = "powershell.exe";
+                proc.StartInfo.Arguments = $"-executionpolicy bypass -windowstyle hidden -noninteractive -nologo " +
+                                           $"-file \"{AppDomain.CurrentDomain.BaseDirectory}windows_protocol_unregister.ps1\"";
+                proc.StartInfo.UseShellExecute = true;
+                proc.StartInfo.Verb = "runas";
+                proc.Start();
+            }
+            catch (System.ComponentModel.Win32Exception)
+            {
+                // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
+                Log.Warning("User declined UAC or doesn't have admin rights.");
+            }
+        }
+        if (OperatingSystem.IsMacOS())
+        {
+        }
+
+        if (OperatingSystem.IsLinux())
+        {
+        }
+    }
+}
diff --git a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
index 21b8212bb..994fe7a6e 100644
--- a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
+++ b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
@@ -19,6 +19,8 @@
               HorizontalAlignment="Left" Click="ClearServerContentPressed" />
       <Button Content="Open log directory" DockPanel.Dock="Bottom" HorizontalAlignment="Left"
               Command="{Binding OpenLogDirectory}"/>
+      <Button Name="Protocols" Content="Register/Deregister Protocols" DockPanel.Dock="Bottom"
+              HorizontalAlignment="Left" Click="RegisterProtocols" />
 
       <StackPanel Orientation="Vertical">
         <Button Content="Account Settings" Margin="4" Command="{Binding OpenAccountSettings}" HorizontalAlignment="Left" />
diff --git a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
index 3c6a530b7..2bcbe5dff 100644
--- a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
@@ -4,6 +4,7 @@
 using Avalonia.Threading;
 using Avalonia.VisualTree;
 using ReactiveUI;
+using Serilog;
 using SS14.Launcher.Utility;
 using SS14.Launcher.ViewModels.MainWindowTabs;
 
@@ -43,4 +44,19 @@ private async void OpenHubSettings(object? sender, RoutedEventArgs args)
     {
         await new HubSettingsDialog().ShowDialog(this.GetVisualRoot() as Window);
     }
+
+    private async void RegisterProtocols(object? _1, RoutedEventArgs _2)
+    {
+        if (ProtocolSetup.CheckExisting())
+        {
+            Log.Information("We already have the protocols registered.");
+            ProtocolSetup.UnregisterProtocol();
+        }
+        else
+        {
+            Log.Information("We don't have the protocols registered.");
+            ProtocolSetup.RegisterProtocol();
+        }
+
+    }
 }

From 831222dd03265e1455275b0818daaa9c2dab657a Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 20 Jan 2024 17:36:52 +0100
Subject: [PATCH 02/39] OOPs forgor

---
 SS14.Launcher.Bootstrap/console.bat            |  5 -----
 .../windows_protocol_register.ps1              | 18 ++++++++++++++++++
 .../windows_protocol_unregister.ps1            |  7 +++++++
 3 files changed, 25 insertions(+), 5 deletions(-)
 delete mode 100644 SS14.Launcher.Bootstrap/console.bat
 create mode 100644 SS14.Launcher.Bootstrap/windows_protocol_register.ps1
 create mode 100644 SS14.Launcher.Bootstrap/windows_protocol_unregister.ps1

diff --git a/SS14.Launcher.Bootstrap/console.bat b/SS14.Launcher.Bootstrap/console.bat
deleted file mode 100644
index 15293c64d..000000000
--- a/SS14.Launcher.Bootstrap/console.bat
+++ /dev/null
@@ -1,5 +0,0 @@
-SET DOTNET_ROOT "%CD%\dotnet"
-
-dotnet\dotnet.exe bin\SS14.Launcher.dll
-
-PAUSE
diff --git a/SS14.Launcher.Bootstrap/windows_protocol_register.ps1 b/SS14.Launcher.Bootstrap/windows_protocol_register.ps1
new file mode 100644
index 000000000..2f667a8d1
--- /dev/null
+++ b/SS14.Launcher.Bootstrap/windows_protocol_register.ps1
@@ -0,0 +1,18 @@
+$value = "`"$PSScriptRoot\Space Station 14 Launcher.exe`" `"%1`""
+$HKCR = "Registry::HKEY_CLASSES_ROOT"
+
+# Create registry key ss14s://
+New-Item -Path "$HKCR\ss14s" -Force
+New-Item -Path "$HKCR\ss14s\Shell\Open\Command" -Force
+
+# Create registry key ss14://
+New-Item -Path "$HKCR\ss14" -Force
+New-Item -Path "$HKCR\ss14\Shell\Open\Command" -Force
+
+# Set registry key values ss14s://
+Set-ItemProperty -Path "$HKCR\ss14s" -Name "URL Protocol" -Value ""
+Set-ItemProperty -Path "$HKCR\ss14s\Shell\Open\Command" -Name "(default)" -Value $value
+
+# Set registry key values ss14://
+Set-ItemProperty -Path "$HKCR\ss14" -Name "URL Protocol" -Value ""
+Set-ItemProperty -Path "$HKCR\ss14\Shell\Open\Command" -Name "(default)" -Value $value
diff --git a/SS14.Launcher.Bootstrap/windows_protocol_unregister.ps1 b/SS14.Launcher.Bootstrap/windows_protocol_unregister.ps1
new file mode 100644
index 000000000..ea45a5cce
--- /dev/null
+++ b/SS14.Launcher.Bootstrap/windows_protocol_unregister.ps1
@@ -0,0 +1,7 @@
+$HKCR = "Registry::HKEY_CLASSES_ROOT"
+
+# Remove registry key ss14s://
+Remove-Item -Path "$HKCR\ss14s" -Force -Recurse
+
+# Remove registry key ss14://
+Remove-Item -Path "$HKCR\ss14" -Force -Recurse

From 68279e94118df5000dca1d1d99c6c5f8dbf059d7 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 20 Jan 2024 17:38:08 +0100
Subject: [PATCH 03/39] OOPS

---
 SS14.Launcher.Bootstrap/console.bat | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 SS14.Launcher.Bootstrap/console.bat

diff --git a/SS14.Launcher.Bootstrap/console.bat b/SS14.Launcher.Bootstrap/console.bat
new file mode 100644
index 000000000..15293c64d
--- /dev/null
+++ b/SS14.Launcher.Bootstrap/console.bat
@@ -0,0 +1,5 @@
+SET DOTNET_ROOT "%CD%\dotnet"
+
+dotnet\dotnet.exe bin\SS14.Launcher.dll
+
+PAUSE

From 4c1429e04b58fbc53b517e6e98136092ea4e8df8 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 20 Jan 2024 19:44:27 +0100
Subject: [PATCH 04/39] PJB bullied me to making this good

---
 SS14.Launcher.Bootstrap/Program.cs            | 35 ++++++++++++++++++-
 .../windows_protocol_register.ps1             | 18 ----------
 .../windows_protocol_unregister.ps1           |  7 ----
 SS14.Launcher/ProtocolSetup.cs                | 18 ++++++----
 4 files changed, 46 insertions(+), 32 deletions(-)
 delete mode 100644 SS14.Launcher.Bootstrap/windows_protocol_register.ps1
 delete mode 100644 SS14.Launcher.Bootstrap/windows_protocol_unregister.ps1

diff --git a/SS14.Launcher.Bootstrap/Program.cs b/SS14.Launcher.Bootstrap/Program.cs
index 4bc61e93f..b1305724f 100644
--- a/SS14.Launcher.Bootstrap/Program.cs
+++ b/SS14.Launcher.Bootstrap/Program.cs
@@ -2,6 +2,9 @@
 using System.Diagnostics;
 using System.IO;
 using Microsoft.Win32;
+using System.Linq;
+using System.Security;
+using System.Security.Principal;
 
 namespace SS14.Launcher.Bootstrap
 {
@@ -11,6 +14,28 @@ public static void Main(string[] args)
         {
             UnfuckDotnetRoot();
 
+            if (args.Contains("--register-protocol"))
+            {
+                var key1 = Registry.ClassesRoot.CreateSubKey("ss14s");
+                key1!.SetValue("URL Protocol", "");
+                key1 = key1.CreateSubKey("Shell\\Open\\Command");
+                key1!.SetValue("", $"\"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe\" \"%1\"");
+                key1.Close();
+
+                var key2 = Registry.ClassesRoot.CreateSubKey("ss14");
+                key2!.SetValue("URL Protocol", "");
+                key2 = key2.CreateSubKey("Shell\\Open\\Command");
+                key2!.SetValue("", $"\"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe\" \"%1\"");
+                key2.Close();
+                Environment.Exit(0);
+            }
+            if (args.Contains("--unregister-protocol"))
+            {
+                Registry.ClassesRoot.DeleteSubKeyTree("ss14s");
+                Registry.ClassesRoot.DeleteSubKeyTree("ss14");
+                Environment.Exit(0);
+            }
+
             var path = typeof(Program).Assembly.Location;
             var ourDir = Path.GetDirectoryName(path);
             Debug.Assert(ourDir != null);
@@ -19,7 +44,15 @@ public static void Main(string[] args)
             var exeDir = Path.Combine(ourDir, "bin", "SS14.Launcher.exe");
 
             Environment.SetEnvironmentVariable("DOTNET_ROOT", dotnetDir);
-            Process.Start(new ProcessStartInfo(exeDir, args[0]));
+            if (args.Length > 0)
+            {
+                var arguments = string.Join(" ", args);
+                Process.Start(new ProcessStartInfo(exeDir, arguments));
+            }
+            else
+            {
+                Process.Start(new ProcessStartInfo(exeDir));
+            }
         }
 
         private static void UnfuckDotnetRoot()
diff --git a/SS14.Launcher.Bootstrap/windows_protocol_register.ps1 b/SS14.Launcher.Bootstrap/windows_protocol_register.ps1
deleted file mode 100644
index 2f667a8d1..000000000
--- a/SS14.Launcher.Bootstrap/windows_protocol_register.ps1
+++ /dev/null
@@ -1,18 +0,0 @@
-$value = "`"$PSScriptRoot\Space Station 14 Launcher.exe`" `"%1`""
-$HKCR = "Registry::HKEY_CLASSES_ROOT"
-
-# Create registry key ss14s://
-New-Item -Path "$HKCR\ss14s" -Force
-New-Item -Path "$HKCR\ss14s\Shell\Open\Command" -Force
-
-# Create registry key ss14://
-New-Item -Path "$HKCR\ss14" -Force
-New-Item -Path "$HKCR\ss14\Shell\Open\Command" -Force
-
-# Set registry key values ss14s://
-Set-ItemProperty -Path "$HKCR\ss14s" -Name "URL Protocol" -Value ""
-Set-ItemProperty -Path "$HKCR\ss14s\Shell\Open\Command" -Name "(default)" -Value $value
-
-# Set registry key values ss14://
-Set-ItemProperty -Path "$HKCR\ss14" -Name "URL Protocol" -Value ""
-Set-ItemProperty -Path "$HKCR\ss14\Shell\Open\Command" -Name "(default)" -Value $value
diff --git a/SS14.Launcher.Bootstrap/windows_protocol_unregister.ps1 b/SS14.Launcher.Bootstrap/windows_protocol_unregister.ps1
deleted file mode 100644
index ea45a5cce..000000000
--- a/SS14.Launcher.Bootstrap/windows_protocol_unregister.ps1
+++ /dev/null
@@ -1,7 +0,0 @@
-$HKCR = "Registry::HKEY_CLASSES_ROOT"
-
-# Remove registry key ss14s://
-Remove-Item -Path "$HKCR\ss14s" -Force -Recurse
-
-# Remove registry key ss14://
-Remove-Item -Path "$HKCR\ss14" -Force -Recurse
diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index d4960b0c9..5612c7cbf 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -23,6 +23,10 @@ public static bool CheckExisting()
 
         if (OperatingSystem.IsLinux())
         {
+            var proc = new Process();
+            proc.StartInfo.FileName = "sh";
+            proc.StartInfo.Arguments = "xdg-mime default x-scheme-handler/ss14;xdg-mime default x-scheme-handler/ss14";
+            proc.Start();
         }
 
         return result;
@@ -37,9 +41,8 @@ public static void RegisterProtocol()
             try
             {
                 var proc = new Process();
-                proc.StartInfo.FileName = "powershell.exe";
-                proc.StartInfo.Arguments = $"-executionpolicy bypass -windowstyle hidden -noninteractive -nologo " +
-                                           $"-file \"{AppDomain.CurrentDomain.BaseDirectory}windows_protocol_register.ps1\"";
+                proc.StartInfo.FileName = "Space Station 14 Launcher.exe";
+                proc.StartInfo.Arguments = "--register-protocol";
                 proc.StartInfo.UseShellExecute = true;
                 proc.StartInfo.Verb = "runas";
                 proc.Start();
@@ -56,6 +59,10 @@ public static void RegisterProtocol()
 
         if (OperatingSystem.IsLinux())
         {
+            var proc = new Process();
+            proc.StartInfo.FileName = "xdg-mime";
+            proc.StartInfo.Arguments = "xdg-mime default SS14.desktop x-scheme-handler/ss14;xdg-mime default SS14.desktop x-scheme-handler/ss14s";
+            proc.Start();
         }
     }
     public static void UnregisterProtocol()
@@ -65,9 +72,8 @@ public static void UnregisterProtocol()
             try
             {
                 var proc = new Process();
-                proc.StartInfo.FileName = "powershell.exe";
-                proc.StartInfo.Arguments = $"-executionpolicy bypass -windowstyle hidden -noninteractive -nologo " +
-                                           $"-file \"{AppDomain.CurrentDomain.BaseDirectory}windows_protocol_unregister.ps1\"";
+                proc.StartInfo.FileName = "Space Station 14 Launcher.exe";
+                proc.StartInfo.Arguments = "--unregister-protocol";
                 proc.StartInfo.UseShellExecute = true;
                 proc.StartInfo.Verb = "runas";
                 proc.Start();

From 14c3eb69ec37814e37b09129fe5f111eb64bd63e Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Tue, 23 Jan 2024 12:05:03 +0100
Subject: [PATCH 05/39] Commiting so i can work on my macbook

---
 .../Contents/Info.plist                       | 23 +++++++++++++++++++
 SS14.Launcher/ProtocolSetup.cs                | 23 +++++++++++++++++++
 2 files changed, 46 insertions(+)

diff --git a/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist b/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist
index d5e34b078..399a468e3 100644
--- a/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist	
+++ b/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist	
@@ -16,5 +16,28 @@
     -->
     <key>CFBundleIconFile</key>
     <string>ss14</string>
+	<key>CFBundleIdentifier</key>
+	<string>com.spacestation14.launcher</string>
+    <key>CFBundleURLTypes</key>
+    <array>
+        <dict>
+            <key>CFBundleURLName</key>
+            <string>com.spacestation14.launcher</string>
+            <key>CFBundleURLSchemes</key>
+            <array>
+                <string>ss14</string>
+            </array>
+        </dict>
+    </array>
+    <array>
+        <dict>
+            <key>CFBundleURLName</key>
+            <string>com.spacestation14.launcher</string>
+            <key>CFBundleURLSchemes</key>
+            <array>
+                <string>ss14s</string>
+            </array>
+        </dict>
+    </array>
 </dict>
 </plist>
diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index 5612c7cbf..ff0cb09c3 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -19,14 +19,21 @@ public static bool CheckExisting()
 
         if (OperatingSystem.IsMacOS())
         {
+            // todo do this (1)
         }
 
         if (OperatingSystem.IsLinux())
         {
+            // todo steam makes its own .desktop and idk if its possible to add mime types to it via steam, so this is a bit of a problem
+            // this will assume you have downloaded the zip launcher
+            // todo how do i get data to see the output of this
             var proc = new Process();
             proc.StartInfo.FileName = "sh";
             proc.StartInfo.Arguments = "xdg-mime default x-scheme-handler/ss14;xdg-mime default x-scheme-handler/ss14";
             proc.Start();
+            // https://stackoverflow.com/questions/206323/how-to-execute-command-line-in-c-get-std-out-results
+            string output = proc.StandardOutput.ReadToEnd();
+            proc.WaitForExit();
         }
 
         return result;
@@ -55,10 +62,20 @@ public static void RegisterProtocol()
         }
         if (OperatingSystem.IsMacOS())
         {
+            // todo ditto (1)
+            // https://eclecticlight.co/2019/03/25/lsregister-a-valuable-undocumented-command-for-launchservices/
+            // https://ss64.com/mac/lsregister.html
+
+            var proc = new Process();
+            // Yes you have to manually go to this
+            proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
+            proc.StartInfo.Arguments = "-f /path/to/your/app.app";
+            proc.Start();
         }
 
         if (OperatingSystem.IsLinux())
         {
+            // todo ditto (2)
             var proc = new Process();
             proc.StartInfo.FileName = "xdg-mime";
             proc.StartInfo.Arguments = "xdg-mime default SS14.desktop x-scheme-handler/ss14;xdg-mime default SS14.desktop x-scheme-handler/ss14s";
@@ -86,10 +103,16 @@ public static void UnregisterProtocol()
         }
         if (OperatingSystem.IsMacOS())
         {
+            // todo ditto (1)
+            var proc = new Process();
+            proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
+            proc.StartInfo.Arguments = "-u /path/to/your/app.app";
+            proc.Start();
         }
 
         if (OperatingSystem.IsLinux())
         {
+            // todo ditto (2)
         }
     }
 }

From e17c3f6595b366ecb14c8af7fd12c3903efcd5e7 Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Wed, 7 Feb 2024 17:43:30 +0100
Subject: [PATCH 06/39] MacOS

---
 .../Contents/Info.plist                       |  9 ----
 SS14.Launcher/ProtocolSetup.cs                | 54 +++++++++++++++----
 2 files changed, 45 insertions(+), 18 deletions(-)

diff --git a/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist b/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist
index 399a468e3..92ac8a038 100644
--- a/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist	
+++ b/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist	
@@ -26,15 +26,6 @@
             <key>CFBundleURLSchemes</key>
             <array>
                 <string>ss14</string>
-            </array>
-        </dict>
-    </array>
-    <array>
-        <dict>
-            <key>CFBundleURLName</key>
-            <string>com.spacestation14.launcher</string>
-            <key>CFBundleURLSchemes</key>
-            <array>
                 <string>ss14s</string>
             </array>
         </dict>
diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index ff0cb09c3..a06ccd7a4 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -19,7 +19,9 @@ public static bool CheckExisting()
 
         if (OperatingSystem.IsMacOS())
         {
-            // todo do this (1)
+            // todo do this
+            // I got no idea how to do this, lsregister does not report anything.
+            // Lets just assume theres no record
         }
 
         if (OperatingSystem.IsLinux())
@@ -60,19 +62,41 @@ public static void RegisterProtocol()
                 Log.Warning("User declined UAC or doesn't have admin rights.");
             }
         }
+        // macOS registration
         if (OperatingSystem.IsMacOS())
         {
-            // todo ditto (1)
-            // https://eclecticlight.co/2019/03/25/lsregister-a-valuable-undocumented-command-for-launchservices/
-            // https://ss64.com/mac/lsregister.html
+            //#if FULL_RELEASE
+            var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
+
+            // > be me
+            // > write protocol registration code
+            // > application runs in some wierd sandbox folder
+            // > :despair:
+            // > find out its about that its cause the user needs to move the app to the applications folder...
+            // > ... or any "suitable" folder...
+            // tldr user needs to move the app manually to get this sandbox restriction lifted. This can be done by
+            // making one of those installer dmg stuff
+            if (path.Contains("AppTranslocation"))
+            {
+                Log.Error("I have been put in apple jail... move me to your application folder");
+                return;
+            }
+
+            var newPath = string.Empty;
+            var appIndex = path.IndexOf(".app", StringComparison.Ordinal);
+            if (appIndex >= 0)
+            {
+                newPath = path.Substring(0, appIndex + 4);
+            }
 
             var proc = new Process();
             // Yes you have to manually go to this
             proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
-            proc.StartInfo.Arguments = "-f /path/to/your/app.app";
+            proc.StartInfo.Arguments = $"-f {newPath}";
             proc.Start();
+            //#endif
         }
-
+        // Linux registration
         if (OperatingSystem.IsLinux())
         {
             // todo ditto (2)
@@ -84,6 +108,7 @@ public static void RegisterProtocol()
     }
     public static void UnregisterProtocol()
     {
+        // Windows unregistration
         if (OperatingSystem.IsWindows())
         {
             try
@@ -101,15 +126,26 @@ public static void UnregisterProtocol()
                 Log.Warning("User declined UAC or doesn't have admin rights.");
             }
         }
+        // macOS unregistration
         if (OperatingSystem.IsMacOS())
         {
-            // todo ditto (1)
+            //#if FULL_RELEASE
+            var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
+
+            var newPath = string.Empty;
+            var appIndex = path.IndexOf(".app", StringComparison.Ordinal);
+            if (appIndex >= 0)
+            {
+                newPath = path.Substring(0, appIndex + 4);
+            }
+
             var proc = new Process();
             proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
-            proc.StartInfo.Arguments = "-u /path/to/your/app.app";
+            proc.StartInfo.Arguments = $"-u {newPath}";
             proc.Start();
+            //#endif
         }
-
+        // Linux unregistration
         if (OperatingSystem.IsLinux())
         {
             // todo ditto (2)

From 81adfa200f41fae8112da4229bcb7f106488da7e Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Wed, 7 Feb 2024 18:02:09 +0100
Subject: [PATCH 07/39] I prefer doing this

---
 SS14.Launcher/ProtocolSetup.cs                    | 14 ++++++++------
 .../Views/MainWindowTabs/OptionsTabView.xaml      |  4 +++-
 .../Views/MainWindowTabs/OptionsTabView.xaml.cs   | 15 +++++----------
 3 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index a06ccd7a4..5e474caed 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -40,8 +40,6 @@ public static bool CheckExisting()
 
         return result;
     }
-
-
     public static void RegisterProtocol()
     {
         // Windows registration
@@ -65,7 +63,8 @@ public static void RegisterProtocol()
         // macOS registration
         if (OperatingSystem.IsMacOS())
         {
-            //#if FULL_RELEASE
+            // Yeah you cant get this to work on dev builds
+            #if FULL_RELEASE
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
             // > be me
@@ -94,7 +93,7 @@ public static void RegisterProtocol()
             proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
             proc.StartInfo.Arguments = $"-f {newPath}";
             proc.Start();
-            //#endif
+            #endif
         }
         // Linux registration
         if (OperatingSystem.IsLinux())
@@ -105,6 +104,7 @@ public static void RegisterProtocol()
             proc.StartInfo.Arguments = "xdg-mime default SS14.desktop x-scheme-handler/ss14;xdg-mime default SS14.desktop x-scheme-handler/ss14s";
             proc.Start();
         }
+        Log.Information("Successfully registered protocol");
     }
     public static void UnregisterProtocol()
     {
@@ -129,7 +129,8 @@ public static void UnregisterProtocol()
         // macOS unregistration
         if (OperatingSystem.IsMacOS())
         {
-            //#if FULL_RELEASE
+            #if FULL_RELEASE
+            Log.Information("Unregistering protocol for macos...");
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
             var newPath = string.Empty;
@@ -143,12 +144,13 @@ public static void UnregisterProtocol()
             proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
             proc.StartInfo.Arguments = $"-u {newPath}";
             proc.Start();
-            //#endif
+            #endif
         }
         // Linux unregistration
         if (OperatingSystem.IsLinux())
         {
             // todo ditto (2)
         }
+        Log.Information("Successfully unregistered protocol");
     }
 }
diff --git a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
index 994fe7a6e..27e9c1d0f 100644
--- a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
+++ b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
@@ -19,8 +19,10 @@
               HorizontalAlignment="Left" Click="ClearServerContentPressed" />
       <Button Content="Open log directory" DockPanel.Dock="Bottom" HorizontalAlignment="Left"
               Command="{Binding OpenLogDirectory}"/>
-      <Button Name="Protocols" Content="Register/Deregister Protocols" DockPanel.Dock="Bottom"
+      <Button Name="RegProtocols" Content="Register Protocols" DockPanel.Dock="Bottom"
               HorizontalAlignment="Left" Click="RegisterProtocols" />
+      <Button Name="UnProtocols" Content="Unregister Protocols" DockPanel.Dock="Bottom"
+              HorizontalAlignment="Left" Click="UnregisterProtocols" />
 
       <StackPanel Orientation="Vertical">
         <Button Content="Account Settings" Margin="4" Command="{Binding OpenAccountSettings}" HorizontalAlignment="Left" />
diff --git a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
index 2bcbe5dff..613fb20bf 100644
--- a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
@@ -47,16 +47,11 @@ private async void OpenHubSettings(object? sender, RoutedEventArgs args)
 
     private async void RegisterProtocols(object? _1, RoutedEventArgs _2)
     {
-        if (ProtocolSetup.CheckExisting())
-        {
-            Log.Information("We already have the protocols registered.");
-            ProtocolSetup.UnregisterProtocol();
-        }
-        else
-        {
-            Log.Information("We don't have the protocols registered.");
-            ProtocolSetup.RegisterProtocol();
-        }
+        ProtocolSetup.RegisterProtocol();
+    }
 
+    private async void UnregisterProtocols(object? _1, RoutedEventArgs _2)
+    {
+        ProtocolSetup.UnregisterProtocol();
     }
 }

From 101732651ec2698656384b6ba875b2b043617c66 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Wed, 14 Feb 2024 18:46:50 +0100
Subject: [PATCH 08/39] I give up on macos, im just gonna send over whatever i
 had

---
 SS14.Launcher/ProtocolSetup.cs | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index 5e474caed..ad3a69521 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -19,7 +19,7 @@ public static bool CheckExisting()
 
         if (OperatingSystem.IsMacOS())
         {
-            // todo do this
+            // todo macos check existing protocol setup
             // I got no idea how to do this, lsregister does not report anything.
             // Lets just assume theres no record
         }
@@ -30,8 +30,8 @@ public static bool CheckExisting()
             // this will assume you have downloaded the zip launcher
             // todo how do i get data to see the output of this
             var proc = new Process();
-            proc.StartInfo.FileName = "sh";
-            proc.StartInfo.Arguments = "xdg-mime default x-scheme-handler/ss14;xdg-mime default x-scheme-handler/ss14";
+            proc.StartInfo.FileName = "xdg-mime";
+            proc.StartInfo.Arguments = "default x-scheme-handler/ss14;xdg-mime default x-scheme-handler/ss14";
             proc.Start();
             // https://stackoverflow.com/questions/206323/how-to-execute-command-line-in-c-get-std-out-results
             string output = proc.StandardOutput.ReadToEnd();
@@ -64,6 +64,9 @@ public static void RegisterProtocol()
         if (OperatingSystem.IsMacOS())
         {
             // Yeah you cant get this to work on dev builds
+            // NOTICE: I have given up on macos. More info on the pr. I cant get params to pass in cause
+            // apple is special. You are free to do it
+            //todo macos protocol pass params
             #if FULL_RELEASE
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
@@ -98,10 +101,12 @@ public static void RegisterProtocol()
         // Linux registration
         if (OperatingSystem.IsLinux())
         {
+            var desktopfile = "";
+
             // todo ditto (2)
             var proc = new Process();
             proc.StartInfo.FileName = "xdg-mime";
-            proc.StartInfo.Arguments = "xdg-mime default SS14.desktop x-scheme-handler/ss14;xdg-mime default SS14.desktop x-scheme-handler/ss14s";
+            proc.StartInfo.Arguments = $"default {desktopfile} x-scheme-handler/ss14;xdg-mime default SS14.desktop x-scheme-handler/ss14s";
             proc.Start();
         }
         Log.Information("Successfully registered protocol");
@@ -129,6 +134,8 @@ public static void UnregisterProtocol()
         // macOS unregistration
         if (OperatingSystem.IsMacOS())
         {
+            // This just... seems to do nothing. Its correct to my documentation...
+            // todo macos protocols remove logic
             #if FULL_RELEASE
             Log.Information("Unregistering protocol for macos...");
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";

From dac3514418120679bb37c7c073664d796516c49d Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Wed, 13 Mar 2024 22:01:59 +0100
Subject: [PATCH 09/39] Start of Robust Toolbox file extensions

---
 SS14.Launcher.Bootstrap/Program.cs | 45 +++++++++++++++++++++++-------
 1 file changed, 35 insertions(+), 10 deletions(-)

diff --git a/SS14.Launcher.Bootstrap/Program.cs b/SS14.Launcher.Bootstrap/Program.cs
index b1305724f..89c82c517 100644
--- a/SS14.Launcher.Bootstrap/Program.cs
+++ b/SS14.Launcher.Bootstrap/Program.cs
@@ -16,23 +16,48 @@ public static void Main(string[] args)
 
             if (args.Contains("--register-protocol"))
             {
-                var key1 = Registry.ClassesRoot.CreateSubKey("ss14s");
-                key1!.SetValue("URL Protocol", "");
-                key1 = key1.CreateSubKey("Shell\\Open\\Command");
-                key1!.SetValue("", $"\"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe\" \"%1\"");
-                key1.Close();
+                // ss14s://
+                var key = Registry.ClassesRoot.CreateSubKey("ss14s");
+                key!.SetValue("URL Protocol", "Space Station 14 Secure protocol");
+                key = key.CreateSubKey("Shell\\Open\\Command");
+                key!.SetValue("", $"\"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe\" \"%1\"");
+                key.Close();
+
+                // ss14://
+                key = Registry.ClassesRoot.CreateSubKey("ss14");
+                key!.SetValue("URL Protocol", "Space Station 14 protocol");
+                key = key.CreateSubKey("Shell\\Open\\Command");
+                key!.SetValue("", $"\"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe\" \"%1\"");
+                key.Close();
+
+                // RobustToolbox (required for the file extensions)
+                key = Registry.ClassesRoot.CreateSubKey("Robust Toolbox");
+                key!.SetValue("", "Robust Toolbox Bundle");
+                var icon = key.CreateSubKey("DefaultIcon");
+                icon!.SetValue("", $"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe");
+                key = key.CreateSubKey("Shell\\Open\\Command");
+                key!.SetValue("", $"\"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe\" \"%1\"");
+                key.Close();
+
+                // .rtbundle
+                key = Registry.ClassesRoot.CreateSubKey(".rtbundle");
+                key!.SetValue("", "Robust Toolbox");
+                key.Close();
+
+                // .rtreplay
+                key = Registry.ClassesRoot.CreateSubKey(".rtreplay");
+                key!.SetValue("", "Robust Toolbox");
+                key.Close();
 
-                var key2 = Registry.ClassesRoot.CreateSubKey("ss14");
-                key2!.SetValue("URL Protocol", "");
-                key2 = key2.CreateSubKey("Shell\\Open\\Command");
-                key2!.SetValue("", $"\"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe\" \"%1\"");
-                key2.Close();
                 Environment.Exit(0);
             }
             if (args.Contains("--unregister-protocol"))
             {
                 Registry.ClassesRoot.DeleteSubKeyTree("ss14s");
                 Registry.ClassesRoot.DeleteSubKeyTree("ss14");
+                Registry.ClassesRoot.DeleteSubKeyTree("Space Station 14");
+                Registry.ClassesRoot.DeleteSubKeyTree(".rtbundle");
+                Registry.ClassesRoot.DeleteSubKeyTree(".rtreplay");
                 Environment.Exit(0);
             }
 

From 83b38e43652b4c5b606d0e32234d2c72d162510d Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sun, 17 Mar 2024 01:22:21 +0100
Subject: [PATCH 10/39] file extensions

---
 SS14.Launcher.Bootstrap/Program.cs                | 15 ++++++++-------
 SS14.Launcher/LauncherCommands.cs                 | 12 ++++++++++++
 SS14.Launcher/Program.cs                          | 15 ++++++++++++---
 SS14.Launcher/ViewModels/MainWindowViewModel.cs   |  2 +-
 .../Views/MainWindowTabs/HomePageView.xaml.cs     |  2 +-
 5 files changed, 34 insertions(+), 12 deletions(-)

diff --git a/SS14.Launcher.Bootstrap/Program.cs b/SS14.Launcher.Bootstrap/Program.cs
index 89c82c517..640a59cc8 100644
--- a/SS14.Launcher.Bootstrap/Program.cs
+++ b/SS14.Launcher.Bootstrap/Program.cs
@@ -31,8 +31,8 @@ public static void Main(string[] args)
                 key.Close();
 
                 // RobustToolbox (required for the file extensions)
-                key = Registry.ClassesRoot.CreateSubKey("Robust Toolbox");
-                key!.SetValue("", "Robust Toolbox Bundle");
+                key = Registry.ClassesRoot.CreateSubKey("RobustToolbox");
+                key!.SetValue("", "Robust Toolbox Bundle File");
                 var icon = key.CreateSubKey("DefaultIcon");
                 icon!.SetValue("", $"{AppDomain.CurrentDomain.BaseDirectory}Space Station 14 Launcher.exe");
                 key = key.CreateSubKey("Shell\\Open\\Command");
@@ -41,12 +41,12 @@ public static void Main(string[] args)
 
                 // .rtbundle
                 key = Registry.ClassesRoot.CreateSubKey(".rtbundle");
-                key!.SetValue("", "Robust Toolbox");
+                key!.SetValue("", "RobustToolbox");
                 key.Close();
 
                 // .rtreplay
                 key = Registry.ClassesRoot.CreateSubKey(".rtreplay");
-                key!.SetValue("", "Robust Toolbox");
+                key!.SetValue("", "RobustToolbox");
                 key.Close();
 
                 Environment.Exit(0);
@@ -55,7 +55,7 @@ public static void Main(string[] args)
             {
                 Registry.ClassesRoot.DeleteSubKeyTree("ss14s");
                 Registry.ClassesRoot.DeleteSubKeyTree("ss14");
-                Registry.ClassesRoot.DeleteSubKeyTree("Space Station 14");
+                Registry.ClassesRoot.DeleteSubKeyTree("RobustToolbox");
                 Registry.ClassesRoot.DeleteSubKeyTree(".rtbundle");
                 Registry.ClassesRoot.DeleteSubKeyTree(".rtreplay");
                 Environment.Exit(0);
@@ -71,8 +71,9 @@ public static void Main(string[] args)
             Environment.SetEnvironmentVariable("DOTNET_ROOT", dotnetDir);
             if (args.Length > 0)
             {
-                var arguments = string.Join(" ", args);
-                Process.Start(new ProcessStartInfo(exeDir, arguments));
+                // blursed
+                // thanks anonymous for how to make args pass in properly
+                Process.Start(new ProcessStartInfo(exeDir, string.Join("", args.Select((str) => $"\"{str}\" "))));
             }
             else
             {
diff --git a/SS14.Launcher/LauncherCommands.cs b/SS14.Launcher/LauncherCommands.cs
index 2f7938ac5..9cad54f42 100644
--- a/SS14.Launcher/LauncherCommands.cs
+++ b/SS14.Launcher/LauncherCommands.cs
@@ -157,6 +157,17 @@ private async Task RunSingleCommand(string cmd)
             // Used by the "pass URI as argument" logic, doesn't need to bother with safety measures
             await Connect(cmd.Substring(1));
         }
+        else if (cmd.StartsWith("b"))
+        {
+            // Content bundle file
+            // Substring 9 to remove b and the file:///
+
+            // todo figure out why sometimes the file:/// is there and sometimes it isn't
+            if (cmd.StartsWith("file:///"))
+                await Task.Run(() => ConnectingViewModel.StartContentBundle(_windowVm, cmd.Substring(9)));
+            else
+                await Task.Run(() => ConnectingViewModel.StartContentBundle(_windowVm, cmd.Substring(1)));
+        }
         else
         {
             Log.Error($"Unhandled launcher command: {cmd}");
@@ -169,5 +180,6 @@ private async Task RunSingleCommand(string cmd)
     public const string RedialWaitCommand = ":RedialWait";
     public const string BlankReasonCommand = "r";
     public static string ConstructConnectCommand(Uri uri) => "c" + uri.ToString();
+    public static string ConstructContentBundleCommand(string fileName) => "b" + fileName;
 }
 
diff --git a/SS14.Launcher/Program.cs b/SS14.Launcher/Program.cs
index 2271142e6..7f04baa70 100644
--- a/SS14.Launcher/Program.cs
+++ b/SS14.Launcher/Program.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.IO;
 using System.Linq;
 using System.Net.Http.Headers;
 using System.Text;
@@ -53,13 +54,21 @@ public static void Main(string[] args)
         // Parse arguments as early as possible for launcher messaging reasons.
         string[] commands = { LauncherCommands.PingCommand };
         var commandSendAnyway = false;
+        File.WriteAllText("args.txt", string.Join(", ", args));
         if (args.Length == 1)
         {
+            // Handle files being opened with the launcher.
+            if (args.Any(arg => arg.StartsWith("file://") || arg.EndsWith(".rtbundle") || arg.EndsWith(".rtreplay")))
+            {
+                commands = [LauncherCommands.BlankReasonCommand, LauncherCommands.ConstructContentBundleCommand(args[0])
+                ];
+                commandSendAnyway = true;
+            }
+
             // Check if this is a valid Uri, since that indicates re-invocation.
-            if (Uri.TryCreate(args[0], UriKind.Absolute, out var result))
+            else if (Uri.TryCreate(args[0], UriKind.Absolute, out var result))
             {
-                commands = new string[]
-                    { LauncherCommands.BlankReasonCommand, LauncherCommands.ConstructConnectCommand(result) };
+                commands = [LauncherCommands.BlankReasonCommand, LauncherCommands.ConstructConnectCommand(result)];
                 // This ensures we queue up the connection even if we're starting the launcher now.
                 commandSendAnyway = true;
             }
diff --git a/SS14.Launcher/ViewModels/MainWindowViewModel.cs b/SS14.Launcher/ViewModels/MainWindowViewModel.cs
index da7aa58ad..151314ff4 100644
--- a/SS14.Launcher/ViewModels/MainWindowViewModel.cs
+++ b/SS14.Launcher/ViewModels/MainWindowViewModel.cs
@@ -267,7 +267,7 @@ public bool IsContentBundleDropValid(string fileName)
         if (ConnectingVM != null)
             return false;
 
-        return Path.GetExtension(fileName) == ".zip";
+        return new List<string> { ".zip", ".rtbundle", ".rtreplay" }.Contains(Path.GetExtension(fileName));
     }
 
     public void Dropped(string fileName)
diff --git a/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
index 97719b727..3ca72f6b2 100644
--- a/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
@@ -50,7 +50,7 @@ private async void OpenReplayClicked(object? sender, RoutedEventArgs e)
         {
             Filters = new List<FileDialogFilter>
             {
-                new() { Extensions = new List<string> { "zip" }, Name = "Content bundle files" }
+                new() { Extensions = new List<string> { "zip", "rtbundle", "rtreplay" }, Name = "Content bundle files" }
             },
             Title = "Open replay or content bundle"
         };

From 0c74a42db126968d6a5ab44c781a0a35ebad5b87 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sun, 17 Mar 2024 18:30:53 +0100
Subject: [PATCH 11/39] Remove debug code and finish windows

---
 SS14.Launcher/Program.cs       | 1 -
 SS14.Launcher/ProtocolSetup.cs | 4 +++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/SS14.Launcher/Program.cs b/SS14.Launcher/Program.cs
index 7f04baa70..fb4fef7fb 100644
--- a/SS14.Launcher/Program.cs
+++ b/SS14.Launcher/Program.cs
@@ -54,7 +54,6 @@ public static void Main(string[] args)
         // Parse arguments as early as possible for launcher messaging reasons.
         string[] commands = { LauncherCommands.PingCommand };
         var commandSendAnyway = false;
-        File.WriteAllText("args.txt", string.Join(", ", args));
         if (args.Length == 1)
         {
             // Handle files being opened with the launcher.
diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index ad3a69521..8b28bee39 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -14,7 +14,9 @@ public static bool CheckExisting()
         {
             using var key1 = Registry.ClassesRoot.OpenSubKey("ss14s", false);
             using var key2 = Registry.ClassesRoot.OpenSubKey("ss14", false);
-            result = key1 != null && key2 != null;
+            using var key3 = Registry.ClassesRoot.OpenSubKey("RobustToolbox", false);
+            // no need to check the extension keys, they point to RobustToolbox
+            result = key1 != null && key2 != null && key3 != null;
         }
 
         if (OperatingSystem.IsMacOS())

From b74cfec41e4814ef207a520258f4635f43d67b38 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sun, 17 Mar 2024 19:02:53 +0100
Subject: [PATCH 12/39] Shitty bug fix for when you drop a content bundle that
 has a space in it crashing the client

---
 SS14.Launcher/Views/MainWindow.xaml.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SS14.Launcher/Views/MainWindow.xaml.cs b/SS14.Launcher/Views/MainWindow.xaml.cs
index 2c05e6292..2ec16f7ef 100644
--- a/SS14.Launcher/Views/MainWindow.xaml.cs
+++ b/SS14.Launcher/Views/MainWindow.xaml.cs
@@ -117,6 +117,6 @@ private bool IsDragDropValid(IDataObject dataObject)
         if (!dataObject.Contains(DataFormats.Files))
             return null;
 
-        return dataObject.GetFiles()?.SingleOrDefault()?.Path.AbsolutePath;
+        return dataObject.GetFiles()?.SingleOrDefault()?.Path.AbsolutePath.Replace("%20", " ");
     }
 }

From f9d3f4f64dd7e95bb9d99d5f34bb5ae70bd8565a Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Fri, 5 Apr 2024 21:48:24 +0200
Subject: [PATCH 13/39] ok but like maybe

---
 .../Contents/Info.plist                       | 66 +++++++++++--------
 SS14.Launcher.Bootstrap/Program.cs            |  2 -
 SS14.Launcher/Program.cs                      |  6 ++
 3 files changed, 45 insertions(+), 29 deletions(-)

diff --git a/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist b/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist
index 92ac8a038..eb0a3cbc1 100644
--- a/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist	
+++ b/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist	
@@ -1,34 +1,46 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-    <key>CFBundleName</key>
-    <string>SS14L</string>
-    <key>CFBundleDisplayName</key>
-    <string>Space Station 14 Launcher</string>
-    <key>CFBundleExecutable</key>
-    <string>SS14</string>
-    <!--
-    Just a note about this icon.
-    MacOS seems REALLY iffy about this and even when the file is correct,
-    it can take forever before it decides to actually update it and display it.
-    TL;DR Apple is stupid.
-    -->
-    <key>CFBundleIconFile</key>
-    <string>ss14</string>
+	<key>CFBundleName</key>
+	<string>SS14L</string>
+	<key>CFBundleDisplayName</key>
+	<string>Space Station 14 Launcher</string>
+	<key>CFBundleExecutable</key>
+	<string>SS14</string>
+	<key>CFBundleIconFile</key>
+	<string>ss14</string>
 	<key>CFBundleIdentifier</key>
 	<string>com.spacestation14.launcher</string>
-    <key>CFBundleURLTypes</key>
-    <array>
-        <dict>
-            <key>CFBundleURLName</key>
-            <string>com.spacestation14.launcher</string>
-            <key>CFBundleURLSchemes</key>
-            <array>
-                <string>ss14</string>
-                <string>ss14s</string>
-            </array>
-        </dict>
-    </array>
+	<key>CFBundleURLTypes</key>
+	<array>
+		<dict>
+			<key>CFBundleURLName</key>
+			<string>com.spacestation14.launcher</string>
+			<key>CFBundleURLSchemes</key>
+			<array>
+				<string>ss14</string>
+				<string>ss14s</string>
+			</array>
+		</dict>
+	</array>
+	<key>CFBundleDocumentTypes</key>
+	<array>
+		<dict>
+			<key>CFBundleTypeExtensions</key>
+			<array>
+				<string>rtreplay</string>
+				<string>rtbundle</string>
+			</array>
+			<key>CFBundleTypeIconFile</key>
+			<string>ss14.icns</string>
+			<key>LSHandlerRank</key>
+			<string>Owner</string>
+			<key>CFBundleTypeName</key>
+			<string>Robust Toolbox Bundle File</string>
+			<key>CFBundleTypeRole</key>
+			<string>Viewer</string>
+		</dict>
+	</array>
 </dict>
 </plist>
diff --git a/SS14.Launcher.Bootstrap/Program.cs b/SS14.Launcher.Bootstrap/Program.cs
index 640a59cc8..22c254993 100644
--- a/SS14.Launcher.Bootstrap/Program.cs
+++ b/SS14.Launcher.Bootstrap/Program.cs
@@ -3,8 +3,6 @@
 using System.IO;
 using Microsoft.Win32;
 using System.Linq;
-using System.Security;
-using System.Security.Principal;
 
 namespace SS14.Launcher.Bootstrap
 {
diff --git a/SS14.Launcher/Program.cs b/SS14.Launcher/Program.cs
index fb4fef7fb..935fb9c8b 100644
--- a/SS14.Launcher/Program.cs
+++ b/SS14.Launcher/Program.cs
@@ -41,6 +41,7 @@ internal static class Program
     [STAThread]
     public static void Main(string[] args)
     {
+        UrlOpenedEventArgs? urlArgs = null;
 #if DEBUG
         Console.OutputEncoding = Encoding.UTF8;
 #endif
@@ -51,6 +52,11 @@ public static void Main(string[] args)
         var msgr = new LauncherMessaging();
         Locator.CurrentMutable.RegisterConstant(msgr);
 
+        if (urlArgs != null)
+        {
+            args = urlArgs.Urls.ToArray();
+        }
+
         // Parse arguments as early as possible for launcher messaging reasons.
         string[] commands = { LauncherCommands.PingCommand };
         var commandSendAnyway = false;

From d380786f8260022e927ac8f6cb460d0bd2835286 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Wed, 10 Apr 2024 19:56:01 +0200
Subject: [PATCH 14/39] Ok no maybe

---
 SS14.Launcher/Program.cs | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/SS14.Launcher/Program.cs b/SS14.Launcher/Program.cs
index 935fb9c8b..fb4fef7fb 100644
--- a/SS14.Launcher/Program.cs
+++ b/SS14.Launcher/Program.cs
@@ -41,7 +41,6 @@ internal static class Program
     [STAThread]
     public static void Main(string[] args)
     {
-        UrlOpenedEventArgs? urlArgs = null;
 #if DEBUG
         Console.OutputEncoding = Encoding.UTF8;
 #endif
@@ -52,11 +51,6 @@ public static void Main(string[] args)
         var msgr = new LauncherMessaging();
         Locator.CurrentMutable.RegisterConstant(msgr);
 
-        if (urlArgs != null)
-        {
-            args = urlArgs.Urls.ToArray();
-        }
-
         // Parse arguments as early as possible for launcher messaging reasons.
         string[] commands = { LauncherCommands.PingCommand };
         var commandSendAnyway = false;

From 934044f1a447436d5241184257f3ce50775983b1 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Thu, 11 Apr 2024 00:27:27 +0200
Subject: [PATCH 15/39] Send this to my macbook please work

---
 .../Contents/Info.plist                       | 26 ++++++++++++-------
 SS14.Launcher/App.xaml.cs                     |  7 +++++
 2 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist b/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist
index eb0a3cbc1..71480e9eb 100644
--- a/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist	
+++ b/PublishFiles/Space Station 14 Launcher.app/Contents/Info.plist	
@@ -1,15 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>CFBundleName</key>
-	<string>SS14L</string>
-	<key>CFBundleDisplayName</key>
-	<string>Space Station 14 Launcher</string>
-	<key>CFBundleExecutable</key>
-	<string>SS14</string>
-	<key>CFBundleIconFile</key>
-	<string>ss14</string>
+    <key>CFBundleName</key>
+    <string>SS14L</string>
+    <key>CFBundleDisplayName</key>
+    <string>Space Station 14 Launcher</string>
+    <key>CFBundleExecutable</key>
+    <string>SS14</string>
+    <!--
+    Just a note about this icon.
+    MacOS seems REALLY iffy about this and even when the file is correct,
+    it can take forever before it decides to actually update it and display it.
+    TL;DR Apple is stupid.
+    -->
+    <key>CFBundleIconFile</key>
+    <string>ss14</string>
 	<key>CFBundleIdentifier</key>
 	<string>com.spacestation14.launcher</string>
 	<key>CFBundleURLTypes</key>
@@ -33,7 +39,7 @@
 				<string>rtbundle</string>
 			</array>
 			<key>CFBundleTypeIconFile</key>
-			<string>ss14.icns</string>
+			<string>ss14</string>
 			<key>LSHandlerRank</key>
 			<string>Owner</string>
 			<key>CFBundleTypeName</key>
diff --git a/SS14.Launcher/App.xaml.cs b/SS14.Launcher/App.xaml.cs
index b3fc5db75..c66973449 100644
--- a/SS14.Launcher/App.xaml.cs
+++ b/SS14.Launcher/App.xaml.cs
@@ -34,6 +34,13 @@ public App()
     public App(OverrideAssetsManager overrideAssets)
     {
         _overrideAssets = overrideAssets;
+
+        UrlsOpened += OnOSXUrlsOpened;
+    }
+
+    private void OnOSXUrlsOpened(object? sender, UrlOpenedEventArgs e)
+    {
+        Log.Debug("Url opened: {Url}", e.Urls);
     }
 
     public override void Initialize()

From 5102306b26fade72c405d0a5d5427d34053065e0 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Mon, 6 May 2024 22:20:08 +0200
Subject: [PATCH 16/39] a

---
 SS14.Launcher/Views/MainWindow.xaml.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SS14.Launcher/Views/MainWindow.xaml.cs b/SS14.Launcher/Views/MainWindow.xaml.cs
index 2ec16f7ef..6d189bfbb 100644
--- a/SS14.Launcher/Views/MainWindow.xaml.cs
+++ b/SS14.Launcher/Views/MainWindow.xaml.cs
@@ -117,6 +117,6 @@ private bool IsDragDropValid(IDataObject dataObject)
         if (!dataObject.Contains(DataFormats.Files))
             return null;
 
-        return dataObject.GetFiles()?.SingleOrDefault()?.Path.AbsolutePath.Replace("%20", " ");
+        return dataObject.GetFiles()?.SingleOrDefault()?.Path.LocalPath;
     }
 }

From e4059dde4f24cc2c936cf6256cd0f16045d40d5d Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Sat, 20 Jul 2024 18:07:56 +0300
Subject: [PATCH 17/39] A

---
 SS14.Launcher/App.xaml.cs      |  6 +++++-
 SS14.Launcher/ProtocolSetup.cs | 13 ++++++-------
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/SS14.Launcher/App.xaml.cs b/SS14.Launcher/App.xaml.cs
index c66973449..a7a8654c6 100644
--- a/SS14.Launcher/App.xaml.cs
+++ b/SS14.Launcher/App.xaml.cs
@@ -40,7 +40,11 @@ public App(OverrideAssetsManager overrideAssets)
 
     private void OnOSXUrlsOpened(object? sender, UrlOpenedEventArgs e)
     {
-        Log.Debug("Url opened: {Url}", e.Urls);
+        // I think this only works on macOS anyway? Well i will leave this here just so I don't surprise myself later.
+        if (!OperatingSystem.IsMacOS())
+            return;
+
+        Log.Debug($"MacOS launch arg is {e.Urls}. Doing nothing since i did not implement this yet lol");
     }
 
     public override void Initialize()
diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index 8b28bee39..27a260169 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -66,10 +66,10 @@ public static void RegisterProtocol()
         if (OperatingSystem.IsMacOS())
         {
             // Yeah you cant get this to work on dev builds
-            // NOTICE: I have given up on macos. More info on the pr. I cant get params to pass in cause
-            // apple is special. You are free to do it
             //todo macos protocol pass params
-            #if FULL_RELEASE
+            #if !FULL_RELEASE
+            return;
+            #endif
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
             // > be me
@@ -98,7 +98,6 @@ public static void RegisterProtocol()
             proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
             proc.StartInfo.Arguments = $"-f {newPath}";
             proc.Start();
-            #endif
         }
         // Linux registration
         if (OperatingSystem.IsLinux())
@@ -137,8 +136,9 @@ public static void UnregisterProtocol()
         if (OperatingSystem.IsMacOS())
         {
             // This just... seems to do nothing. Its correct to my documentation...
-            // todo macos protocols remove logic
-            #if FULL_RELEASE
+            #if !FULL_RELEASE
+            return;
+            #endif
             Log.Information("Unregistering protocol for macos...");
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
@@ -153,7 +153,6 @@ public static void UnregisterProtocol()
             proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
             proc.StartInfo.Arguments = $"-u {newPath}";
             proc.Start();
-            #endif
         }
         // Linux unregistration
         if (OperatingSystem.IsLinux())

From fd427b2d361daae062360fc5781acf500304b7f8 Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Sat, 20 Jul 2024 18:34:04 +0300
Subject: [PATCH 18/39] Why apple

---
 SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
index 44590ada5..2202d1326 100644
--- a/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
@@ -56,7 +56,9 @@ private async void OpenReplayClicked(object? sender, RoutedEventArgs e)
                 {
                     Patterns = ["*.zip", "*.rtbundle", "*.rtreplay"],
                     MimeTypes = ["application/zip", "x-scheme-handler/ss14", "x-scheme-handler/ss14s"],
-                    AppleUniformTypeIdentifiers = ["zip"]
+                    // Retrived using "mdls -name kMDItemContentType file.zip/rtreplay/rtbundle"
+                    // No I'm not tripping... THIS is apparently how macOS identifies our file extension.
+                    AppleUniformTypeIdentifiers = ["public.zip-archive", "dyn.ah62d4rv4ge81e7dwqz2g22p3", "dyn.ah62d4rv4ge81e7dcsz1gk5df"]
                 }
             ]
         });

From 10865dda7de2d229d6a3d68a17e4f3a63758b88c Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Mon, 22 Jul 2024 15:44:30 +0300
Subject: [PATCH 19/39] 123 im gonna squash this anyway later

---
 SS14.Launcher/LauncherCommands.cs                       | 1 +
 SS14.Launcher/ViewModels/MainWindowViewModel.cs         | 2 +-
 SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/SS14.Launcher/LauncherCommands.cs b/SS14.Launcher/LauncherCommands.cs
index 9cad54f42..36d7a5edf 100644
--- a/SS14.Launcher/LauncherCommands.cs
+++ b/SS14.Launcher/LauncherCommands.cs
@@ -163,6 +163,7 @@ private async Task RunSingleCommand(string cmd)
             // Substring 9 to remove b and the file:///
 
             // todo figure out why sometimes the file:/// is there and sometimes it isn't
+            // 2025: Do i need the substring now that we do istoragefile
             if (cmd.StartsWith("file:///"))
                 await Task.Run(() => ConnectingViewModel.StartContentBundle(_windowVm, cmd.Substring(9)));
             else
diff --git a/SS14.Launcher/ViewModels/MainWindowViewModel.cs b/SS14.Launcher/ViewModels/MainWindowViewModel.cs
index 7573a4600..edd6d5d70 100644
--- a/SS14.Launcher/ViewModels/MainWindowViewModel.cs
+++ b/SS14.Launcher/ViewModels/MainWindowViewModel.cs
@@ -269,7 +269,7 @@ public bool IsContentBundleDropValid(IStorageFile file)
         if (ConnectingVM != null)
             return false;
 
-        return new List<string> { ".zip", ".rtbundle", ".rtreplay" }.Contains(Path.GetExtension(fileName));
+        return new List<string> { ".zip", ".rtbundle", ".rtreplay" }.Contains(Path.GetExtension(file.Name));
     }
 
     public void Dropped(IStorageFile file)
diff --git a/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
index 2202d1326..e597dcf51 100644
--- a/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
@@ -57,7 +57,7 @@ private async void OpenReplayClicked(object? sender, RoutedEventArgs e)
                     Patterns = ["*.zip", "*.rtbundle", "*.rtreplay"],
                     MimeTypes = ["application/zip", "x-scheme-handler/ss14", "x-scheme-handler/ss14s"],
                     // Retrived using "mdls -name kMDItemContentType file.zip/rtreplay/rtbundle"
-                    // No I'm not tripping... THIS is apparently how macOS identifies our file extension.
+                    // No I'm not tripping... THIS is apparently how macOS identifies our file extension. Check Avalonia docs.
                     AppleUniformTypeIdentifiers = ["public.zip-archive", "dyn.ah62d4rv4ge81e7dwqz2g22p3", "dyn.ah62d4rv4ge81e7dcsz1gk5df"]
                 }
             ]

From e135cbae9f7eccdf4a8ccb4bcf4d73498528cfd2 Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Fri, 26 Jul 2024 03:09:29 +0300
Subject: [PATCH 20/39] Fix conflict

Niko is a cat
---
 SS14.Launcher/LauncherCommands.cs | 17 +++++++++--------
 SS14.Launcher/Program.cs          |  6 +++---
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/SS14.Launcher/LauncherCommands.cs b/SS14.Launcher/LauncherCommands.cs
index 36d7a5edf..7900f8461 100644
--- a/SS14.Launcher/LauncherCommands.cs
+++ b/SS14.Launcher/LauncherCommands.cs
@@ -2,6 +2,7 @@
 using System.Text;
 using System.Threading.Channels;
 using System.Threading.Tasks;
+using Avalonia.Platform.Storage;
 using Avalonia.Threading;
 using Serilog;
 using Splat;
@@ -18,13 +19,15 @@ public class LauncherCommands
     private MainWindowViewModel _windowVm;
     private LoginManager _loginMgr;
     private LauncherMessaging _msgr;
+    private readonly IStorageProvider _storageProvider;
     public readonly Channel<string> CommandChannel;
 
-    public LauncherCommands(MainWindowViewModel windowVm)
+    public LauncherCommands(MainWindowViewModel windowVm, IStorageProvider provider)
     {
         _windowVm = windowVm;
         _loginMgr = Locator.Current.GetRequiredService<LoginManager>();
         _msgr = Locator.Current.GetRequiredService<LauncherMessaging>();
+        _storageProvider = provider;
 
         CommandChannel = Channel.CreateUnbounded<string>();
     }
@@ -160,14 +163,12 @@ private async Task RunSingleCommand(string cmd)
         else if (cmd.StartsWith("b"))
         {
             // Content bundle file
-            // Substring 9 to remove b and the file:///
-
-            // todo figure out why sometimes the file:/// is there and sometimes it isn't
-            // 2025: Do i need the substring now that we do istoragefile
-            if (cmd.StartsWith("file:///"))
-                await Task.Run(() => ConnectingViewModel.StartContentBundle(_windowVm, cmd.Substring(9)));
+            var uri = new Uri(cmd.Substring(1));
+            var thingy = await _storageProvider.TryGetFileFromPathAsync(uri);
+            if (thingy != null)
+                await Task.Run(() => ConnectingViewModel.StartContentBundle(_windowVm, thingy));
             else
-                await Task.Run(() => ConnectingViewModel.StartContentBundle(_windowVm, cmd.Substring(1)));
+                Log.Error("File does not exist. Aborting");
         }
         else
         {
diff --git a/SS14.Launcher/Program.cs b/SS14.Launcher/Program.cs
index 07863bd48..860a7c3f8 100644
--- a/SS14.Launcher/Program.cs
+++ b/SS14.Launcher/Program.cs
@@ -149,7 +149,7 @@ public static void Main(string[] args)
         _serverTask?.Wait();
     }
 
-    private static unsafe void CheckWindowsVersion()
+    private static void CheckWindowsVersion()
     {
         // 14393 is Windows 10 version 1607, minimum we currently support.
         if (!OperatingSystem.IsWindows() || Environment.OSVersion.Version.Build >= 14393)
@@ -174,7 +174,7 @@ private static unsafe void CheckWindowsVersion()
         Helpers.MessageBoxHelper(text, caption, type);
     }
 
-    private static unsafe void CheckBadAntivirus()
+    private static void CheckBadAntivirus()
     {
         // Avast Free Antivirus breaks the game due to their AMSI integration crashing the process. Awesome!
         // Oh hey back here again, turns out AVG is just the same product as Avast with different paint.
@@ -298,7 +298,7 @@ private static void AppMain(Application app, string[] args)
             GC.Collect();
         };
 
-        var lc = new LauncherCommands(viewModel);
+        var lc = new LauncherCommands(viewModel, window.StorageProvider);
         lc.RunCommandTask();
         Locator.CurrentMutable.RegisterConstant(lc);
         _serverTask = msgr.ServerTask(lc);

From 0682c240728f816b29bf2292350296c5e4d5b256 Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Fri, 26 Jul 2024 23:58:44 +0300
Subject: [PATCH 21/39] Fix macos kinda

---
 SS14.Launcher/App.xaml.cs      | 5 +++--
 SS14.Launcher/ProtocolSetup.cs | 9 +--------
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/SS14.Launcher/App.xaml.cs b/SS14.Launcher/App.xaml.cs
index a7a8654c6..3cd5885c5 100644
--- a/SS14.Launcher/App.xaml.cs
+++ b/SS14.Launcher/App.xaml.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Markup.Xaml;
@@ -38,13 +39,13 @@ public App(OverrideAssetsManager overrideAssets)
         UrlsOpened += OnOSXUrlsOpened;
     }
 
-    private void OnOSXUrlsOpened(object? sender, UrlOpenedEventArgs e)
+    public void OnOSXUrlsOpened(object? sender, UrlOpenedEventArgs e)
     {
         // I think this only works on macOS anyway? Well i will leave this here just so I don't surprise myself later.
         if (!OperatingSystem.IsMacOS())
             return;
 
-        Log.Debug($"MacOS launch arg is {e.Urls}. Doing nothing since i did not implement this yet lol");
+        Log.Debug($"MacOS launch arg is {e.Urls.FirstOrDefault()}. Doing nothing since i did not implement this yet lol");
     }
 
     public override void Initialize()
diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index 27a260169..b43bee8ae 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -66,20 +66,13 @@ public static void RegisterProtocol()
         if (OperatingSystem.IsMacOS())
         {
             // Yeah you cant get this to work on dev builds
-            //todo macos protocol pass params
             #if !FULL_RELEASE
             return;
             #endif
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
-            // > be me
-            // > write protocol registration code
-            // > application runs in some wierd sandbox folder
-            // > :despair:
-            // > find out its about that its cause the user needs to move the app to the applications folder...
-            // > ... or any "suitable" folder...
             // tldr user needs to move the app manually to get this sandbox restriction lifted. This can be done by
-            // making one of those installer dmg stuff
+            // making one of those installer dmg stuff... for now lets just stop
             if (path.Contains("AppTranslocation"))
             {
                 Log.Error("I have been put in apple jail... move me to your application folder");

From e2d1eac657909153873183e6a97e60b541d91f23 Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Sat, 27 Jul 2024 18:24:34 +0300
Subject: [PATCH 22/39] MACOS IS DONE BOZOS FUCK YOU APPLE

---
 SS14.Launcher/App.xaml.cs |  2 +-
 SS14.Launcher/Program.cs  | 87 +++++++++++++++++++++------------------
 2 files changed, 47 insertions(+), 42 deletions(-)

diff --git a/SS14.Launcher/App.xaml.cs b/SS14.Launcher/App.xaml.cs
index 3cd5885c5..cd8f7bda1 100644
--- a/SS14.Launcher/App.xaml.cs
+++ b/SS14.Launcher/App.xaml.cs
@@ -45,7 +45,7 @@ public void OnOSXUrlsOpened(object? sender, UrlOpenedEventArgs e)
         if (!OperatingSystem.IsMacOS())
             return;
 
-        Log.Debug($"MacOS launch arg is {e.Urls.FirstOrDefault()}. Doing nothing since i did not implement this yet lol");
+        Program.ParseCommandLineArgs(e.Urls, new LauncherMessaging());
     }
 
     public override void Initialize()
diff --git a/SS14.Launcher/Program.cs b/SS14.Launcher/Program.cs
index 860a7c3f8..bfaf4de6d 100644
--- a/SS14.Launcher/Program.cs
+++ b/SS14.Launcher/Program.cs
@@ -52,47 +52,7 @@ public static void Main(string[] args)
         var msgr = new LauncherMessaging();
         Locator.CurrentMutable.RegisterConstant(msgr);
 
-        // Parse arguments as early as possible for launcher messaging reasons.
-        string[] commands = { LauncherCommands.PingCommand };
-        var commandSendAnyway = false;
-        if (args.Length == 1)
-        {
-            // Handle files being opened with the launcher.
-            if (args.Any(arg => arg.StartsWith("file://") || arg.EndsWith(".rtbundle") || arg.EndsWith(".rtreplay")))
-            {
-                commands = [LauncherCommands.BlankReasonCommand, LauncherCommands.ConstructContentBundleCommand(args[0])
-                ];
-                commandSendAnyway = true;
-            }
-
-            // Check if this is a valid Uri, since that indicates re-invocation.
-            else if (Uri.TryCreate(args[0], UriKind.Absolute, out var result))
-            {
-                commands = [LauncherCommands.BlankReasonCommand, LauncherCommands.ConstructConnectCommand(result)];
-                // This ensures we queue up the connection even if we're starting the launcher now.
-                commandSendAnyway = true;
-            }
-        }
-        else if (args.Length >= 2)
-        {
-            if (args[0] == "--commands")
-            {
-                // Trying to send an arbitrary series of commands.
-                // This is how the Loader is expected to communicate (and start the launcher if necessary).
-                // Note that there are special "untrusted text" versions of the commands that should be used.
-                commands = new string[args.Length - 1];
-                for (var i = 0; i < commands.Length; i++)
-                    commands[i] = args[i + 1];
-                commandSendAnyway = true;
-            }
-        }
-
-        // Note: This MUST occur before we do certain actions like:
-        // + Open the launcher log file (and therefore wipe a user's existing launcher log)
-        // + Initialize Avalonia (and therefore waste whatever time it takes to do that)
-        // Therefore any messages you receive at this point will be Console.WriteLine-only!
-        if (msgr.SendCommandsOrClaim(commands, commandSendAnyway))
-            return;
+        ParseCommandLineArgs(args, msgr);
 
         var logCfg = new LoggerConfiguration()
             .MinimumLevel.Debug()
@@ -149,6 +109,51 @@ public static void Main(string[] args)
         _serverTask?.Wait();
     }
 
+    public static void ParseCommandLineArgs(string[] args, LauncherMessaging msgr)
+    {
+        // Parse arguments as early as possible for launcher messaging reasons.
+        string[] commands = { LauncherCommands.PingCommand };
+        var commandSendAnyway = false;
+        if (args.Length == 1)
+        {
+            // Handle files being opened with the launcher.
+            if (args.Any(arg => arg.StartsWith("file://") || arg.EndsWith(".rtbundle") || arg.EndsWith(".rtreplay")))
+            {
+                commands = [LauncherCommands.BlankReasonCommand, LauncherCommands.ConstructContentBundleCommand(args[0])
+                ];
+                commandSendAnyway = true;
+            }
+
+            // Check if this is a valid Uri, since that indicates re-invocation.
+            else if (Uri.TryCreate(args[0], UriKind.Absolute, out var result))
+            {
+                commands = [LauncherCommands.BlankReasonCommand, LauncherCommands.ConstructConnectCommand(result)];
+                // This ensures we queue up the connection even if we're starting the launcher now.
+                commandSendAnyway = true;
+            }
+        }
+        else if (args.Length >= 2)
+        {
+            if (args[0] == "--commands")
+            {
+                // Trying to send an arbitrary series of commands.
+                // This is how the Loader is expected to communicate (and start the launcher if necessary).
+                // Note that there are special "untrusted text" versions of the commands that should be used.
+                commands = new string[args.Length - 1];
+                for (var i = 0; i < commands.Length; i++)
+                    commands[i] = args[i + 1];
+                commandSendAnyway = true;
+            }
+        }
+
+        // Note: This MUST occur before we do certain actions like:
+        // + Open the launcher log file (and therefore wipe a user's existing launcher log)
+        // + Initialize Avalonia (and therefore waste whatever time it takes to do that)
+        // Therefore any messages you receive at this point will be Console.WriteLine-only!
+        if (msgr.SendCommandsOrClaim(commands, commandSendAnyway))
+            return;
+    }
+
     private static void CheckWindowsVersion()
     {
         // 14393 is Windows 10 version 1607, minimum we currently support.

From 1535cd1e4ed764e30306fb2c438ddaae51f0d8a8 Mon Sep 17 00:00:00 2001
From: Vasilis <vasilis@pikachu.systems>
Date: Sat, 27 Jul 2024 23:12:36 +0300
Subject: [PATCH 23/39] MacOS improvements (unregistration is fully correct
 idk)

---
 SS14.Launcher/ProtocolSetup.cs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/ProtocolSetup.cs
index b43bee8ae..943bcbf72 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/ProtocolSetup.cs
@@ -88,8 +88,8 @@ public static void RegisterProtocol()
 
             var proc = new Process();
             // Yes you have to manually go to this
-            proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
-            proc.StartInfo.Arguments = $"-f {newPath}";
+            proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister";
+            proc.StartInfo.Arguments = $"-R -f {newPath}";
             proc.Start();
         }
         // Linux registration
@@ -143,8 +143,8 @@ public static void UnregisterProtocol()
             }
 
             var proc = new Process();
-            proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Frameworks/LaunchServices.framework/Support/lsregister";
-            proc.StartInfo.Arguments = $"-u {newPath}";
+            proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister";
+            proc.StartInfo.Arguments = $"-R -f -u {newPath}";
             proc.Start();
         }
         // Linux unregistration

From b5bd6c2281a495674d6ab250bce7076e0b26dccb Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 8 Feb 2025 23:36:08 +0100
Subject: [PATCH 24/39] I am back

- User facing manual button
- Linux support start
---
 PublishFiles/SS14.desktop                     |  6 ++--
 PublishFiles/ss14-mime-type.xml               | 15 +++++++++
 SS14.Launcher/Assets/Locale/en-US/text.ftl    |  5 +++
 .../{ProtocolSetup.cs => Protocol.cs}         | 31 +++++++++----------
 .../MainWindowTabs/OptionsTabViewModel.cs     | 19 ++----------
 .../MainWindowTabs/DevelopmentTabView.xaml    |  5 +++
 .../MainWindowTabs/DevelopmentTabView.xaml.cs | 10 ++++++
 .../Views/MainWindowTabs/OptionsTabView.xaml  | 11 +++----
 .../MainWindowTabs/OptionsTabView.xaml.cs     | 16 +++++-----
 publish_linux.sh                              |  2 +-
 10 files changed, 71 insertions(+), 49 deletions(-)
 create mode 100644 PublishFiles/ss14-mime-type.xml
 rename SS14.Launcher/{ProtocolSetup.cs => Protocol.cs} (87%)

diff --git a/PublishFiles/SS14.desktop b/PublishFiles/SS14.desktop
index 5f6ffefd0..bc08a29d5 100755
--- a/PublishFiles/SS14.desktop
+++ b/PublishFiles/SS14.desktop
@@ -5,5 +5,7 @@ Version=1.0
 Type=Application
 Exec=env ./SS14.Launcher %u
 Name=Space Station 14
-MimeType=x-scheme-handler/ss14s;
-MimeType=x-scheme-handler/ss14;
+Comment=Open source Multiplayer Disaster Simulator
+Categories=Game;
+Keywords=ss14;
+MimeType=x-scheme-handler/ss14s;x-scheme-handler/ss14;application/rtbundle;application/rtreplay;
diff --git a/PublishFiles/ss14-mime-type.xml b/PublishFiles/ss14-mime-type.xml
new file mode 100644
index 000000000..d20186b3c
--- /dev/null
+++ b/PublishFiles/ss14-mime-type.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<mime-info xmlns="http://www.freedesktop.org/standards/shared-mime-info">
+    <mime-type type="application/rtbundle">
+        <comment>Robust Toolbox Game Bundle</comment>
+        <glob pattern="*.rtbundle"/>
+    </mime-type>
+    <mime-type type="application/rtreplay">
+        <comment>Robust Toolbox Replay</comment>
+        <glob pattern="*.rtreplay"/>
+    </mime-type>
+</mime-info>
+    <!--
+    mkdir -p ~/.local/share/mime && cp ./ss14-mime.type.xml ~/.local/share/mime && update-mime-database ~/.local/share/mime
+    cp ~/.local/share/applications/SS14.desktop && update-desktop-database ~/.local/share/applications
+    -->
diff --git a/SS14.Launcher/Assets/Locale/en-US/text.ftl b/SS14.Launcher/Assets/Locale/en-US/text.ftl
index 6c433f057..e221c9d35 100644
--- a/SS14.Launcher/Assets/Locale/en-US/text.ftl
+++ b/SS14.Launcher/Assets/Locale/en-US/text.ftl
@@ -291,6 +291,8 @@ tab-development-disable-signing = Disable Engine Signature Checks
 tab-development-disable-signing-desc = { "[" }DEV ONLY] Disables verification of engine signatures. DO NOT ENABLE UNLESS YOU KNOW EXACTLY WHAT YOU'RE DOING.
 tab-development-enable-engine-override = Enable engine override
 tab-development-enable-engine-override-desc = Override path to load engine zips from (release/ in RobustToolbox)
+tab-development-force-register-os-protocols = Force Register OS Protocols
+tab-development-force-unregister-os-protocols = Force Unegister OS Protocols
 
 ## Strings for the "home" tab
 
@@ -332,6 +334,9 @@ tab-options-disable-signing = Disable Engine Signature Checks
 tab-options-disable-signing-desc = { "[" }DEV ONLY] Disables verification of engine signatures. DO NOT ENABLE UNLESS YOU KNOW EXACTLY WHAT YOU'RE DOING.
 tab-options-hub-settings = Hub Settings
 tab-options-hub-settings-desc = Change what hub server or servers you would like to use to fetch the server list.
+tab-options-os-protocol = Register/Unregister File extensions & URL protocol
+tab-options-os-protocol-desc = Register the launcher to your operating system, this will allow you to use ss14(s):// links and file extensions like .rtreplay.
+
 tab-options-desc-incompatible = This option is incompatible with your platform and has been disabled.
 
 ## For the language selection menu.
diff --git a/SS14.Launcher/ProtocolSetup.cs b/SS14.Launcher/Protocol.cs
similarity index 87%
rename from SS14.Launcher/ProtocolSetup.cs
rename to SS14.Launcher/Protocol.cs
index 27a260169..95aaff80f 100644
--- a/SS14.Launcher/ProtocolSetup.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -1,11 +1,12 @@
 using System;
 using System.Diagnostics;
+using System.Threading.Tasks;
 using Microsoft.Win32;
 using Serilog;
 
 namespace SS14.Launcher;
 
-public static class ProtocolSetup
+public static class Protocol
 {
     public static bool CheckExisting()
     {
@@ -42,7 +43,7 @@ public static bool CheckExisting()
 
         return result;
     }
-    public static void RegisterProtocol()
+    public static Task<bool> RegisterProtocol()
     {
         // Windows registration
         if (OperatingSystem.IsWindows())
@@ -60,30 +61,23 @@ public static void RegisterProtocol()
             {
                 // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
                 Log.Warning("User declined UAC or doesn't have admin rights.");
+                return Task.FromResult(false);
             }
         }
         // macOS registration
         if (OperatingSystem.IsMacOS())
         {
             // Yeah you cant get this to work on dev builds
-            //todo macos protocol pass params
             #if !FULL_RELEASE
-            return;
+            return Task.FromResult(false);
             #endif
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
-            // > be me
-            // > write protocol registration code
-            // > application runs in some wierd sandbox folder
-            // > :despair:
-            // > find out its about that its cause the user needs to move the app to the applications folder...
-            // > ... or any "suitable" folder...
-            // tldr user needs to move the app manually to get this sandbox restriction lifted. This can be done by
-            // making one of those installer dmg stuff
+            // User needs to move the app manually to get this sandbox restriction lifted. This can be done "automated" by making one of those installer dmg stuff
             if (path.Contains("AppTranslocation"))
             {
-                Log.Error("I have been put in apple jail... move me to your application folder");
-                return;
+                Log.Error("I have been put in apple jail (Gatekeeper path randomisation)... move me to your application folder");
+                return Task.FromResult(false);
             }
 
             var newPath = string.Empty;
@@ -110,9 +104,11 @@ public static void RegisterProtocol()
             proc.StartInfo.Arguments = $"default {desktopfile} x-scheme-handler/ss14;xdg-mime default SS14.desktop x-scheme-handler/ss14s";
             proc.Start();
         }
+
         Log.Information("Successfully registered protocol");
+        return Task.FromResult(true);
     }
-    public static void UnregisterProtocol()
+    public static Task<bool> UnregisterProtocol()
     {
         // Windows unregistration
         if (OperatingSystem.IsWindows())
@@ -130,6 +126,7 @@ public static void UnregisterProtocol()
             {
                 // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
                 Log.Warning("User declined UAC or doesn't have admin rights.");
+                return Task.FromResult(false);
             }
         }
         // macOS unregistration
@@ -137,7 +134,7 @@ public static void UnregisterProtocol()
         {
             // This just... seems to do nothing. Its correct to my documentation...
             #if !FULL_RELEASE
-            return;
+            return Task.FromResult(false);
             #endif
             Log.Information("Unregistering protocol for macos...");
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
@@ -160,5 +157,7 @@ public static void UnregisterProtocol()
             // todo ditto (2)
         }
         Log.Information("Successfully unregistered protocol");
+
+        return Task.FromResult(true);
     }
 }
diff --git a/SS14.Launcher/ViewModels/MainWindowTabs/OptionsTabViewModel.cs b/SS14.Launcher/ViewModels/MainWindowTabs/OptionsTabViewModel.cs
index 2dec1f94c..435a2795f 100644
--- a/SS14.Launcher/ViewModels/MainWindowTabs/OptionsTabViewModel.cs
+++ b/SS14.Launcher/ViewModels/MainWindowTabs/OptionsTabViewModel.cs
@@ -1,5 +1,7 @@
 using System;
+using System.ComponentModel;
 using System.Diagnostics;
+using System.Threading.Tasks;
 using Splat;
 using SS14.Launcher.Localization;
 using SS14.Launcher.Models.ContentManagement;
@@ -26,12 +28,7 @@ public OptionsTabViewModel()
         DisableIncompatibleMacOS = OperatingSystem.IsMacOS();
     }
     public bool DisableIncompatibleMacOS { get; }
-
-#if RELEASE
-        public bool HideDisableSigning => true;
-#else
-    public bool HideDisableSigning => false;
-#endif
+    public bool OsProtocolBool;
 
     public override string Name => LocalizationManager.Instance.GetString("tab-options-title");
 
@@ -75,16 +72,6 @@ public bool LogLauncherVerbose
         }
     }
 
-    public bool DisableSigning
-    {
-        get => Cfg.GetCVar(CVars.DisableSigning);
-        set
-        {
-            Cfg.SetCVar(CVars.DisableSigning, value);
-            Cfg.CommitConfig();
-        }
-    }
-
     public bool OverrideAssets
     {
         get => Cfg.GetCVar(CVars.OverrideAssets);
diff --git a/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml b/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml
index 5427ece34..cb4bb07ad 100644
--- a/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml
+++ b/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml
@@ -25,5 +25,10 @@
     <TextBlock VerticalAlignment="Center" TextWrapping="Wrap"
                Text="{loc:Loc tab-development-enable-engine-override-desc}"
                Margin="8" />
+
+    <Button Name="RegProtocols" Content="{loc:Loc tab-development-force-register-os-protocols}" DockPanel.Dock="Bottom"
+            HorizontalAlignment="Left" Click="RegisterProtocols" />
+    <Button Name="UnProtocols" Content="{loc:Loc tab-development-force-unregister-os-protocols}" DockPanel.Dock="Bottom"
+            HorizontalAlignment="Left" Click="UnregisterProtocols" />
   </StackPanel>
 </UserControl>
diff --git a/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml.cs
index f45d15dff..6db19d358 100644
--- a/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml.cs
@@ -1,4 +1,5 @@
 using Avalonia.Controls;
+using Avalonia.Interactivity;
 
 namespace SS14.Launcher.Views.MainWindowTabs;
 
@@ -9,4 +10,13 @@ public DevelopmentTabView()
         InitializeComponent();
     }
 
+    private void RegisterProtocols(object? _1, RoutedEventArgs _2)
+    {
+        Protocol.RegisterProtocol();
+    }
+
+    private void UnregisterProtocols(object? _1, RoutedEventArgs _2)
+    {
+        Protocol.UnregisterProtocol();
+    }
 }
diff --git a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
index 8c047e5e2..1c094ae41 100644
--- a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
+++ b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml
@@ -21,10 +21,6 @@
               HorizontalAlignment="Left" Click="ClearServerContentPressed" />
       <Button Content="{loc:Loc tab-options-open-log-directory}" DockPanel.Dock="Bottom" HorizontalAlignment="Left"
               Command="{Binding OpenLogDirectory}"/>
-      <Button Name="RegProtocols" Content="Register Protocols" DockPanel.Dock="Bottom"
-              HorizontalAlignment="Left" Click="RegisterProtocols" />
-      <Button Name="UnProtocols" Content="Unregister Protocols" DockPanel.Dock="Bottom"
-              HorizontalAlignment="Left" Click="UnregisterProtocols" />
 
       <StackPanel Orientation="Vertical">
         <views:LanguageSelector HorizontalAlignment="Left" Margin="4" DataContext="{Binding Language}"
@@ -65,9 +61,10 @@
                    Text="{loc:Loc tab-options-seasonal-branding-desc}"
                    Margin="8" />
 
-        <CheckBox VerticalAlignment="Center" IsVisible="{Binding !HideDisableSigning}" Margin="4" IsChecked="{Binding DisableSigning}" Content="{loc:Loc tab-options-disable-signing}" />
-        <TextBlock VerticalAlignment="Center" IsVisible="{Binding !HideDisableSigning}" TextWrapping="Wrap"
-                   Text="{loc:Loc tab-options-disable-signing-desc}"
+
+        <Button Click="OSProtocol" Content="{loc:Loc tab-options-os-protocol}" Margin="4" HorizontalAlignment="Left" />
+        <TextBlock VerticalAlignment="Center" TextWrapping="Wrap"
+                   Text="{loc:Loc tab-options-os-protocol-desc}"
                    Margin="8" />
 
         <Button Click="OpenHubSettings" Content="{loc:Loc tab-options-hub-settings}" Margin="4" HorizontalAlignment="Left" />
diff --git a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
index de52b8415..a2373e0bb 100644
--- a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
@@ -45,13 +45,15 @@ private async void OpenHubSettings(object? sender, RoutedEventArgs args)
         await new HubSettingsDialog().ShowDialog((Window)this.GetVisualRoot()!);
     }
 
-    private async void RegisterProtocols(object? _1, RoutedEventArgs _2)
+    public async void OSProtocol(object? sender, RoutedEventArgs args)
     {
-        ProtocolSetup.RegisterProtocol();
-    }
-
-    private async void UnregisterProtocols(object? _1, RoutedEventArgs _2)
-    {
-        ProtocolSetup.UnregisterProtocol();
+        if (Protocol.CheckExisting())
+        {
+            await Protocol.UnregisterProtocol();
+        }
+        else
+        {
+            await Protocol.RegisterProtocol();
+        }
     }
 }
diff --git a/publish_linux.sh b/publish_linux.sh
index b26934f63..f797cb2a8 100755
--- a/publish_linux.sh
+++ b/publish_linux.sh
@@ -16,7 +16,7 @@ mkdir -p bin/publish/Linux/bin
 mkdir -p bin/publish/Linux/bin/loader
 mkdir -p bin/publish/Linux/dotnet
 
-cp PublishFiles/SS14.Launcher PublishFiles/SS14.desktop bin/publish/Linux/
+cp PublishFiles/SS14.Launcher PublishFiles/SS14.desktop PublishFiles/ss14-mime-type.xml bin/publish/Linux/
 cp SS14.Launcher/bin/Release/net9.0/linux-x64/publish/* bin/publish/Linux/bin/
 cp SS14.Loader/bin/Release/net9.0/linux-x64/publish/* bin/publish/Linux/bin/loader
 cp -r Dependencies/dotnet/linux/* bin/publish/Linux/dotnet/

From 9533fbc41ab13e723e211fa64e3f125e39bee4d9 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Tue, 4 Mar 2025 17:34:35 +0100
Subject: [PATCH 25/39] Forgor

---
 SS14.Launcher/App.xaml.cs          | 4 +---
 SS14.Launcher/LauncherMessaging.cs | 2 +-
 SS14.Launcher/Program.cs           | 1 -
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/SS14.Launcher/App.xaml.cs b/SS14.Launcher/App.xaml.cs
index 59a0e9be5..b5a78f3d9 100644
--- a/SS14.Launcher/App.xaml.cs
+++ b/SS14.Launcher/App.xaml.cs
@@ -1,8 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
-using System.Threading.Tasks;
 using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Controls.ApplicationLifetimes;
@@ -160,7 +158,7 @@ private void OnStartup(object? s, ControlledApplicationLifetimeStartupEventArgs
             GC.Collect();
         };
 
-        var lc = new LauncherCommands(viewModel);
+        var lc = new LauncherCommands(viewModel, window.StorageProvider);
         lc.RunCommandTask();
         Locator.CurrentMutable.RegisterConstant(lc);
         msgr.StartServerTask(lc);
diff --git a/SS14.Launcher/LauncherMessaging.cs b/SS14.Launcher/LauncherMessaging.cs
index 8b355aace..046aaeaf7 100644
--- a/SS14.Launcher/LauncherMessaging.cs
+++ b/SS14.Launcher/LauncherMessaging.cs
@@ -81,7 +81,7 @@ public bool SendCommandsOrClaim(string[] commands, bool sendAnyway = true)
         catch (Exception)
         {
             // Ok, so we're server (we hope)
-            Console.WriteLine("We are primary launcher (or primary launcher is out for lunch)");
+            Console.WriteLine("We are the primary launcher (or primary launcher is out for lunch)");
         }
 
         // Try to create server
diff --git a/SS14.Launcher/Program.cs b/SS14.Launcher/Program.cs
index f44e26af6..c1dadd1e5 100644
--- a/SS14.Launcher/Program.cs
+++ b/SS14.Launcher/Program.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.IO;
 using System.Linq;
 using System.Net.Http.Headers;
 using System.Text;

From c45841e4b123f658f724d51761e015bc7e4a34fc Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Tue, 4 Mar 2025 18:28:02 +0100
Subject: [PATCH 26/39] Replace obsolete UrlsOpened with IActivatableLifetime

---
 SS14.Launcher/App.xaml.cs | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/SS14.Launcher/App.xaml.cs b/SS14.Launcher/App.xaml.cs
index b5a78f3d9..3e199fb8e 100644
--- a/SS14.Launcher/App.xaml.cs
+++ b/SS14.Launcher/App.xaml.cs
@@ -43,16 +43,23 @@ public App(OverrideAssetsManager overrideAssets)
     {
         _overrideAssets = overrideAssets;
 
-        UrlsOpened += OnOSXUrlsOpened;
+        if (Current?.TryGetFeature<IActivatableLifetime>(out var lifetime) == true)
+        {
+            lifetime.Activated += OnOSXUrlsOpened;
+        }
     }
 
-    public void OnOSXUrlsOpened(object? sender, UrlOpenedEventArgs e)
+    private void OnOSXUrlsOpened(object? sender, ActivatedEventArgs e)
     {
-        // I think this only works on macOS anyway? Well i will leave this here just so I don't surprise myself later.
+        // I think this only works on macOS anyway? Well I will leave this here just so I don't surprise myself later.
         if (!OperatingSystem.IsMacOS())
             return;
 
-        Program.ParseCommandLineArgs(e.Urls, new LauncherMessaging());
+        var args = Environment.GetCommandLineArgs();
+        if (args.Length > 1)
+        {
+            Program.ParseCommandLineArgs(args[1..], new LauncherMessaging());
+        }
     }
 
     public override void Initialize()

From e7ec6c497ad051156e92b818544892b92c82a552 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Tue, 4 Mar 2025 22:49:35 +0100
Subject: [PATCH 27/39] Confirm dialog

Co-authored-by: Julian Giebel <juliangiebel@live.de>
---
 SS14.Launcher/Models/Data/CVars.cs            |  5 ++
 SS14.Launcher/Protocol.cs                     | 83 ++++++++++++++++++-
 .../ViewModels/MainWindowViewModel.cs         |  7 ++
 SS14.Launcher/Views/ConfirmDialog.xaml        | 22 +++++
 SS14.Launcher/Views/ConfirmDialog.xaml.cs     | 51 ++++++++++++
 SS14.Launcher/Views/MainWindow.xaml.cs        |  8 +-
 6 files changed, 173 insertions(+), 3 deletions(-)
 create mode 100644 SS14.Launcher/Views/ConfirmDialog.xaml
 create mode 100644 SS14.Launcher/Views/ConfirmDialog.xaml.cs

diff --git a/SS14.Launcher/Models/Data/CVars.cs b/SS14.Launcher/Models/Data/CVars.cs
index 331889b74..b39ccc266 100644
--- a/SS14.Launcher/Models/Data/CVars.cs
+++ b/SS14.Launcher/Models/Data/CVars.cs
@@ -110,6 +110,11 @@ public static readonly CVarDef<bool> HasDismissedEarlyAccessWarning
     /// </summary>
     public static readonly CVarDef<bool> WineWarningShown = CVarDef.Create("WineWarningShown", false);
 
+    /// <summary>
+    /// Has the user been shown the protocols alert?
+    /// </summary>
+    public static readonly CVarDef<bool> HasSeenProtocolsDialog = CVarDef.Create("HasSeenProtocolsDialog", false);
+
     /// <summary>
     /// Language the user selected. Null means it should be automatically selected based on system language.
     /// </summary>
diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index 8d3e724c3..e3dd5c8a6 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -3,11 +3,16 @@
 using System.Threading.Tasks;
 using Microsoft.Win32;
 using Serilog;
+using SS14.Launcher.Localization;
+using SS14.Launcher.Models.Data;
+using SS14.Launcher.Views;
 
 namespace SS14.Launcher;
 
-public static class Protocol
+public abstract class Protocol
 {
+    private readonly DataManager _cfg;
+
     public static bool CheckExisting()
     {
         var result = false;
@@ -160,4 +165,80 @@ public static Task<bool> UnregisterProtocol()
 
         return Task.FromResult(true);
     }
+
+    // UI popup stuff
+    public static async Task ProtocolPopup(MainWindow control, DataManager cfg)
+    {
+        if (!IsCandidateForProtocols(cfg))
+            return;
+
+        var dialog = new ConfirmDialog
+        {
+            Title = LocalizationManager.Instance.GetString("protocols-dialog-title"),
+            DialogContent = LocalizationManager.Instance.GetString("protocols-dialog-content"),
+            ConfirmButtonText = LocalizationManager.Instance.GetString("protocols-dialog-confirm"),
+            CancelButtonText = LocalizationManager.Instance.GetString("protocols-dialog-deny"),
+        };
+
+        var result = await dialog.ShowDialog<bool>(control);
+
+        if (result)
+        {
+            await RegisterProtocol();
+        }
+
+        // Myra got annoyed at the popup being disabled while she was developing it.
+        #if FULL_RELEASE
+        _cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
+        #endif
+    }
+
+    private static async Task ErrorPopup(MainWindow control)
+    {
+        string dialogContent;
+
+        dialogContent = LocalizationManager.Instance.GetString(OperatingSystem.IsWindows() ? "protocols-dialog-error-windows" : "protocols-dialog-error-generic");
+
+        var dialog = new ConfirmDialog
+        {
+            Title = LocalizationManager.Instance.GetString("protocols-dialog-error-title"),
+            DialogContent = dialogContent,
+            ConfirmButtonText = LocalizationManager.Instance.GetString("protocols-dialog-error-again"),
+            CancelButtonText = LocalizationManager.Instance.GetString("protocols-dialog-deny"),
+        };
+
+        var result = await dialog.ShowDialog<bool>(control);
+
+        if (result)
+        {
+            await RegisterProtocol();
+        }
+    }
+
+    private static bool IsCandidateForProtocols(DataManager cfg)
+    {
+        // They have been shown this dialog before, don't bother.
+        if (cfg.GetCVar(CVars.HasSeenProtocolsDialog))
+            return false;
+
+        // It already exists. Either cause of a reset config file or already installed by steam.
+        // Let's also set the cvar.
+        // todo remove
+#if FULL_RELEASE
+        if (CheckExisting())
+        {
+            cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
+
+
+            return false;
+        }
+#endif
+
+        // Check if the OS is compatible... im sorry freebsd users
+        if (!OperatingSystem.IsWindows() && !OperatingSystem.IsMacOS() && !OperatingSystem.IsLinux())
+            return false;
+
+        // We (hopefully) are ready!
+        return true;
+    }
 }
diff --git a/SS14.Launcher/ViewModels/MainWindowViewModel.cs b/SS14.Launcher/ViewModels/MainWindowViewModel.cs
index 110c5f67d..40fd1ca67 100644
--- a/SS14.Launcher/ViewModels/MainWindowViewModel.cs
+++ b/SS14.Launcher/ViewModels/MainWindowViewModel.cs
@@ -280,4 +280,11 @@ public void Dropped(IStorageFile file)
 
         ConnectingViewModel.StartContentBundle(this, file);
     }
+
+    public async Task OnWindowLoaded()
+    {
+    #if !DEBUG
+        await Protocol.ProtocolPopup(Control!, _cfg);
+    #endif
+    }
 }
diff --git a/SS14.Launcher/Views/ConfirmDialog.xaml b/SS14.Launcher/Views/ConfirmDialog.xaml
new file mode 100644
index 000000000..3485603b8
--- /dev/null
+++ b/SS14.Launcher/Views/ConfirmDialog.xaml
@@ -0,0 +1,22 @@
+<Window xmlns="https://github.com/avaloniaui"
+        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
+        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+        mc:Ignorable="d" d:DesignWidth="300" d:DesignHeight="100"
+        MinWidth="350" MinHeight="100"
+        Width="570" Height="160"
+        x:Class="SS14.Launcher.Views.ConfirmDialog"
+        Icon="{DynamicResource WindowIcon}"
+        Title="Confirm"
+        WindowStartupLocation="CenterOwner">
+
+  <DockPanel Margin="8">
+    <TextBlock Name="Content"  HorizontalAlignment="Left" DockPanel.Dock="Top"
+               Text="Are you sure?" />
+
+    <StackPanel Orientation="Horizontal" FlowDirection="RightToLeft"  HorizontalAlignment="Stretch" VerticalAlignment="Bottom" DockPanel.Dock="Bottom" Height="42">
+      <Button HorizontalAlignment="Right" VerticalAlignment="Bottom" Margin="4 0" Name="ConfirmButton" Content="Confirm" />
+      <Button HorizontalAlignment="Right" VerticalAlignment="Bottom" Margin="4 0" Name="CancelButton" Content="Cancel" />
+    </StackPanel>
+  </DockPanel>
+</Window>
diff --git a/SS14.Launcher/Views/ConfirmDialog.xaml.cs b/SS14.Launcher/Views/ConfirmDialog.xaml.cs
new file mode 100644
index 000000000..9813e070f
--- /dev/null
+++ b/SS14.Launcher/Views/ConfirmDialog.xaml.cs
@@ -0,0 +1,51 @@
+using System;
+using System.Reactive.Linq;
+using Avalonia.Controls;
+using Avalonia.Input;
+using ReactiveUI;
+
+namespace SS14.Launcher.Views;
+
+public partial class ConfirmDialog : Window
+{
+    public string? DialogContent
+    {
+        get => Content.Text;
+        set => Content.Text = value;
+    }
+
+    public string? ConfirmButtonText
+    {
+        get => ConfirmButton.Content as string;
+        set => ConfirmButton.Content = value;
+    }
+
+    public string? CancelButtonText
+    {
+        get => CancelButton.Content as string;
+        set => CancelButton.Content = value;
+    }
+
+    public ConfirmDialog()
+    {
+        InitializeComponent();
+
+        ConfirmButton.Command = ReactiveCommand.Create(() => Close(true));
+        CancelButton.Command = ReactiveCommand.Create(() => Close(false));
+    }
+
+    protected override void OnKeyDown(KeyEventArgs e)
+    {
+        if (e.Key == Key.Escape)
+        {
+            Close(false);
+        }
+
+        base.OnKeyDown(e);
+    }
+
+    internal static bool IsAddressValid(string address)
+    {
+        return !string.IsNullOrWhiteSpace(address) && UriHelper.TryParseSs14Uri(address, out _);
+    }
+}
diff --git a/SS14.Launcher/Views/MainWindow.xaml.cs b/SS14.Launcher/Views/MainWindow.xaml.cs
index 93a373893..534449cd0 100644
--- a/SS14.Launcher/Views/MainWindow.xaml.cs
+++ b/SS14.Launcher/Views/MainWindow.xaml.cs
@@ -27,10 +27,14 @@ public MainWindow()
         AddHandler(DragDrop.DragLeaveEvent, DragLeave);
         AddHandler(DragDrop.DragOverEvent, DragOver);
         AddHandler(DragDrop.DropEvent, Drop);
+        AddHandler(LoadedEvent, Load);
+    }
+    private async void Load(object? sender, RoutedEventArgs e)
+    {
+        ReloadTitle();
 
+        await _viewModel!.OnWindowLoaded();
         _content = (MainWindowContent) Content!;
-
-        ReloadTitle();
     }
 
     public void ReloadContent()

From 352040acde5a7b15640f223a5c2e18073fe660f2 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Tue, 4 Mar 2025 22:51:41 +0100
Subject: [PATCH 28/39] Add zip mimetype for linux

Not all servers will go to .rtreplay so may as well let the OS know. PLUS it will probably magic indentify them in case I messed up the custom file extension for linux.
---
 PublishFiles/SS14.desktop | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PublishFiles/SS14.desktop b/PublishFiles/SS14.desktop
index bc08a29d5..95d749061 100755
--- a/PublishFiles/SS14.desktop
+++ b/PublishFiles/SS14.desktop
@@ -8,4 +8,4 @@ Name=Space Station 14
 Comment=Open source Multiplayer Disaster Simulator
 Categories=Game;
 Keywords=ss14;
-MimeType=x-scheme-handler/ss14s;x-scheme-handler/ss14;application/rtbundle;application/rtreplay;
+MimeType=x-scheme-handler/ss14s;x-scheme-handler/ss14;application/rtbundle;application/rtreplay;application/zip

From 64ff1ef776f41572b768123614c4dc32550b5346 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Tue, 4 Mar 2025 22:52:07 +0100
Subject: [PATCH 29/39] Protocol text

---
 SS14.Launcher/Assets/Locale/en-US/text.ftl | 32 +++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/SS14.Launcher/Assets/Locale/en-US/text.ftl b/SS14.Launcher/Assets/Locale/en-US/text.ftl
index 8ed17fc70..c90004771 100644
--- a/SS14.Launcher/Assets/Locale/en-US/text.ftl
+++ b/SS14.Launcher/Assets/Locale/en-US/text.ftl
@@ -341,7 +341,7 @@ tab-options-disable-signing-desc = { "[" }DEV ONLY] Disables verification of eng
 tab-options-hub-settings = Hub Settings
 tab-options-hub-settings-desc = Change what hub server or servers you would like to use to fetch the server list.
 tab-options-os-protocol = Register/Unregister File extensions & URL protocol
-tab-options-os-protocol-desc = Register the launcher to your operating system, this will allow you to use ss14(s):// links and file extensions like .rtreplay.
+tab-options-os-protocol-desc = Register the launcher to your operating system, this will allow you to use ss14(s):// links on web browsers and file extensions like .rtreplay.
 
 tab-options-desc-incompatible = This option is incompatible with your platform and has been disabled.
 
@@ -357,3 +357,33 @@ language-selector-help-translate = Want to help translate? You can!
 language-selector-system-language = System language ({ $languageName })
 # Used for contents of each language button.
 language-selector-language = { $languageName } ({ $englishName })
+
+# Strings for the dialog box for protocol registration
+protocols-dialog-title = OS protocol registration
+protocols-dialog-content =
+    Would you like to allow the launcher to be able to open special links and files?
+
+    This will allow you to launch replay files by just double clicking them on your
+    computer, or allow you to join a server directly from your web browser.
+
+    You can disable this feature later on in options.
+protocols-dialog-confirm = For sure!
+protocols-dialog-deny = No Thanks
+protocols-dialog-error-title = OS protocol error
+protocols-dialog-error-windows =
+    It appears we were unable to register the launcher to Windows
+    Do you have administrator rights to this computer? Or deny the admin prompt?
+
+    Want to try again?
+protocols-dialog-error-macos-translocation =
+
+protocols-dialog-error-generic =
+    It appears we were unable to register the launcher to your operating system
+
+        Want to try again?
+protocols-dialog-error-os-not-supported =
+    We do not support automatic protocol setup for your operating system.
+    Currently only Windows, MacOS and Linux are supported
+
+    If you know how to set it up, we suggest making a pull request adding your operating system!
+protocols-dialog-error-again = Try again

From 88731ca88fa264e7d41647007c83c6c7c893a0d5 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 8 Mar 2025 22:34:57 +0100
Subject: [PATCH 30/39] Popup and error handling

---
 SS14.Launcher/Assets/Locale/en-US/text.ftl    |  23 ++--
 SS14.Launcher/Helpers.cs                      |  29 +++++
 SS14.Launcher/Protocol.cs                     | 122 +++++++++---------
 .../ViewModels/MainWindowViewModel.cs         |   2 +-
 SS14.Launcher/Views/ConfirmDialog.xaml.cs     |   9 +-
 .../MainWindowTabs/OptionsTabView.xaml.cs     |  15 ++-
 SS14.Launcher/Views/OkDialog.xaml             |  21 +++
 SS14.Launcher/Views/OkDialog.xaml.cs          |  37 ++++++
 8 files changed, 174 insertions(+), 84 deletions(-)
 create mode 100644 SS14.Launcher/Views/OkDialog.xaml
 create mode 100644 SS14.Launcher/Views/OkDialog.xaml.cs

diff --git a/SS14.Launcher/Assets/Locale/en-US/text.ftl b/SS14.Launcher/Assets/Locale/en-US/text.ftl
index c90004771..156ceeeaa 100644
--- a/SS14.Launcher/Assets/Locale/en-US/text.ftl
+++ b/SS14.Launcher/Assets/Locale/en-US/text.ftl
@@ -370,20 +370,27 @@ protocols-dialog-content =
 protocols-dialog-confirm = For sure!
 protocols-dialog-deny = No Thanks
 protocols-dialog-error-title = OS protocol error
-protocols-dialog-error-windows =
+protocols-dialog-error-windows-uac =
     It appears we were unable to register the launcher to Windows
     Do you have administrator rights to this computer? Or deny the admin prompt?
 
     Want to try again?
 protocols-dialog-error-macos-translocation =
-
+    It appears we were unable to register the launcher to MacOS
+
+    MacOS Gatekeeper sandboxing is currently active on the launcher, please move
+    the Space Station 14 Launcher into your Applications folder.
+protocols-dialog-error-linux-desktop-file-not-found =
+    It appears we were unable to register the launcher to Linux
+protocols-dialog-error-linux-xdg-mime =
+    It appears we were unable to register the launcher to Linux
 protocols-dialog-error-generic =
     It appears we were unable to register the launcher to your operating system
+    Either something went really wrong, or your OS is not supported
+    (Currently supported: Windows 10/11, MacOS, Linux)
+    If this continues, please contact our Discord, Github or forum to report
+    this Bug.
 
-        Want to try again?
-protocols-dialog-error-os-not-supported =
-    We do not support automatic protocol setup for your operating system.
-    Currently only Windows, MacOS and Linux are supported
-
-    If you know how to set it up, we suggest making a pull request adding your operating system!
+    Want to try again?
 protocols-dialog-error-again = Try again
+protocols-dialog-error-ok = Ok
diff --git a/SS14.Launcher/Helpers.cs b/SS14.Launcher/Helpers.cs
index e61ca229c..15cf835c2 100644
--- a/SS14.Launcher/Helpers.cs
+++ b/SS14.Launcher/Helpers.cs
@@ -9,6 +9,8 @@
 using System.Threading.Tasks;
 using Mono.Unix;
 using Serilog;
+using SS14.Launcher.Localization;
+using SS14.Launcher.Views;
 using TerraFX.Interop.Windows;
 using Win = TerraFX.Interop.Windows.Windows;
 
@@ -202,4 +204,31 @@ public static unsafe int MessageBoxHelper(string text, string caption, uint type
             return Win.MessageBoxW(HWND.NULL, (ushort*)pText, (ushort*)pCaption, type);
         }
     }
+
+    public static async Task<bool> ConfirmDialogBuilder(MainWindow control, string title, string dialogContent, string confirmButtonText, string cancelButtonText)
+    {
+        var dialog = new ConfirmDialog
+        {
+            Title = LocalizationManager.Instance.GetString(title),
+            DialogContent = LocalizationManager.Instance.GetString(dialogContent),
+            ConfirmButtonText = LocalizationManager.Instance.GetString(confirmButtonText),
+            CancelButtonText = LocalizationManager.Instance.GetString(cancelButtonText),
+        };
+
+        var answer = await dialog.ShowDialog<bool>(control);
+
+        return answer;
+    }
+
+    public static async Task OkDialogBuilder(MainWindow control, string title, string DialogContent, string ConfirmButtonText)
+    {
+        var dialog = new OkDialog()
+        {
+            Title = LocalizationManager.Instance.GetString(title),
+            DialogContent = LocalizationManager.Instance.GetString(DialogContent),
+            ButtonText = LocalizationManager.Instance.GetString(ConfirmButtonText),
+        };
+
+        await dialog.ShowDialog<bool>(control);
+    }
 }
diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index e3dd5c8a6..416611200 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -3,7 +3,6 @@
 using System.Threading.Tasks;
 using Microsoft.Win32;
 using Serilog;
-using SS14.Launcher.Localization;
 using SS14.Launcher.Models.Data;
 using SS14.Launcher.Views;
 
@@ -11,8 +10,6 @@ namespace SS14.Launcher;
 
 public abstract class Protocol
 {
-    private readonly DataManager _cfg;
-
     public static bool CheckExisting()
     {
         var result = false;
@@ -42,13 +39,13 @@ public static bool CheckExisting()
             proc.StartInfo.Arguments = "default x-scheme-handler/ss14;xdg-mime default x-scheme-handler/ss14";
             proc.Start();
             // https://stackoverflow.com/questions/206323/how-to-execute-command-line-in-c-get-std-out-results
-            string output = proc.StandardOutput.ReadToEnd();
+            var output = proc.StandardOutput.ReadToEnd();
             proc.WaitForExit();
         }
 
         return result;
     }
-    public static Task<bool> RegisterProtocol()
+    public static async Task<ProtocolsResultCode> RegisterProtocol()
     {
         // Windows registration
         if (OperatingSystem.IsWindows())
@@ -66,23 +63,19 @@ public static Task<bool> RegisterProtocol()
             {
                 // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
                 Log.Warning("User declined UAC or doesn't have admin rights.");
-                return Task.FromResult(false);
+                return ProtocolsResultCode.ErrorWindowsUac;
             }
         }
         // macOS registration
         if (OperatingSystem.IsMacOS())
         {
-            // Yeah you cant get this to work on dev builds
-            #if !FULL_RELEASE
-            return Task.FromResult(false);
-            #endif
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
             // User needs to move the app manually to get this sandbox restriction lifted. This can be done "automated" by making one of those installer dmg stuff
             if (path.Contains("AppTranslocation"))
             {
                 Log.Error("I have been put in apple jail (Gatekeeper path randomisation)... move me to your application folder");
-                return Task.FromResult(false);
+                return ProtocolsResultCode.ErrorMacOSTranslocation;
             }
 
             var newPath = string.Empty;
@@ -111,9 +104,9 @@ public static Task<bool> RegisterProtocol()
         }
 
         Log.Information("Successfully registered protocol");
-        return Task.FromResult(true);
+        return ProtocolsResultCode.Success;
     }
-    public static Task<bool> UnregisterProtocol()
+    public static async Task<ProtocolsResultCode> UnregisterProtocol()
     {
         // Windows unregistration
         if (OperatingSystem.IsWindows())
@@ -131,17 +124,13 @@ public static Task<bool> UnregisterProtocol()
             {
                 // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
                 Log.Warning("User declined UAC or doesn't have admin rights.");
-                return Task.FromResult(false);
+                return ProtocolsResultCode.ErrorWindowsUac;
             }
         }
         // macOS unregistration
         if (OperatingSystem.IsMacOS())
         {
             // This just... seems to do nothing. Its correct to my documentation...
-            #if !FULL_RELEASE
-            return Task.FromResult(false);
-            #endif
-            Log.Information("Unregistering protocol for macos...");
             var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
             var newPath = string.Empty;
@@ -161,58 +150,61 @@ public static Task<bool> UnregisterProtocol()
         {
             // todo ditto (2)
         }
-        Log.Information("Successfully unregistered protocol");
 
-        return Task.FromResult(true);
+        Log.Information("Successfully unregistered protocol");
+        return ProtocolsResultCode.Success;
     }
 
     // UI popup stuff
-    public static async Task ProtocolPopup(MainWindow control, DataManager cfg)
+    public static async Task ProtocolSignupPopup(MainWindow control, DataManager cfg)
     {
-        if (!IsCandidateForProtocols(cfg))
+        if (IsCandidateForProtocols(cfg))
             return;
 
-        var dialog = new ConfirmDialog
-        {
-            Title = LocalizationManager.Instance.GetString("protocols-dialog-title"),
-            DialogContent = LocalizationManager.Instance.GetString("protocols-dialog-content"),
-            ConfirmButtonText = LocalizationManager.Instance.GetString("protocols-dialog-confirm"),
-            CancelButtonText = LocalizationManager.Instance.GetString("protocols-dialog-deny"),
-        };
-
-        var result = await dialog.ShowDialog<bool>(control);
-
-        if (result)
-        {
-            await RegisterProtocol();
-        }
-
-        // Myra got annoyed at the popup being disabled while she was developing it.
-        #if FULL_RELEASE
-        _cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
-        #endif
-    }
-
-    private static async Task ErrorPopup(MainWindow control)
-    {
-        string dialogContent;
-
-        dialogContent = LocalizationManager.Instance.GetString(OperatingSystem.IsWindows() ? "protocols-dialog-error-windows" : "protocols-dialog-error-generic");
+        var answer = await Helpers.ConfirmDialogBuilder(control,
+            "protocols-dialog-title",
+            "protocols-dialog-content",
+            "protocols-dialog-confirm",
+            "protocols-dialog-deny");
 
-        var dialog = new ConfirmDialog
+        if (answer)
         {
-            Title = LocalizationManager.Instance.GetString("protocols-dialog-error-title"),
-            DialogContent = dialogContent,
-            ConfirmButtonText = LocalizationManager.Instance.GetString("protocols-dialog-error-again"),
-            CancelButtonText = LocalizationManager.Instance.GetString("protocols-dialog-deny"),
-        };
-
-        var result = await dialog.ShowDialog<bool>(control);
+            retryPoint:
 
-        if (result)
-        {
-            await RegisterProtocol();
+            switch (await RegisterProtocol())
+            {
+                case ProtocolsResultCode.Success:
+                    break;
+                case ProtocolsResultCode.ErrorWindowsUac:
+                    var retryUac = await Helpers.ConfirmDialogBuilder(control,
+                        "protocols-dialog-error-title",
+                        "protocols-dialog-error-windows-uac",
+                        "protocols-dialog-error-again",
+                        "protocols-dialog-deny");
+                    if (retryUac)
+                        goto retryPoint;
+                    break;
+                case ProtocolsResultCode.ErrorMacOSTranslocation:
+                    await Helpers.OkDialogBuilder(control,
+                        "protocols-dialog-error-title",
+                        "protocols-dialog-error-macos-translocation",
+                        "protocols-dialog-error-ok");
+                    break;
+                case ProtocolsResultCode.ErrorUnknown:
+                    var retryUnknown = await Helpers.ConfirmDialogBuilder(control,
+                        "protocols-dialog-error-title",
+                        "protocols-dialog-error-generic",
+                        "protocols-dialog-error-again",
+                        "protocols-dialog-deny");
+                    if (retryUnknown)
+                        goto retryPoint;
+                    break;
+                default:
+                    throw new ArgumentOutOfRangeException();
+        }
         }
+
+        cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
     }
 
     private static bool IsCandidateForProtocols(DataManager cfg)
@@ -223,16 +215,12 @@ private static bool IsCandidateForProtocols(DataManager cfg)
 
         // It already exists. Either cause of a reset config file or already installed by steam.
         // Let's also set the cvar.
-        // todo remove
-#if FULL_RELEASE
         if (CheckExisting())
         {
             cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
 
-
             return false;
         }
-#endif
 
         // Check if the OS is compatible... im sorry freebsd users
         if (!OperatingSystem.IsWindows() && !OperatingSystem.IsMacOS() && !OperatingSystem.IsLinux())
@@ -241,4 +229,12 @@ private static bool IsCandidateForProtocols(DataManager cfg)
         // We (hopefully) are ready!
         return true;
     }
+
+    public enum ProtocolsResultCode : byte
+    {
+        Success =  0,
+        ErrorWindowsUac,
+        ErrorMacOSTranslocation,
+        ErrorUnknown,
+    }
 }
diff --git a/SS14.Launcher/ViewModels/MainWindowViewModel.cs b/SS14.Launcher/ViewModels/MainWindowViewModel.cs
index 40fd1ca67..0bacc1e27 100644
--- a/SS14.Launcher/ViewModels/MainWindowViewModel.cs
+++ b/SS14.Launcher/ViewModels/MainWindowViewModel.cs
@@ -284,7 +284,7 @@ public void Dropped(IStorageFile file)
     public async Task OnWindowLoaded()
     {
     #if !DEBUG
-        await Protocol.ProtocolPopup(Control!, _cfg);
+        await Protocol.ProtocolSignupPopup(Control!, _cfg);
     #endif
     }
 }
diff --git a/SS14.Launcher/Views/ConfirmDialog.xaml.cs b/SS14.Launcher/Views/ConfirmDialog.xaml.cs
index 9813e070f..67e55990d 100644
--- a/SS14.Launcher/Views/ConfirmDialog.xaml.cs
+++ b/SS14.Launcher/Views/ConfirmDialog.xaml.cs
@@ -1,6 +1,4 @@
-using System;
-using System.Reactive.Linq;
-using Avalonia.Controls;
+using Avalonia.Controls;
 using Avalonia.Input;
 using ReactiveUI;
 
@@ -43,9 +41,4 @@ protected override void OnKeyDown(KeyEventArgs e)
 
         base.OnKeyDown(e);
     }
-
-    internal static bool IsAddressValid(string address)
-    {
-        return !string.IsNullOrWhiteSpace(address) && UriHelper.TryParseSs14Uri(address, out _);
-    }
 }
diff --git a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
index a2373e0bb..10e4b86a8 100644
--- a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
@@ -47,13 +47,20 @@ private async void OpenHubSettings(object? sender, RoutedEventArgs args)
 
     public async void OSProtocol(object? sender, RoutedEventArgs args)
     {
-        if (Protocol.CheckExisting())
+        try
         {
-            await Protocol.UnregisterProtocol();
+            if (Protocol.CheckExisting())
+            {
+                await Protocol.UnregisterProtocol();
+            }
+            else
+            {
+                await Protocol.RegisterProtocol();
+            }
         }
-        else
+        catch (Exception e)
         {
-            await Protocol.RegisterProtocol();
+            Log.Error(e, "Error while registering protocol");
         }
     }
 }
diff --git a/SS14.Launcher/Views/OkDialog.xaml b/SS14.Launcher/Views/OkDialog.xaml
new file mode 100644
index 000000000..f2dfa07f4
--- /dev/null
+++ b/SS14.Launcher/Views/OkDialog.xaml
@@ -0,0 +1,21 @@
+<Window xmlns="https://github.com/avaloniaui"
+        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
+        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+        mc:Ignorable="d" d:DesignWidth="300" d:DesignHeight="100"
+        MinWidth="350" MinHeight="100"
+        Width="570" Height="160"
+        x:Class="SS14.Launcher.Views.OkDialog"
+        Icon="{DynamicResource WindowIcon}"
+        Title="Confirm"
+        WindowStartupLocation="CenterOwner">
+
+  <DockPanel Margin="8">
+    <TextBlock Name="Content"  HorizontalAlignment="Left" DockPanel.Dock="Top"
+               Text="Are you sure?" />
+
+    <StackPanel Orientation="Horizontal" FlowDirection="RightToLeft"  HorizontalAlignment="Stretch" VerticalAlignment="Bottom" DockPanel.Dock="Bottom" Height="42">
+      <Button HorizontalAlignment="Right" VerticalAlignment="Bottom" Margin="4 0" Name="OkButton" Content="Confirm" />
+    </StackPanel>
+  </DockPanel>
+</Window>
diff --git a/SS14.Launcher/Views/OkDialog.xaml.cs b/SS14.Launcher/Views/OkDialog.xaml.cs
new file mode 100644
index 000000000..1aac2c2a5
--- /dev/null
+++ b/SS14.Launcher/Views/OkDialog.xaml.cs
@@ -0,0 +1,37 @@
+using Avalonia.Controls;
+using Avalonia.Input;
+using ReactiveUI;
+
+namespace SS14.Launcher.Views;
+
+public partial class OkDialog : Window
+{
+    public string? DialogContent
+    {
+        get => Content.Text;
+        set => Content.Text = value;
+    }
+
+    public string? ButtonText
+    {
+        get => OkButton.Content as string;
+        set => OkButton.Content = value;
+    }
+
+    public OkDialog()
+    {
+        InitializeComponent();
+
+        OkButton.Command = ReactiveCommand.Create(Close);
+    }
+
+    protected override void OnKeyDown(KeyEventArgs e)
+    {
+        if (e.Key == Key.Escape)
+        {
+            Close(false);
+        }
+
+        base.OnKeyDown(e);
+    }
+}

From 2c8d16a36c8ee07c98d7f39da5a913f4b594efb4 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 8 Mar 2025 23:18:06 +0100
Subject: [PATCH 31/39] Options popup

---
 SS14.Launcher/Assets/Locale/en-US/text.ftl    |  5 ++
 SS14.Launcher/Helpers.cs                      |  8 +-
 SS14.Launcher/Protocol.cs                     | 81 +++++++++++--------
 .../MainWindowTabs/OptionsTabView.xaml.cs     | 11 +--
 4 files changed, 61 insertions(+), 44 deletions(-)

diff --git a/SS14.Launcher/Assets/Locale/en-US/text.ftl b/SS14.Launcher/Assets/Locale/en-US/text.ftl
index 156ceeeaa..3e99c3971 100644
--- a/SS14.Launcher/Assets/Locale/en-US/text.ftl
+++ b/SS14.Launcher/Assets/Locale/en-US/text.ftl
@@ -367,8 +367,13 @@ protocols-dialog-content =
     computer, or allow you to join a server directly from your web browser.
 
     You can disable this feature later on in options.
+protocols-dialog-content-success =
+    The launcher has been successfully registered to your operating system!
+
+    You can now use ss14(s):// links on web browsers and file extensions like .rtreplay
 protocols-dialog-confirm = For sure!
 protocols-dialog-deny = No Thanks
+protocols-dialog-ok = Yay
 protocols-dialog-error-title = OS protocol error
 protocols-dialog-error-windows-uac =
     It appears we were unable to register the launcher to Windows
diff --git a/SS14.Launcher/Helpers.cs b/SS14.Launcher/Helpers.cs
index 15cf835c2..2bc7a27af 100644
--- a/SS14.Launcher/Helpers.cs
+++ b/SS14.Launcher/Helpers.cs
@@ -205,6 +205,7 @@ public static unsafe int MessageBoxHelper(string text, string caption, uint type
         }
     }
 
+    // Has two buttons, Confirm/Deny that returns true or false respectively
     public static async Task<bool> ConfirmDialogBuilder(MainWindow control, string title, string dialogContent, string confirmButtonText, string cancelButtonText)
     {
         var dialog = new ConfirmDialog
@@ -220,13 +221,14 @@ public static async Task<bool> ConfirmDialogBuilder(MainWindow control, string t
         return answer;
     }
 
-    public static async Task OkDialogBuilder(MainWindow control, string title, string DialogContent, string ConfirmButtonText)
+    // Only one button and no bool is returned.
+    public static async Task OkDialogBuilder(MainWindow control, string title, string dialogContent, string confirmButtonText)
     {
         var dialog = new OkDialog()
         {
             Title = LocalizationManager.Instance.GetString(title),
-            DialogContent = LocalizationManager.Instance.GetString(DialogContent),
-            ButtonText = LocalizationManager.Instance.GetString(ConfirmButtonText),
+            DialogContent = LocalizationManager.Instance.GetString(dialogContent),
+            ButtonText = LocalizationManager.Instance.GetString(confirmButtonText),
         };
 
         await dialog.ShowDialog<bool>(control);
diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index 416611200..0d066a4e2 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -156,6 +156,12 @@ public static async Task<ProtocolsResultCode> UnregisterProtocol()
     }
 
     // UI popup stuff
+    public static async Task OptionsManualPopup(MainWindow control)
+    {
+        var result = CheckExisting() ? await UnregisterProtocol() : await RegisterProtocol();
+        await HandleResult(result, control);
+    }
+
     public static async Task ProtocolSignupPopup(MainWindow control, DataManager cfg)
     {
         if (IsCandidateForProtocols(cfg))
@@ -169,44 +175,53 @@ public static async Task ProtocolSignupPopup(MainWindow control, DataManager cfg
 
         if (answer)
         {
-            retryPoint:
-
-            switch (await RegisterProtocol())
-            {
-                case ProtocolsResultCode.Success:
-                    break;
-                case ProtocolsResultCode.ErrorWindowsUac:
-                    var retryUac = await Helpers.ConfirmDialogBuilder(control,
-                        "protocols-dialog-error-title",
-                        "protocols-dialog-error-windows-uac",
-                        "protocols-dialog-error-again",
-                        "protocols-dialog-deny");
-                    if (retryUac)
-                        goto retryPoint;
-                    break;
-                case ProtocolsResultCode.ErrorMacOSTranslocation:
-                    await Helpers.OkDialogBuilder(control,
-                        "protocols-dialog-error-title",
-                        "protocols-dialog-error-macos-translocation",
-                        "protocols-dialog-error-ok");
-                    break;
-                case ProtocolsResultCode.ErrorUnknown:
-                    var retryUnknown = await Helpers.ConfirmDialogBuilder(control,
-                        "protocols-dialog-error-title",
-                        "protocols-dialog-error-generic",
-                        "protocols-dialog-error-again",
-                        "protocols-dialog-deny");
-                    if (retryUnknown)
-                        goto retryPoint;
-                    break;
-                default:
-                    throw new ArgumentOutOfRangeException();
-        }
+            await HandleResult(await RegisterProtocol(), control);
         }
 
         cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
     }
 
+    private static async Task HandleResult(ProtocolsResultCode result, MainWindow control)
+    {
+        retryPoint:
+
+        switch (result)
+        {
+            case ProtocolsResultCode.Success:
+                await Helpers.OkDialogBuilder(control,
+                    "protocols-dialog-title",
+                    "protocols-dialog-content-success",
+                    "protocols-dialog-ok");
+                break;
+            case ProtocolsResultCode.ErrorWindowsUac:
+                var retryUac = await Helpers.ConfirmDialogBuilder(control,
+                    "protocols-dialog-error-title",
+                    "protocols-dialog-error-windows-uac",
+                    "protocols-dialog-error-again",
+                    "protocols-dialog-deny");
+                if (retryUac)
+                    goto retryPoint;
+                break;
+            case ProtocolsResultCode.ErrorMacOSTranslocation:
+                await Helpers.OkDialogBuilder(control,
+                    "protocols-dialog-error-title",
+                    "protocols-dialog-error-macos-translocation",
+                    "protocols-dialog-error-ok");
+                break;
+            case ProtocolsResultCode.ErrorUnknown:
+                var retryUnknown = await Helpers.ConfirmDialogBuilder(control,
+                    "protocols-dialog-error-title",
+                    "protocols-dialog-error-generic",
+                    "protocols-dialog-error-again",
+                    "protocols-dialog-deny");
+                if (retryUnknown)
+                    goto retryPoint;
+                break;
+            default:
+                throw new ArgumentOutOfRangeException();
+        }
+    }
+
     private static bool IsCandidateForProtocols(DataManager cfg)
     {
         // They have been shown this dialog before, don't bother.
diff --git a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
index 10e4b86a8..a7fc30c5a 100644
--- a/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/OptionsTabView.xaml.cs
@@ -49,14 +49,9 @@ public async void OSProtocol(object? sender, RoutedEventArgs args)
     {
         try
         {
-            if (Protocol.CheckExisting())
-            {
-                await Protocol.UnregisterProtocol();
-            }
-            else
-            {
-                await Protocol.RegisterProtocol();
-            }
+            var mainWindow = (MainWindow?)this.GetVisualRoot();
+            if (mainWindow != null)
+                await Protocol.OptionsManualPopup(mainWindow);
         }
         catch (Exception e)
         {

From 10d6b7efceb05b2c9e37f1bc6707f78dcfc1b346 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 8 Mar 2025 23:22:18 +0100
Subject: [PATCH 32/39] Last min stuff here

---
 SS14.Launcher/Protocol.cs                     |  2 +-
 .../MainWindowTabs/DevelopmentTabView.xaml.cs | 26 +++++++++++++++----
 2 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index 0d066a4e2..03e09f39e 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -10,7 +10,7 @@ namespace SS14.Launcher;
 
 public abstract class Protocol
 {
-    public static bool CheckExisting()
+    private static bool CheckExisting()
     {
         var result = false;
         if (OperatingSystem.IsWindows())
diff --git a/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml.cs
index 6db19d358..905094a7e 100644
--- a/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/DevelopmentTabView.xaml.cs
@@ -1,5 +1,7 @@
-using Avalonia.Controls;
+using System;
+using Avalonia.Controls;
 using Avalonia.Interactivity;
+using Serilog;
 
 namespace SS14.Launcher.Views.MainWindowTabs;
 
@@ -10,13 +12,27 @@ public DevelopmentTabView()
         InitializeComponent();
     }
 
-    private void RegisterProtocols(object? _1, RoutedEventArgs _2)
+    private async void RegisterProtocols(object? _1, RoutedEventArgs _2)
     {
-        Protocol.RegisterProtocol();
+        try
+        {
+            await Protocol.RegisterProtocol();
+        }
+        catch (Exception e)
+        {
+            Log.Error(e, "Error registering protocols");
+        }
     }
 
-    private void UnregisterProtocols(object? _1, RoutedEventArgs _2)
+    private async void UnregisterProtocols(object? _1, RoutedEventArgs _2)
     {
-        Protocol.UnregisterProtocol();
+        try
+        {
+            await Protocol.UnregisterProtocol();
+        }
+        catch (Exception e)
+        {
+            Log.Error(e, "Error unregistering protocols");
+        }
     }
 }

From 4cd593d104c080bfdf037712de274131bb85c9de Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 8 Mar 2025 23:44:31 +0100
Subject: [PATCH 33/39] Confirmation

---
 SS14.Launcher/Assets/Locale/en-US/text.ftl |  8 ++++++++
 SS14.Launcher/Protocol.cs                  | 21 +++++++++++++++++++--
 2 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/SS14.Launcher/Assets/Locale/en-US/text.ftl b/SS14.Launcher/Assets/Locale/en-US/text.ftl
index 3e99c3971..aef08f649 100644
--- a/SS14.Launcher/Assets/Locale/en-US/text.ftl
+++ b/SS14.Launcher/Assets/Locale/en-US/text.ftl
@@ -371,8 +371,16 @@ protocols-dialog-content-success =
     The launcher has been successfully registered to your operating system!
 
     You can now use ss14(s):// links on web browsers and file extensions like .rtreplay
+protocols-dialog-content-action-question =
+    You are about to { $action } the operating system protocols from the Launcher
+
+    Do you want to continue?
+protocols-dialog-action-register = Register
+protocols-dialog-action-unregister = =Unregister
 protocols-dialog-confirm = For sure!
 protocols-dialog-deny = No Thanks
+protocols-dialog-continue = Yes, please continue
+protocols-dialog-back = Keep it as is
 protocols-dialog-ok = Yay
 protocols-dialog-error-title = OS protocol error
 protocols-dialog-error-windows-uac =
diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index 03e09f39e..481c471a8 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -3,6 +3,7 @@
 using System.Threading.Tasks;
 using Microsoft.Win32;
 using Serilog;
+using SS14.Launcher.Localization;
 using SS14.Launcher.Models.Data;
 using SS14.Launcher.Views;
 
@@ -158,8 +159,24 @@ public static async Task<ProtocolsResultCode> UnregisterProtocol()
     // UI popup stuff
     public static async Task OptionsManualPopup(MainWindow control)
     {
-        var result = CheckExisting() ? await UnregisterProtocol() : await RegisterProtocol();
-        await HandleResult(result, control);
+        // Not using ConfirmDialogBuilder because I am not sure how to make it support variables or whatever they are named
+        var dialog = new ConfirmDialog
+        {
+            Title = LocalizationManager.Instance.GetString("protocols-dialog-title"),
+            DialogContent = LocalizationManager.Instance.GetString("protocols-dialog-content-action-question",
+                ("action", CheckExisting() ? LocalizationManager.Instance.GetString("protocols-dialog-action-register")
+                    : LocalizationManager.Instance.GetString("protocols-dialog-action-unregister"))),
+            ConfirmButtonText = LocalizationManager.Instance.GetString("protocols-dialog-continue"),
+            CancelButtonText = LocalizationManager.Instance.GetString("protocols-dialog-back"),
+        };
+
+        var question = await dialog.ShowDialog<bool>(control);
+
+        if (question)
+        {
+            var result = CheckExisting() ? await UnregisterProtocol() : await RegisterProtocol();
+            await HandleResult(result, control);
+        }
     }
 
     public static async Task ProtocolSignupPopup(MainWindow control, DataManager cfg)

From 51adba98a3ea9b92e52d142d2cd21febb98df105 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sat, 8 Mar 2025 23:46:38 +0100
Subject: [PATCH 34/39] No point in checking it twice

---
 SS14.Launcher/Protocol.cs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index 481c471a8..bce6cfdc0 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -159,12 +159,14 @@ public static async Task<ProtocolsResultCode> UnregisterProtocol()
     // UI popup stuff
     public static async Task OptionsManualPopup(MainWindow control)
     {
+        var existing = CheckExisting();
+
         // Not using ConfirmDialogBuilder because I am not sure how to make it support variables or whatever they are named
         var dialog = new ConfirmDialog
         {
             Title = LocalizationManager.Instance.GetString("protocols-dialog-title"),
             DialogContent = LocalizationManager.Instance.GetString("protocols-dialog-content-action-question",
-                ("action", CheckExisting() ? LocalizationManager.Instance.GetString("protocols-dialog-action-register")
+                ("action", existing ? LocalizationManager.Instance.GetString("protocols-dialog-action-register")
                     : LocalizationManager.Instance.GetString("protocols-dialog-action-unregister"))),
             ConfirmButtonText = LocalizationManager.Instance.GetString("protocols-dialog-continue"),
             CancelButtonText = LocalizationManager.Instance.GetString("protocols-dialog-back"),
@@ -174,7 +176,7 @@ public static async Task OptionsManualPopup(MainWindow control)
 
         if (question)
         {
-            var result = CheckExisting() ? await UnregisterProtocol() : await RegisterProtocol();
+            var result = existing ? await UnregisterProtocol() : await RegisterProtocol();
             await HandleResult(result, control);
         }
     }

From ddcd7684999145069f91f6f875e7b9f5e33b26fe Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sun, 9 Mar 2025 21:13:20 +0100
Subject: [PATCH 35/39] Catch all and warning fix

Does it count as a warning fix if its just using the async that was not being used before?
---
 SS14.Launcher/Assets/Locale/en-US/text.ftl |  12 +-
 SS14.Launcher/Protocol.cs                  | 176 ++++++++++++---------
 2 files changed, 106 insertions(+), 82 deletions(-)

diff --git a/SS14.Launcher/Assets/Locale/en-US/text.ftl b/SS14.Launcher/Assets/Locale/en-US/text.ftl
index aef08f649..dee5bb494 100644
--- a/SS14.Launcher/Assets/Locale/en-US/text.ftl
+++ b/SS14.Launcher/Assets/Locale/en-US/text.ftl
@@ -372,11 +372,11 @@ protocols-dialog-content-success =
 
     You can now use ss14(s):// links on web browsers and file extensions like .rtreplay
 protocols-dialog-content-action-question =
-    You are about to { $action } the operating system protocols from the Launcher
+    You are about to { $action } the operating system protocols for the Launcher
 
     Do you want to continue?
 protocols-dialog-action-register = Register
-protocols-dialog-action-unregister = =Unregister
+protocols-dialog-action-unregister = Unregister
 protocols-dialog-confirm = For sure!
 protocols-dialog-deny = No Thanks
 protocols-dialog-continue = Yes, please continue
@@ -393,14 +393,10 @@ protocols-dialog-error-macos-translocation =
 
     MacOS Gatekeeper sandboxing is currently active on the launcher, please move
     the Space Station 14 Launcher into your Applications folder.
-protocols-dialog-error-linux-desktop-file-not-found =
-    It appears we were unable to register the launcher to Linux
-protocols-dialog-error-linux-xdg-mime =
-    It appears we were unable to register the launcher to Linux
 protocols-dialog-error-generic =
     It appears we were unable to register the launcher to your operating system
-    Either something went really wrong, or your OS is not supported
-    (Currently supported: Windows 10/11, MacOS, Linux)
+    look at the launcher log for further information.
+
     If this continues, please contact our Discord, Github or forum to report
     this Bug.
 
diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index bce6cfdc0..d1fc3bfd3 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -48,60 +48,75 @@ private static bool CheckExisting()
     }
     public static async Task<ProtocolsResultCode> RegisterProtocol()
     {
-        // Windows registration
-        if (OperatingSystem.IsWindows())
+        try
         {
-            try
-            {
-                var proc = new Process();
-                proc.StartInfo.FileName = "Space Station 14 Launcher.exe";
-                proc.StartInfo.Arguments = "--register-protocol";
-                proc.StartInfo.UseShellExecute = true;
-                proc.StartInfo.Verb = "runas";
-                proc.Start();
-            }
-            catch (System.ComponentModel.Win32Exception)
+            // Windows registration
+            if (OperatingSystem.IsWindows())
             {
-                // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
-                Log.Warning("User declined UAC or doesn't have admin rights.");
-                return ProtocolsResultCode.ErrorWindowsUac;
+                try
+                {
+                    var proc = new Process();
+                    proc.StartInfo.FileName = "Space Station 14 Launcher.exe";
+                    proc.StartInfo.Arguments = "--register-protocol";
+                    proc.StartInfo.UseShellExecute = true;
+                    proc.StartInfo.Verb = "runas";
+                    proc.Start();
+                    await proc.WaitForExitAsync();
+                }
+                catch (System.ComponentModel.Win32Exception)
+                {
+                    // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
+                    Log.Warning("User declined UAC or doesn't have admin rights.");
+                    return ProtocolsResultCode.ErrorWindowsUac;
+                }
             }
-        }
-        // macOS registration
-        if (OperatingSystem.IsMacOS())
-        {
-            var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
-            // User needs to move the app manually to get this sandbox restriction lifted. This can be done "automated" by making one of those installer dmg stuff
-            if (path.Contains("AppTranslocation"))
+            // macOS registration
+            if (OperatingSystem.IsMacOS())
             {
-                Log.Error("I have been put in apple jail (Gatekeeper path randomisation)... move me to your application folder");
-                return ProtocolsResultCode.ErrorMacOSTranslocation;
+                var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
+
+                // User needs to move the app manually to get this sandbox restriction lifted. This can be done "automated" by making one of those installer dmg stuff
+                if (path.Contains("AppTranslocation"))
+                {
+                    Log.Error(
+                        "I have been put in apple jail (Gatekeeper path randomisation)... move me to your application folder");
+                    return ProtocolsResultCode.ErrorMacOSTranslocation;
+                }
+
+                var newPath = string.Empty;
+                var appIndex = path.IndexOf(".app", StringComparison.Ordinal);
+                if (appIndex >= 0)
+                {
+                    newPath = path.Substring(0, appIndex + 4);
+                }
+
+                var proc = new Process();
+                // Yes you have to manually go to this
+                proc.StartInfo.FileName =
+                    "/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister";
+                proc.StartInfo.Arguments = $"-R -f {newPath}";
+                proc.Start();
+                await proc.WaitForExitAsync();
             }
 
-            var newPath = string.Empty;
-            var appIndex = path.IndexOf(".app", StringComparison.Ordinal);
-            if (appIndex >= 0)
+            // Linux registration
+            if (OperatingSystem.IsLinux())
             {
-                newPath = path.Substring(0, appIndex + 4);
-            }
+                var desktopfile = "";
 
-            var proc = new Process();
-            // Yes you have to manually go to this
-            proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister";
-            proc.StartInfo.Arguments = $"-R -f {newPath}";
-            proc.Start();
+                // todo ditto (2)
+                var proc = new Process();
+                proc.StartInfo.FileName = "xdg-mime";
+                proc.StartInfo.Arguments =
+                    $"default {desktopfile} x-scheme-handler/ss14;xdg-mime default SS14.desktop x-scheme-handler/ss14s";
+                proc.Start();
+            }
         }
-        // Linux registration
-        if (OperatingSystem.IsLinux())
+        catch (Exception ex)
         {
-            var desktopfile = "";
-
-            // todo ditto (2)
-            var proc = new Process();
-            proc.StartInfo.FileName = "xdg-mime";
-            proc.StartInfo.Arguments = $"default {desktopfile} x-scheme-handler/ss14;xdg-mime default SS14.desktop x-scheme-handler/ss14s";
-            proc.Start();
+            Log.Error(ex, "Failed to register protocol, and we did not catch it");
+            return ProtocolsResultCode.ErrorUnknown;
         }
 
         Log.Information("Successfully registered protocol");
@@ -109,47 +124,60 @@ public static async Task<ProtocolsResultCode> RegisterProtocol()
     }
     public static async Task<ProtocolsResultCode> UnregisterProtocol()
     {
-        // Windows unregistration
-        if (OperatingSystem.IsWindows())
+        try
         {
-            try
+            // Windows unregistration
+            if (OperatingSystem.IsWindows())
             {
-                var proc = new Process();
-                proc.StartInfo.FileName = "Space Station 14 Launcher.exe";
-                proc.StartInfo.Arguments = "--unregister-protocol";
-                proc.StartInfo.UseShellExecute = true;
-                proc.StartInfo.Verb = "runas";
-                proc.Start();
+                try
+                {
+                    var proc = new Process();
+                    proc.StartInfo.FileName = "Space Station 14 Launcher.exe";
+                    proc.StartInfo.Arguments = "--unregister-protocol";
+                    proc.StartInfo.UseShellExecute = true;
+                    proc.StartInfo.Verb = "runas";
+                    proc.Start();
+                    await proc.WaitForExitAsync();
+                }
+                catch (System.ComponentModel.Win32Exception)
+                {
+                    // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
+                    Log.Warning("User declined UAC or doesn't have admin rights.");
+                    return ProtocolsResultCode.ErrorWindowsUac;
+                }
             }
-            catch (System.ComponentModel.Win32Exception)
+
+            // macOS unregistration
+            if (OperatingSystem.IsMacOS())
             {
-                // Do nothing, the user either declined UAC, they don't have administrator rights or something else went wrong.
-                Log.Warning("User declined UAC or doesn't have admin rights.");
-                return ProtocolsResultCode.ErrorWindowsUac;
+                // This just... seems to do nothing. Its correct to my documentation...
+                var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
+
+                var newPath = string.Empty;
+                var appIndex = path.IndexOf(".app", StringComparison.Ordinal);
+                if (appIndex >= 0)
+                {
+                    newPath = path.Substring(0, appIndex + 4);
+                }
+
+                var proc = new Process();
+                proc.StartInfo.FileName =
+                    "/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister";
+                proc.StartInfo.Arguments = $"-R -f -u {newPath}";
+                proc.Start();
+                await proc.WaitForExitAsync();
             }
-        }
-        // macOS unregistration
-        if (OperatingSystem.IsMacOS())
-        {
-            // This just... seems to do nothing. Its correct to my documentation...
-            var path = $"{AppDomain.CurrentDomain.BaseDirectory}";
 
-            var newPath = string.Empty;
-            var appIndex = path.IndexOf(".app", StringComparison.Ordinal);
-            if (appIndex >= 0)
+            // Linux unregistration
+            if (OperatingSystem.IsLinux())
             {
-                newPath = path.Substring(0, appIndex + 4);
+                // todo ditto (2)
             }
-
-            var proc = new Process();
-            proc.StartInfo.FileName = "/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister";
-            proc.StartInfo.Arguments = $"-R -f -u {newPath}";
-            proc.Start();
         }
-        // Linux unregistration
-        if (OperatingSystem.IsLinux())
+        catch (Exception ex)
         {
-            // todo ditto (2)
+            Log.Error(ex, "Failed to unregister protocol, and we did not catch it");
+            return ProtocolsResultCode.ErrorUnknown;
         }
 
         Log.Information("Successfully unregistered protocol");

From dc4b9da48d057a8901b885744ec89c242fdd14ca Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sun, 9 Mar 2025 23:06:44 +0100
Subject: [PATCH 36/39] Correct the MimeTypes for Linux

---
 SS14.Launcher/Protocol.cs                               | 3 +++
 SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index d1fc3bfd3..9e4d66536 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -230,6 +230,9 @@ public static async Task ProtocolSignupPopup(MainWindow control, DataManager cfg
 
     private static async Task HandleResult(ProtocolsResultCode result, MainWindow control)
     {
+        // Lord, spare me for I have sinned.
+        // The goto is evil, yet the alternative is worse (in my opinion).
+        // Judge me not for the sin, but for the necessity. amen.
         retryPoint:
 
         switch (result)
diff --git a/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs b/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
index e597dcf51..b95a0b3a9 100644
--- a/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
+++ b/SS14.Launcher/Views/MainWindowTabs/HomePageView.xaml.cs
@@ -55,7 +55,7 @@ private async void OpenReplayClicked(object? sender, RoutedEventArgs e)
                 new FilePickerFileType("Replay or content bundle files")
                 {
                     Patterns = ["*.zip", "*.rtbundle", "*.rtreplay"],
-                    MimeTypes = ["application/zip", "x-scheme-handler/ss14", "x-scheme-handler/ss14s"],
+                    MimeTypes = ["application/zip", "application/rtbundle", "application/rtreplay"],
                     // Retrived using "mdls -name kMDItemContentType file.zip/rtreplay/rtbundle"
                     // No I'm not tripping... THIS is apparently how macOS identifies our file extension. Check Avalonia docs.
                     AppleUniformTypeIdentifiers = ["public.zip-archive", "dyn.ah62d4rv4ge81e7dwqz2g22p3", "dyn.ah62d4rv4ge81e7dcsz1gk5df"]

From 68521e0968b043e3b605d2479fa917e58ed54650 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Sun, 9 Mar 2025 23:18:16 +0100
Subject: [PATCH 37/39] Better generic error

---
 SS14.Launcher/Assets/Locale/en-US/text.ftl | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/SS14.Launcher/Assets/Locale/en-US/text.ftl b/SS14.Launcher/Assets/Locale/en-US/text.ftl
index dee5bb494..85175b4b5 100644
--- a/SS14.Launcher/Assets/Locale/en-US/text.ftl
+++ b/SS14.Launcher/Assets/Locale/en-US/text.ftl
@@ -394,11 +394,10 @@ protocols-dialog-error-macos-translocation =
     MacOS Gatekeeper sandboxing is currently active on the launcher, please move
     the Space Station 14 Launcher into your Applications folder.
 protocols-dialog-error-generic =
-    It appears we were unable to register the launcher to your operating system
-    look at the launcher log for further information.
+    It appears we were unable to register the launcher to your operating system.
 
     If this continues, please contact our Discord, Github or forum to report
-    this Bug.
+    this Bug. And provide a copy of your launcher log file.
 
     Want to try again?
 protocols-dialog-error-again = Try again

From f8ebe91621f47137c4b3e63faef7939081dcdda7 Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Mon, 10 Mar 2025 00:13:18 +0100
Subject: [PATCH 38/39] Protocol update check

I may as well have it ready now for #186
---
 SS14.Launcher/Assets/Locale/en-US/text.ftl |  4 ++
 SS14.Launcher/Protocol.cs                  | 57 ++++++++++++++++++----
 2 files changed, 52 insertions(+), 9 deletions(-)

diff --git a/SS14.Launcher/Assets/Locale/en-US/text.ftl b/SS14.Launcher/Assets/Locale/en-US/text.ftl
index 85175b4b5..86ed32e78 100644
--- a/SS14.Launcher/Assets/Locale/en-US/text.ftl
+++ b/SS14.Launcher/Assets/Locale/en-US/text.ftl
@@ -371,6 +371,10 @@ protocols-dialog-content-success =
     The launcher has been successfully registered to your operating system!
 
     You can now use ss14(s):// links on web browsers and file extensions like .rtreplay
+protocols-dialog-content-update =
+    The launcher's special links/file extension registration seems to be out of date.
+
+    Want to update it?
 protocols-dialog-content-action-question =
     You are about to { $action } the operating system protocols for the Launcher
 
diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index 9e4d66536..92b743805 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -11,16 +11,27 @@ namespace SS14.Launcher;
 
 public abstract class Protocol
 {
-    private static bool CheckExisting()
+    private static ProtocolsCheckResultCode CheckExisting()
     {
-        var result = false;
         if (OperatingSystem.IsWindows())
         {
             using var key1 = Registry.ClassesRoot.OpenSubKey("ss14s", false);
             using var key2 = Registry.ClassesRoot.OpenSubKey("ss14", false);
             using var key3 = Registry.ClassesRoot.OpenSubKey("RobustToolbox", false);
-            // no need to check the extension keys, they point to RobustToolbox
-            result = key1 != null && key2 != null && key3 != null;
+            using var key4 = Registry.ClassesRoot.OpenSubKey(".rtreplay", false);
+            using var key5 = Registry.ClassesRoot.OpenSubKey(".rtbundle", false);
+
+            if (key1 != null && key2 != null && key3 != null && key4 != null && key5 != null)
+            {
+                return ProtocolsCheckResultCode.Exists;
+            }
+
+            if (key1 == null && key2 == null && key3 == null && key4 == null && key5 == null)
+            {
+                return ProtocolsCheckResultCode.NonExistent;
+            }
+
+            return ProtocolsCheckResultCode.NeedsUpdate;
         }
 
         if (OperatingSystem.IsMacOS())
@@ -28,6 +39,7 @@ private static bool CheckExisting()
             // todo macos check existing protocol setup
             // I got no idea how to do this, lsregister does not report anything.
             // Lets just assume theres no record
+            return ProtocolsCheckResultCode.NonExistent;
         }
 
         if (OperatingSystem.IsLinux())
@@ -44,7 +56,7 @@ private static bool CheckExisting()
             proc.WaitForExit();
         }
 
-        return result;
+        return ProtocolsCheckResultCode.NonExistent;
     }
     public static async Task<ProtocolsResultCode> RegisterProtocol()
     {
@@ -187,7 +199,7 @@ public static async Task<ProtocolsResultCode> UnregisterProtocol()
     // UI popup stuff
     public static async Task OptionsManualPopup(MainWindow control)
     {
-        var existing = CheckExisting();
+        var existing = CheckExisting() != ProtocolsCheckResultCode.Exists;
 
         // Not using ConfirmDialogBuilder because I am not sure how to make it support variables or whatever they are named
         var dialog = new ConfirmDialog
@@ -211,7 +223,13 @@ public static async Task OptionsManualPopup(MainWindow control)
 
     public static async Task ProtocolSignupPopup(MainWindow control, DataManager cfg)
     {
-        if (IsCandidateForProtocols(cfg))
+        if (CheckExisting() == ProtocolsCheckResultCode.NeedsUpdate)
+        {
+            await ProtocolUpdatePopup(control);
+            return;
+        }
+
+        if (!IsCandidateForProtocols(cfg))
             return;
 
         var answer = await Helpers.ConfirmDialogBuilder(control,
@@ -228,6 +246,20 @@ public static async Task ProtocolSignupPopup(MainWindow control, DataManager cfg
         cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
     }
 
+    private static async Task ProtocolUpdatePopup(MainWindow control)
+    {
+        var answer = await Helpers.ConfirmDialogBuilder(control,
+            "protocols-dialog-title",
+            "protocols-dialog-content-update",
+            "protocols-dialog-confirm",
+            "protocols-dialog-deny");
+
+        if (answer)
+        {
+            await HandleResult(await RegisterProtocol(), control);
+        }
+    }
+
     private static async Task HandleResult(ProtocolsResultCode result, MainWindow control)
     {
         // Lord, spare me for I have sinned.
@@ -280,7 +312,7 @@ private static bool IsCandidateForProtocols(DataManager cfg)
 
         // It already exists. Either cause of a reset config file or already installed by steam.
         // Let's also set the cvar.
-        if (CheckExisting())
+        if (CheckExisting() == ProtocolsCheckResultCode.Exists)
         {
             cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
 
@@ -300,6 +332,13 @@ public enum ProtocolsResultCode : byte
         Success =  0,
         ErrorWindowsUac,
         ErrorMacOSTranslocation,
-        ErrorUnknown,
+        ErrorUnknown
+    }
+
+    public enum ProtocolsCheckResultCode : byte
+    {
+        Exists =  0,
+        NeedsUpdate,
+        NonExistent
     }
 }

From 61cdd7a4f39a211758a8cbcc82fd7f4bb53ac66c Mon Sep 17 00:00:00 2001
From: Vasilis The Pikachu <vasilis@pikachu.systems>
Date: Mon, 10 Mar 2025 21:05:56 +0100
Subject: [PATCH 39/39] Fix minor goof

Nik spotted this while I was accidentally rubber ducking this to them.
---
 SS14.Launcher/Protocol.cs | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/SS14.Launcher/Protocol.cs b/SS14.Launcher/Protocol.cs
index 92b743805..1b5c07f5d 100644
--- a/SS14.Launcher/Protocol.cs
+++ b/SS14.Launcher/Protocol.cs
@@ -216,8 +216,7 @@ public static async Task OptionsManualPopup(MainWindow control)
 
         if (question)
         {
-            var result = existing ? await UnregisterProtocol() : await RegisterProtocol();
-            await HandleResult(result, control);
+            await HandleResult(control);
         }
     }
 
@@ -240,7 +239,7 @@ public static async Task ProtocolSignupPopup(MainWindow control, DataManager cfg
 
         if (answer)
         {
-            await HandleResult(await RegisterProtocol(), control);
+            await HandleResult(control);
         }
 
         cfg.SetCVar(CVars.HasSeenProtocolsDialog, true);
@@ -256,18 +255,20 @@ private static async Task ProtocolUpdatePopup(MainWindow control)
 
         if (answer)
         {
-            await HandleResult(await RegisterProtocol(), control);
+            await HandleResult(control);
         }
     }
 
-    private static async Task HandleResult(ProtocolsResultCode result, MainWindow control)
+    private static async Task HandleResult(MainWindow control)
     {
         // Lord, spare me for I have sinned.
         // The goto is evil, yet the alternative is worse (in my opinion).
         // Judge me not for the sin, but for the necessity. amen.
         retryPoint:
 
-        switch (result)
+        var action = CheckExisting() == ProtocolsCheckResultCode.Exists ? await UnregisterProtocol() : await RegisterProtocol();
+
+        switch (action)
         {
             case ProtocolsResultCode.Success:
                 await Helpers.OkDialogBuilder(control,