diff --git a/library/utils/file_utils.py b/library/utils/file_utils.py index c783984..3ed2fcd 100644 --- a/library/utils/file_utils.py +++ b/library/utils/file_utils.py @@ -166,7 +166,26 @@ def untar(source_filename, destination_dir='.', verbose=False): print('Unzipping tarball data from %s to %s', source_filename, destination_dir) try: with tarfile.open(source_filename) as tar: - tar.extractall(destination_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, destination_dir) tar.close() return True except: