From dc43845850a582f7d66271550e5b3923425d8d02 Mon Sep 17 00:00:00 2001
From: underwaterresearch <solomon2773@yahoo.com>
Date: Sat, 4 Apr 2026 10:12:35 +0000
Subject: [PATCH] test: guard healthy readiness from warning writes

---
 .../__tests__/readinessWarning.test.js        | 26 ++++++++++++++++++-
 workers/provisioner/readinessWarning.js       | 10 ++++++-
 2 files changed, 34 insertions(+), 2 deletions(-)

diff --git a/backend-api/__tests__/readinessWarning.test.js b/backend-api/__tests__/readinessWarning.test.js
index 70c68ec..a27be9f 100644
--- a/backend-api/__tests__/readinessWarning.test.js
+++ b/backend-api/__tests__/readinessWarning.test.js
@@ -1,4 +1,14 @@
-const { buildReadinessWarningDetail, buildReadinessWarningMetadata, buildReadinessWarningState, persistReadinessWarning } = require("../../workers/provisioner/readinessWarning");
+const { shouldPersistReadinessWarning, buildReadinessWarningDetail, buildReadinessWarningMetadata, buildReadinessWarningState, persistReadinessWarning } = require("../../workers/provisioner/readinessWarning");
+
+describe("shouldPersistReadinessWarning", () => {
+  it("returns true for degraded readiness", () => {
+    expect(shouldPersistReadinessWarning({ ok: false })).toBe(true);
+  });
+
+  it("returns false for healthy readiness", () => {
+    expect(shouldPersistReadinessWarning({ ok: true })).toBe(false);
+  });
+});
 
 describe("buildReadinessWarningDetail", () => {
   it("formats a runtime-only readiness warning", () => {
@@ -117,6 +127,20 @@ describe("buildReadinessWarningState", () => {
 });
 
 describe("persistReadinessWarning", () => {
+  it("returns null and performs no writes for healthy readiness", async () => {
+    const db = { query: jest.fn().mockResolvedValue({}) };
+
+    const result = await persistReadinessWarning(db, {
+      agentId: "agent-healthy",
+      name: "Healthy Nora",
+      host: "agent.internal",
+      readiness: { ok: true },
+    });
+
+    expect(result).toBeNull();
+    expect(db.query).not.toHaveBeenCalled();
+  });
+
   it("writes warning agent status, warning deployment status, and the runtime warning event in order", async () => {
     const db = { query: jest.fn().mockResolvedValue({}) };
     const readiness = {
diff --git a/workers/provisioner/readinessWarning.js b/workers/provisioner/readinessWarning.js
index 10da50e..ebc3f37 100644
--- a/workers/provisioner/readinessWarning.js
+++ b/workers/provisioner/readinessWarning.js
@@ -1,3 +1,7 @@
+function shouldPersistReadinessWarning(readiness) {
+  return !readiness?.ok;
+}
+
 function buildReadinessWarningDetail(readiness) {
   const problems = [];
 
@@ -39,6 +43,10 @@ function buildReadinessWarningState({ agentId, name, host, readiness }) {
 }
 
 async function persistReadinessWarning(db, { agentId, name, host, readiness }) {
+  if (!shouldPersistReadinessWarning(readiness)) {
+    return null;
+  }
+
   const warningState = buildReadinessWarningState({ agentId, name, host, readiness });
 
   await db.query(`UPDATE agents SET status = '${warningState.agentStatus}' WHERE id = $1`, [agentId]);
@@ -51,4 +59,4 @@ async function persistReadinessWarning(db, { agentId, name, host, readiness }) {
   return warningState;
 }
 
-module.exports = { buildReadinessWarningDetail, buildReadinessWarningMetadata, buildReadinessWarningState, persistReadinessWarning };
+module.exports = { shouldPersistReadinessWarning, buildReadinessWarningDetail, buildReadinessWarningMetadata, buildReadinessWarningState, persistReadinessWarning };