Fix test expectations and apply formatting

Author: softpudding

extension/src/__tests__/highlight-detection.test.ts

@@ -111,7 +111,9 @@ describe('highlight-detection helpers', () => {
     const end = script.indexOf('function compareCandidates', start);
     const resolveElementCandidateSource = script.slice(start, end);
 
-    expect(resolveElementCandidateSource).toContain("if (requestedType === 'any')");
+    expect(resolveElementCandidateSource).toContain(
+      "if (requestedType === 'any')",
+    );
     expect(resolveElementCandidateSource).toContain(
       "candidates.push(buildResolvedCandidate(el, 'scrollable', 'scrollable'));",
     );
@@ -141,23 +143,25 @@ describe('highlight-detection helpers', () => {
     );
   });
 
-  test("buildHighlightDetectionScript prioritizes prominent scrollable containers for display", () => {
+  test('buildHighlightDetectionScript prioritizes prominent scrollable containers for display', () => {
     const script = buildHighlightDetectionScript({ elementType: 'any' });
     const start = script.indexOf('function isProminentScrollableCandidate');
     const end = script.indexOf('function getOverlapArea', start);
     const displayOrderingSource = script.slice(start, end);
 
+    expect(displayOrderingSource).toContain("candidate.type !== 'scrollable'");
     expect(displayOrderingSource).toContain(
-      "candidate.type !== 'scrollable'",
+      'candidate.area >= viewportArea * 0.12',
     );
-    expect(displayOrderingSource).toContain('candidate.area >= viewportArea * 0.12');
     expect(displayOrderingSource).toContain(
       'candidate.rect.height >= window.innerHeight * 0.35',
     );
     expect(displayOrderingSource).toContain(
       'candidate.rect.width >= window.innerWidth * 0.5',
     );
-    expect(displayOrderingSource).toContain('function compareDisplayCandidates');
+    expect(displayOrderingSource).toContain(
+      'function compareDisplayCandidates',
+    );
     expect(displayOrderingSource).toContain(
       "a.type === 'scrollable' && a.element.contains(b.element)",
     );

extension/src/background/index.ts

@@ -268,12 +268,14 @@ class CommandQueueManager {
           timestamp: Date.now(),
         };
 
-        wsClient.sendMessage({
-          type: 'command_response',
-          ...responseWithId,
-        }).catch((error) => {
-          console.error('Failed to send response:', error);
-        });
+        wsClient
+          .sendMessage({
+            type: 'command_response',
+            ...responseWithId,
+          })
+          .catch((error) => {
+            console.error('Failed to send response:', error);
+          });
       }
 
       return response;

extension/src/commands/element-actions.ts

@@ -543,13 +543,7 @@ export async function performElementHover(
  * Scroll direction type
  */
 export type ScrollDirection = 'up' | 'down' | 'left' | 'right';
-export type SwipeDirection =
-  | 'next'
-  | 'prev'
-  | 'left'
-  | 'right'
-  | 'up'
-  | 'down';
+export type SwipeDirection = 'next' | 'prev' | 'left' | 'right' | 'up' | 'down';
 
 /**
  * Result type for element scroll operation
@@ -1630,9 +1624,7 @@ export async function performElementSwipe(
   if (!swipeResult?.swiped) {
     const isStale = swipeResult?.stale === true;
     const error = swipeResult?.error || 'Swipe could not be performed';
-    console.log(
-      `❌ [ElementSwipe] Swipe failed: ${error}, stale=${isStale}`,
-    );
+    console.log(`❌ [ElementSwipe] Swipe failed: ${error}, stale=${isStale}`);
     return {
       success: false,
       elementId,

extension/src/commands/highlight-detection.injected.js

@@ -41,7 +41,9 @@ function hasCallableMethod(value, methodNames) {
     return false;
   }
 
-  return methodNames.some((methodName) => typeof value[methodName] === 'function');
+  return methodNames.some(
+    (methodName) => typeof value[methodName] === 'function',
+  );
 }
 
 function createHighlightTrace() {
@@ -147,9 +149,7 @@ function getClassTokens(el) {
   return Array.from(el.classList)
     .filter(
       (token) =>
-        token.length > 1 &&
-        token.length <= 40 &&
-        /^[a-z0-9_-]+$/i.test(token),
+        token.length > 1 && token.length <= 40 && /^[a-z0-9_-]+$/i.test(token),
     )
     .slice(0, 8);
 }
@@ -267,7 +267,10 @@ function getTabIndexValue(el) {
 }
 
 function isDisabledForDetection(el) {
-  if (el.hasAttribute('disabled') || el.getAttribute('aria-disabled') === 'true') {
+  if (
+    el.hasAttribute('disabled') ||
+    el.getAttribute('aria-disabled') === 'true'
+  ) {
     return true;
   }
 
@@ -322,7 +325,11 @@ function getControlAffinityScore(el) {
     score += Math.min(40, text.length);
   }
 
-  if (/\b(button|btn|filter|follow|like|refresh|reload|reply|search|share|submit|toggle)\b/i.test(searchText)) {
+  if (
+    /\b(button|btn|filter|follow|like|refresh|reload|reply|search|share|submit|toggle)\b/i.test(
+      searchText,
+    )
+  ) {
     score += 12;
   }
 
@@ -430,7 +437,10 @@ function getStructuralClickableSignal(el) {
     return null;
   }
 
-  if (hasExplicitClickableAncestor(el) || hasStructuredInteractiveDescendant(el)) {
+  if (
+    hasExplicitClickableAncestor(el) ||
+    hasStructuredInteractiveDescendant(el)
+  ) {
     return null;
   }
 
@@ -760,7 +770,10 @@ function isHoverableCandidate(el) {
     return false;
   }
 
-  if (hasExplicitClickableAncestor(el) || hasStructuredInteractiveDescendant(el)) {
+  if (
+    hasExplicitClickableAncestor(el) ||
+    hasStructuredInteractiveDescendant(el)
+  ) {
     return false;
   }
 
@@ -812,7 +825,8 @@ function hasHorizontalSwipeLayout(el) {
     overflowX.includes('auto');
 
   const visibleChildren = Array.from(el.children).filter(
-    (child) => child instanceof HTMLElement && isElementVisibleForDetection(child),
+    (child) =>
+      child instanceof HTMLElement && isElementVisibleForDetection(child),
   );
 
   if (visibleChildren.length === 0) {
@@ -831,14 +845,16 @@ function hasHorizontalSwipeLayout(el) {
         childStyle.display.includes('flex') ||
         childStyle.whiteSpace === 'nowrap'
       );
-    }) || (visibleChildren[0] instanceof HTMLElement ? visibleChildren[0] : null);
+    }) ||
+    (visibleChildren[0] instanceof HTMLElement ? visibleChildren[0] : null);
 
   if (!(primaryTrack instanceof HTMLElement)) {
     return false;
   }
 
   const trackChildren = Array.from(primaryTrack.children).filter(
-    (child) => child instanceof HTMLElement && isElementVisibleForDetection(child),
+    (child) =>
+      child instanceof HTMLElement && isElementVisibleForDetection(child),
   );
 
   if (trackChildren.length < 2) {
@@ -863,7 +879,10 @@ function hasHorizontalSwipeLayout(el) {
       if (childRect.left > previousRect.left + 12) {
         horizontalSteps += 1;
       }
-      if (Math.abs(childRect.top - previousRect.top) <= Math.max(24, rect.height * 0.2)) {
+      if (
+        Math.abs(childRect.top - previousRect.top) <=
+        Math.max(24, rect.height * 0.2)
+      ) {
         verticalAligned += 1;
       }
     }
@@ -949,7 +968,10 @@ function findSwipeContext(el, maxDepth = 4) {
       return current;
     }
 
-    if (hasHorizontalSwipeLayout(current) && current.getBoundingClientRect().width >= 180) {
+    if (
+      hasHorizontalSwipeLayout(current) &&
+      current.getBoundingClientRect().width >= 180
+    ) {
       return current;
     }
 
@@ -1066,7 +1088,9 @@ function generateSelector(el) {
 
 function getCandidateSignal(type, signalSource) {
   if (type === 'clickable') {
-    return HIGHLIGHT_SIGNAL_SCORE[signalSource] || HIGHLIGHT_SIGNAL_SCORE.pointer;
+    return (
+      HIGHLIGHT_SIGNAL_SCORE[signalSource] || HIGHLIGHT_SIGNAL_SCORE.pointer
+    );
   }
 
   return HIGHLIGHT_SIGNAL_SCORE[type] || 0;
@@ -1430,7 +1454,9 @@ function isRectInViewport(rect) {
 }
 
 function isMetricsTimeBudgetExceeded(startTime) {
-  return performance.now() - startTime >= layoutStabilityConfig.metricsTimeBudgetMs;
+  return (
+    performance.now() - startTime >= layoutStabilityConfig.metricsTimeBudgetMs
+  );
 }
 
 function countPendingViewportImages(metricsStartTime) {
@@ -1568,11 +1594,12 @@ function getPageMetrics() {
   const metricsStartTime = performance.now();
   const viewportText = collectViewportTextMetrics(metricsStartTime);
   const viewportMedia = countViewportMedia(metricsStartTime);
-  const placeholderSignals =
-    countViewportPlaceholderSignals(metricsStartTime);
+  const placeholderSignals = countViewportPlaceholderSignals(metricsStartTime);
 
   return {
-    bodyHeight: document.body ? document.body.getBoundingClientRect().height : 0,
+    bodyHeight: document.body
+      ? document.body.getBoundingClientRect().height
+      : 0,
     scrollHeight: document.documentElement
       ? document.documentElement.scrollHeight
       : 0,

extension/src/commands/highlight-detection.ts

@@ -50,7 +50,9 @@ export function getHighlightKeywordHaystack(
   }
 
   return [element.text, element.selector, element.tagName, element.html]
-    .filter((value): value is string => typeof value === 'string' && value.length > 0)
+    .filter(
+      (value): value is string => typeof value === 'string' && value.length > 0,
+    )
     .join(' ')
     .toLowerCase();
 }

extension/src/utils/layout-stability.ts

@@ -117,13 +117,15 @@ export function evaluateLayoutReadiness(
   }
 
   if (
-    metrics.skeletonLikeCount >= HIGHLIGHT_LAYOUT_STABILITY_CONFIG.skeletonLikeThreshold
+    metrics.skeletonLikeCount >=
+    HIGHLIGHT_LAYOUT_STABILITY_CONFIG.skeletonLikeThreshold
   ) {
     reasons.push('skeleton-placeholders');
   }
 
   if (
-    metrics.spinnerLikeCount >= HIGHLIGHT_LAYOUT_STABILITY_CONFIG.spinnerLikeThreshold
+    metrics.spinnerLikeCount >=
+    HIGHLIGHT_LAYOUT_STABILITY_CONFIG.spinnerLikeThreshold
   ) {
     reasons.push('loading-spinner');
   }
@@ -157,13 +159,13 @@ export function evaluateLayoutReadiness(
   if (
     !hasHardBlocker &&
     contentScore >= HIGHLIGHT_LAYOUT_STABILITY_CONFIG.readyContentScore &&
-    metrics.pendingImages <= HIGHLIGHT_LAYOUT_STABILITY_CONFIG.readyPendingImages
+    metrics.pendingImages <=
+      HIGHLIGHT_LAYOUT_STABILITY_CONFIG.readyPendingImages
   ) {
     state = 'ready';
   } else if (
     !hasHardBlocker &&
-    contentScore >=
-      HIGHLIGHT_LAYOUT_STABILITY_CONFIG.provisionalContentScore &&
+    contentScore >= HIGHLIGHT_LAYOUT_STABILITY_CONFIG.provisionalContentScore &&
     metrics.pendingImages <=
       HIGHLIGHT_LAYOUT_STABILITY_CONFIG.provisionalPendingImages
   ) {

server/agent/tools/base.py

@@ -312,7 +312,9 @@ def to_llm_content(self) -> Sequence[TextContent | ImageContent]:
             for el in self.highlighted_elements:
                 el_id = el.get("id", "unknown")
                 el_type = el.get("type")
-                raw_hints = el.get("interactionHints") or el.get("interaction_hints") or []
+                raw_hints = (
+                    el.get("interactionHints") or el.get("interaction_hints") or []
+                )
                 interaction_hints = [
                     hint
                     for hint in raw_hints
@@ -323,9 +325,7 @@ def to_llm_content(self) -> Sequence[TextContent | ImageContent]:
                     suffix_parts.append(el_type)
                 suffix_parts.extend(interaction_hints)
                 display_id = (
-                    f"{el_id}({', '.join(suffix_parts)})"
-                    if suffix_parts
-                    else el_id
+                    f"{el_id}({', '.join(suffix_parts)})" if suffix_parts else el_id
                 )
                 html = (el.get("html") or "").strip()
                 # Skip truncation for selectable elements (show full options)
@@ -363,7 +363,9 @@ def to_llm_content(self) -> Sequence[TextContent | ImageContent]:
             text_parts.append(full_html)
             text_parts.append("```")
             text_parts.append("")
-            text_parts.append("**To confirm this action, use the `element_interaction` tool with:**")
+            text_parts.append(
+                "**To confirm this action, use the `element_interaction` tool with:**"
+            )
             action_type = self.pending_confirmation.get("action_type", "")
             element_id = self.pending_confirmation.get("element_id", "")
             confirm_cmd = (

server/agent/tools/browser_executor.py

@@ -596,9 +596,7 @@ def _execute_element_interaction_action(
                 if not result_dict or not result_dict.get("success"):
                     ext_error = self._extract_result_error(result_dict)
                     raise RuntimeError(f"Failed to swipe element: {ext_error}")
-                message = (
-                    f"Swiped element (previously confirmed): {action.element_id}"
-                )
+                message = f"Swiped element (previously confirmed): {action.element_id}"
                 return self._build_observation_from_result(
                     result_dict, message, element_id=action.element_id
                 )

server/main.py

@@ -46,9 +46,7 @@ def cli():
 def serve(host, port, websocket_port, log_level, multi_process):
     """Start the Local Chrome Server"""
     if multi_process is not None:
-        os.environ["CHROME_SERVER_MULTI_PROCESS_MODE"] = (
-            "1" if multi_process else "0"
-        )
+        os.environ["CHROME_SERVER_MULTI_PROCESS_MODE"] = "1" if multi_process else "0"
 
     import uvicorn
     from server.api.main import app

server/tests/unit/test_agent_browser_executor.py

@@ -1,5 +1,7 @@
 """Regression tests for agent BrowserExecutor result handling."""
 
+import server.agent.tools.browser_executor as browser_executor_module
+
 from server.agent.tools.browser_executor import BrowserExecutor
 from server.agent.tools.element_interaction_tool import ElementInteractionAction
 from server.models.commands import SwipeElementCommand
@@ -21,7 +23,8 @@ def test_execute_command_sync_promotes_nested_error_to_top_level(monkeypatch) ->
     executor.conversation_id = "conv-swipe-error"
 
     monkeypatch.setattr(
-        "server.agent.tools.browser_executor.requests.post",
+        browser_executor_module.requests,
+        "post",
         lambda *args, **kwargs: _FakeResponse(
             {
                 "success": False,
@@ -71,6 +74,8 @@ def test_confirm_swipe_reports_nested_extension_error(monkeypatch) -> None:
     )
 
     assert observation.success is False
-    assert observation.error == "Failed to swipe element: No swipeable container found for element"
+    assert (
+        observation.error
+        == "Failed to swipe element: No swipeable container found for element"
+    )
     assert "None" not in observation.message
-