Commit dbce69a
[SNOW-3249917] JDBC removal Step 10c: Remove SFSession from storage stack
Remove SFSession/SFBaseSession parameters and dead session-based code
from the storage client stack. Session was always null from ingest callers.
Storage clients (SnowflakeS3Client, SnowflakeAzureClient, SnowflakeGCSClient):
- Remove SFSession/SFBaseSession fields and constructor params
- Remove dead `if (session != null)` proxy/headers/permissions blocks
(keep sessionless path)
- Remove dead `if (session != null) { renewExpiredToken(...) }` blocks
- Simplify getMaxRetries() to return default (no session property lookup)
- Replace session.isOwnerOnlyStageFilePermissionsEnabled() with false
Interface + strategies:
- SnowflakeStorageClient: remove SFSession from all method signatures
- GCSAccessStrategy/GCSAccessStrategyAwsSdk/GCSDefaultAccessStrategy:
remove SFSession from constructors and handleStorageException
- StorageClientFactory: remove SFSession/SFBaseSession params
Agent + config:
- SnowflakeFileTransferAgent: remove session from getStageInfo(),
pushFileToRemoteStore(), compressStreamWithGZIP/NoDigest().
Remove dead renewExpiredToken(), parseCommandInGS(),
getLocalFilePathFromCommand() methods.
- SnowflakeFileTransferConfig: remove SFSession field, getter, setter
Remaining SFSession imports (3): SnowflakeSQLLoggedException (constructor
params), TelemetryClient (session-based code) — to be handled next.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 72f5e83 commit dbce69a
File tree
10 files changed
+189
-525
lines changed- src/main/java/net/snowflake/ingest/streaming/internal/fileTransferAgent
10 files changed
+189
-525
lines changedLines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
43 | | - | |
44 | 42 | | |
45 | 43 | | |
46 | 44 | | |
| |||
Lines changed: 20 additions & 50 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | 30 | | |
32 | 31 | | |
33 | 32 | | |
34 | | - | |
35 | | - | |
36 | 33 | | |
37 | 34 | | |
38 | 35 | | |
| |||
42 | 39 | | |
43 | 40 | | |
44 | 41 | | |
45 | | - | |
| 42 | + | |
46 | 43 | | |
47 | 44 | | |
48 | 45 | | |
| |||
74 | 71 | | |
75 | 72 | | |
76 | 73 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
| 74 | + | |
92 | 75 | | |
93 | 76 | | |
94 | 77 | | |
| |||
237 | 220 | | |
238 | 221 | | |
239 | 222 | | |
240 | | - | |
241 | 223 | | |
242 | 224 | | |
243 | 225 | | |
| |||
256 | 238 | | |
257 | 239 | | |
258 | 240 | | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
278 | 253 | | |
279 | 254 | | |
280 | 255 | | |
281 | 256 | | |
282 | | - | |
| 257 | + | |
283 | 258 | | |
284 | 259 | | |
285 | 260 | | |
| |||
314 | 289 | | |
315 | 290 | | |
316 | 291 | | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
327 | 297 | | |
328 | 298 | | |
329 | 299 | | |
| |||
Lines changed: 8 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
31 | | - | |
| 30 | + | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
39 | | - | |
| 38 | + | |
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
| |||
176 | 175 | | |
177 | 176 | | |
178 | 177 | | |
179 | | - | |
180 | 178 | | |
181 | 179 | | |
182 | 180 | | |
| |||
191 | 189 | | |
192 | 190 | | |
193 | 191 | | |
194 | | - | |
| 192 | + | |
195 | 193 | | |
196 | 194 | | |
197 | 195 | | |
| |||
223 | 221 | | |
224 | 222 | | |
225 | 223 | | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
237 | 229 | | |
238 | 230 | | |
239 | 231 | | |
| |||
0 commit comments