Skip to content

Add citation marks around CSS selectors #62

@d-tamm

Description

@d-tamm

In tagging.js on line 617, there should be citation marks around the CSS selector like this:
$tag = self.$elem.find( "input[value='" + text + "']" ).parent();
rather than:
$tag = self.$elem.find( "input[value=" + text + "]" ).parent();

As it is now, the selector will fail finding tags e.g. containing a fullstop or an at (@).

Error messages from a simple usage example:

$("#tagBox").tagging("remove", "tag.1");
Uncaught Error: Syntax error, unrecognized expression: input[value=tag.1]
    jQuery 5
    remove tagging.js:617
    tagging tagging.js:806
    jQuery 2
    tagging tagging.js:786
    <anonymous> debugger eval code:1

Maybe there is even some more work to do to make it function correctly even with tags containing citation marks.
Otherwise, thank you for this great project!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions