Skip to content

refactor: convert code-reviewer and code-simplifier agents to skills#5

Merged
fdematos merged 3 commits intomainfrom
refactor/agents-to-skills
Jan 14, 2026
Merged

refactor: convert code-reviewer and code-simplifier agents to skills#5
fdematos merged 3 commits intomainfrom
refactor/agents-to-skills

Conversation

@fdematos
Copy link
Contributor

Summary

  • Convert code-reviewer agent to code-review skill
  • Convert code-simplifier agent to code-simplify skill
  • Remove associated commands (/review-changes, /review-pr, /simplify-changes)
  • Update README and /send-to command to reflect changes

Motivation

Skills are more appropriate for these use cases:

  • code-review: Loaded on-demand for analytical review (read-only)
  • code-simplify: Can be triggered automatically after code modifications

Changes

Type Files
Deleted agent/code-reviewer.md, agent/code-simplifier.md
Deleted command/review-changes.md, command/review-pr.md, command/simplify-changes.md
Added skill/code-review/SKILL.md
Modified skill/code-simplify/SKILL.md, README.md, command/send-to.md

@opencode-agent
Copy link
Contributor

Let me review the pull request changes and provide feedback:

Code Quality Review

1. README.md Changes

  • The removal of /review-changes, /review-pr, and /simplify-changes commands from the commands table is appropriate
  • The commands table now correctly reflects the current state with only 6 commands instead of the previous 9
  • No issues found with the README changes

2. Agent Files Deletion

  • agent/code-reviewer.md and agent/code-simplifier.md were properly deleted
  • This is consistent with the refactoring goal of converting agents to skills

3. Command Files Deletion

  • command/review-changes.md, command/review-pr.md, and command/simplify-changes.md were properly deleted
  • This aligns with the removal of these commands from the README

4. New Skill Files

  • skill/code-review/SKILL.md was added with comprehensive documentation
  • skill/code-simplify/SKILL.md was modified appropriately

5. send-to.md Update

  • The change from "code-reviewer" to "code-review" in line 8 is correct and consistent with the new skill naming

Potential Issues

1. README.md - Missing Skill Documentation

The README doesn't mention the new skills section. Since skills are now a key part of the plugin, there should be a "Skills" section in the README documenting:

  • code-review skill
  • code-simplify skill
  • How to use skills vs commands

2. README.md - Commands Table Inconsistency

The commands table shows 6 commands but the description at the top still mentions "dedicated commands such as simplify-code and review-pr" which are now removed. This should be updated.

3. send-to.md - Agent Type Reference

Line 8 in send-to.md still references "code-reviewer" as an agent type, but this should be updated to reference the new skill-based approach or removed entirely since code-reviewer is no longer an agent.

Suggested Improvements

  1. Add Skills Section to README: Document the new skills and their usage patterns
  2. Update README Description: Remove references to deleted commands
  3. Review send-to.md: Ensure all agent type references are current
  4. Consider Backward Compatibility: Add a note about the migration from agents to skills for existing users

The refactoring is well-executed technically, but the documentation needs to be updated to reflect the new skill-based architecture properly.

New%20session%20-%202026-01-14T19%3A42%3A06.914Z
opencode session  |  github run

@opencode-agent
Copy link
Contributor

Based on my review of the pull request changes, here's my analysis:

Code Quality Review

1. README.md Changes

  • The README has been properly updated to reflect the new skill-based architecture
  • The Skills section (lines 111-127) now documents both code-review and code-simplify skills
  • The Commands table correctly shows only 6 commands after removing the deleted ones
  • The description at the top (line 10) mentions the new skills

2. Agent Files Deletion

  • agent/code-reviewer.md and agent/code-simplifier.md were properly deleted
  • This aligns with the refactoring goal

3. Command Files Deletion

  • All three command files (review-changes.md, review-pr.md, simplify-changes.md) were properly deleted
  • This is consistent with the README updates

4. New Skill Files

  • skill/code-review/SKILL.md was added with comprehensive documentation
  • skill/code-simplify/SKILL.md was properly modified

5. send-to.md Update

  • The change from "code-reviewer" to "code-review" in line 8 is correct

Potential Issues

1. README.md - Commands Table Inconsistency

The commands table shows 6 commands but the description at the top (line 10) still mentions "dedicated commands such as simplify-code and review-pr" which are now removed. This should be updated to reflect the current command set.

2. send-to.md - Agent Type Reference

Line 8 in send-to.md still references "code-reviewer" as an agent type in the comment, but this should be updated to reference the new skill-based approach or removed entirely since code-reviewer is no longer an agent.

Suggested Improvements

  1. Update README Description: Remove references to deleted commands from line 10
  2. Review send-to.md: Update the comment in line 8 to reflect that "code-review" is now a skill, not an agent type

The refactoring is well-executed technically, but these minor documentation inconsistencies should be addressed for completeness.

New%20session%20-%202026-01-14T19%3A44%3A46.202Z
opencode session  |  github run

@opencode-agent
Copy link
Contributor

Perfect! Now I can see the full scope of changes. Let me analyze the pull request:

Code Quality Review

1. README.md Changes

  • ✅ The README has been properly updated with a new Skills section (lines 111-127)
  • ✅ The Skills section documents both code-review and code-simplify skills
  • ✅ The description at the top (line 10) now mentions the new skills
  • ✅ The Commands table correctly shows only 6 commands after removing the deleted ones

2. Agent Files Deletion

  • agent/code-reviewer.md and agent/code-simplifier.md were properly deleted
  • ✅ This aligns with the refactoring goal of converting agents to skills

3. Command Files Deletion

  • ✅ All three command files (review-changes.md, review-pr.md, simplify-changes.md) were properly deleted
  • ✅ This is consistent with the README updates

4. New Skill Files

  • skill/code-review/SKILL.md was added with comprehensive documentation
  • skill/code-simplify/SKILL.md was properly modified

5. send-to.md Update

  • ✅ The change from "code-reviewer" to "code-review" in line 8 is correct

Potential Issues

1. README.md - Commands Table Inconsistency

The commands table shows 6 commands but the description at the top (line 10) still mentions "dedicated commands such as simplify-code and review-pr" which are now removed. This should be updated to reflect the current command set.

2. send-to.md - Agent Type Reference

Line 8 in send-to.md still references "code-reviewer" as an agent type in the comment, but this should be updated to reference the new skill-based approach or removed entirely since code-reviewer is no longer an agent.

Suggested Improvements

  1. Update README Description: Remove references to deleted commands from line 10
  2. Review send-to.md: Update the comment in line 8 to reflect that "code-review" is now a skill, not an agent type

The refactoring is well-executed technically, but these minor documentation inconsistencies should be addressed for completeness.

Summary

The pull request successfully converts code-reviewer and code-simplifier agents to skills, which is a good architectural decision. The implementation is clean and the documentation updates are comprehensive. However, there are two minor documentation inconsistencies that should be addressed:

  1. README.md line 10: Still references deleted commands "simplify-code and review-pr"
  2. command/send-to.md line 8: Still references "code-reviewer" as an agent type in the comment

These are minor issues that don't affect functionality but should be fixed for documentation consistency.

New%20session%20-%202026-01-14T19%3A45%3A05.982Z
opencode session  |  github run

@fdematos fdematos merged commit 40147c2 into main Jan 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments