-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Labels
featuregood first issuea relatively simple task to familiarize oneself with the code base, and the contribution processa relatively simple task to familiarize oneself with the code base, and the contribution processhelp wantedWe'd like help with this issue, and are happy to provide guidanceWe'd like help with this issue, and are happy to provide guidance
Description
Currently, the -f both means:
-
that we include data from failing runs, which can be caused either by benchmarks aborting or because the validation of results fails or output indicates other issues
-
that the
rebenchexit code indicates no failure
We may want to separate these concerns out.
It might be useful to have a --dont-fail option, just to keep the exit code 0.
Where --faulty is only about including data from runs that indicate some issue.
Requested by @OctaveLarose
OctaveLarose
Metadata
Metadata
Assignees
Labels
featuregood first issuea relatively simple task to familiarize oneself with the code base, and the contribution processa relatively simple task to familiarize oneself with the code base, and the contribution processhelp wantedWe'd like help with this issue, and are happy to provide guidanceWe'd like help with this issue, and are happy to provide guidance