Trees are replanted even if player lack of perm treeassist.replant

[SaitDev]

The issue is mentioned as so in the title.

I tried to look at the code, i guess you are missing the negative compare at https://github.com/slipcor/TreeAssist/blob/master/src/main/java/net/slipcor/treeassist/discovery/TreeStructure.java#L2034 .
Should be !TreeAssist.instance.getBlockListener().isReplant(player.getName())
Since the BlockListener.replant list is about forcing replant, not normal replanting.

Please correct me if im wrong, Im not very familiar with the codebase

[slipcor]

So when I look at what this branch does, it seems like I definitely did not properly implement the if-check in this commit:

562256a

This permission check only ever applies if we generally (e.g. in default.yml) do not enforce ALL saplings to replant.

So when we take a look at this from a logical standpoint, this branch does not make sense as it is. I indeed seem to have broken the replanting permission logic. It only gets checked when we are enforcing the replanting via command....

It is crazy to me that nobody ever noticed this so far. So what we have now is a broken permission check. "fixing" this could do more harm than good.

The default is that only operators are autoreplanting... that is craaaaaazy.... I will change this to default to "everyone can autoreplant" because that is what the effective result of my code WAS. and will fix it in the code to apply the perm check if we EITHER are trying to force the replanting via command or we are NOT enforcing.

Because IF we are doing it via command we are trying to do something that the server owner did not intend to happen by default to everyone and it might be limited by permissions. If we are doing it because of a config setting, no permission checks are needed. That is the proper logic....