Erros in README.md: wrong tap arguments and missing information

[PoulpiFr]

Wrong argument in snippet

In the README.md, it is stated:

Then to run the extract:

› tap-frontapp --config config.json --catalog catalog.json --state state.json

While the catalog argument is not parsed by the tap. Instead, the properties argument is used: https://github.com/singer-io/tap-frontapp/blob/master/tap_frontapp/__init__.py#L84

if args.properties else discover()

Missing information

In order for the tap to run, we need to add an entry in the streams record of the catalog.

See:

https://github.com/singer-io/tap-frontapp/blob/master/tap_frontapp/context.py

    def catalog(self, catalog):
        self._catalog = catalog
        self.selected_stream_ids = set()
        for stream in catalog.streams:
            mdata = metadata.to_map(stream.metadata)
            root_metadata = mdata.get(())
            if root_metadata and root_metadata.get('selected') is True:
                self.selected_stream_ids.add(stream.tap_stream_id)

https://github.com/singer-io/tap-frontapp/blob/master/tap_frontapp/streams.py

def sync_selected_streams(atx):
    selected_streams = atx.selected_stream_ids

    # last_synced_stream = atx.state.get('last_synced_stream')

    if IDS.TEAM_TABLE in selected_streams:
        sync_metrics(atx, 'team_table')

in order to have the streams in the selected_stream_ids, we need to add a entry in the catalog.json with an empty breadcrumbs array to be set in the ()value of the map generated from the catalog.