Can't open a local file anymore in v11

[alljinx]

Hi,

I've been using this library successfully for quite some time to open a local file (the "index.html" file containing a Jest coverage report). Unfortunately, since the update to v11, it no longer works. Is this a breaking change (I haven't been able to find the changelog)? Or is it a bug?

I am on Windows 10.

Thanks.

[sindresorhus]

What happens when you do it? Do you get an error?

[alljinx]

Absolutely nothing is happening, and no error in the catch...

[adriangodong]

I have the same issue. I'm opening a local HTML file using Powershell + npm. This seems to have been regressed in e1af0ee. Reverting this commit seems to bring back to old behavior. My workaround is to pass wait: true.

- open(outputFilePath);
+ open(outputFilePath, { wait: true });

[sou-long]

After updating from v10.2.0 to v11.0.0 my helper script stopped opening urls too.

It seems that open(url) stopped waiting for a process to kinda "finish starting", so if your script exits right after await open(url), the runtime basically kills (abandons?) the subprocess prematurely.

Not sure if this aligns well with js-spirit, cause it kinda overlaps with the idea of "simply don't await", at least for urls.
But given the major version bump, this seems to be designed, not overlooked.
I think it may be worth mentioning in the docs that exiting early without {wait:true} may abort the whole thing, compared to v10.

What solves the issue:

await open(url, {wait:true})

await open(url)
// don't exit right away

3. Downgrading back to v10.2.0.

[sou-long]

I also suggest renaming this issue into "v11 stopped open urls" or similar, to make it a migration funnel.
Cause it happens for all urls, not only local.