Skip to content

Fixed cipher class' methods for encryption and decryption #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nehir-ww wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −8
Open

Fixed cipher class' methods for encryption and decryption #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions Cipher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// This class is used for encrypting or decrypting strings using character mapping
public class Cipher
public class Cipher
{
// Strings for keeping the alphabets, one for the original letters and the other for the encrypted ones
// encryption involves mapping from original to cipher, for each letter we locate the character in the
Expand All @@ -13,9 +13,9 @@ public String encrypt(String inputString) {
String outputString = "";

// for all chars in the input string
for (int i = 0; i < inputString.length(); i++)
for (int i = 0; i < inputString.length(); i++)
{

outputString += replaceChar(inputString.charAt(i), true);
}

return outputString;
Expand All @@ -26,7 +26,10 @@ public String decrypt(String inputString) {
// output string will be collected in this variable, one char at a time
String outputString = "";

replaceChar('a',true);
for (int i = 0; i < inputString.length(); i++)
{
outputString += replaceChar(inputString.charAt(i), false);
}

return outputString;
}
Expand All @@ -39,15 +42,15 @@ public String decrypt(String inputString) {
private char replaceChar(char inputChar, boolean isEncrypt) {

if(isEncrypt) {
for (int i = 0; i < ORIGINAL_ALPHABET.length(); i++)
for (int i = 0; i < ORIGINAL_ALPHABET.length(); i++)
{
if(ORIGINAL_ALPHABET.charAt(i) == inputChar) {

inputChar = CIPHER_ALPHABET.charAt(i);
}
}
}
else {
for (int i = 0; i < CIPHER_ALPHABET.length(); i++)
for (int i = 0; i < CIPHER_ALPHABET.length(); i++)
{
if(CIPHER_ALPHABET.charAt(i) == inputChar) {
return ORIGINAL_ALPHABET.charAt(i);
Expand All @@ -58,4 +61,4 @@ private char replaceChar(char inputChar, boolean isEncrypt) {
// if we did not find it in the alphabet, then return the original char
return inputChar;
}
}
}