From c85c63458285c9cd7bd84623d81924c32c5881a2 Mon Sep 17 00:00:00 2001 From: Jose' Pedro Saraiva Date: Fri, 9 Jan 2026 09:59:27 +0100 Subject: [PATCH 1/3] ci: bump golangci-lint to 2.8.0 --- .github/workflows/golangcilint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/golangcilint.yml b/.github/workflows/golangcilint.yml index ff02106f..4d34f062 100644 --- a/.github/workflows/golangcilint.yml +++ b/.github/workflows/golangcilint.yml @@ -20,7 +20,7 @@ jobs: - uses: actions/setup-go@v6 with: go-version: "1.25" - lint-version: "v2.7.2" + lint-version: "v2.8.0" check-latest: true - uses: actions/checkout@v6 - name: golangci-lint From 8e897702fdadc5159ef99f81b3e07f389e3c97ef Mon Sep 17 00:00:00 2001 From: Jose' Pedro Saraiva Date: Fri, 9 Jan 2026 10:05:24 +0100 Subject: [PATCH 2/3] fixup --- internal/testutils/repotest/repotest.go | 6 +++++- pkg/baur/loader.go | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/internal/testutils/repotest/repotest.go b/internal/testutils/repotest/repotest.go index 1e0f1e45..86fa5cb5 100644 --- a/internal/testutils/repotest/repotest.go +++ b/internal/testutils/repotest/repotest.go @@ -230,7 +230,11 @@ type Repo struct { // TaskIDs returns the tasks ids (.) of all tasks in the AppCfgs slice func (r *Repo) TaskIDs() []string { - var result []string + totalTasks := 0 + for _, appCfg := range r.AppCfgs { + totalTasks += len(appCfg.Tasks) + } + result := make([]string, 0, totalTasks) for _, appCfg := range r.AppCfgs { for _, task := range appCfg.Tasks { diff --git a/pkg/baur/loader.go b/pkg/baur/loader.go index 64c832dd..345fe01f 100644 --- a/pkg/baur/loader.go +++ b/pkg/baur/loader.go @@ -62,7 +62,7 @@ func NewLoader(repoCfg *cfg.Repository, gitCommitIDFunc func() (string, error), // If no specifier is passed all tasks of all apps are returned. // If multiple specifiers match the same task, it's only returned 1x in the returned slice. func (a *Loader) LoadTasks(specifier ...string) ([]*Task, error) { - var result []*Task + result := make([]*Task, 0) specs, err := parseSpecs(specifier) if err != nil { From f4a4f10503434926ba4eda2bf8a9e94c0c18126e Mon Sep 17 00:00:00 2001 From: Jose' Pedro Saraiva Date: Fri, 9 Jan 2026 10:10:15 +0100 Subject: [PATCH 3/3] fixup --- pkg/baur/loader.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/baur/loader.go b/pkg/baur/loader.go index 345fe01f..b7e01a72 100644 --- a/pkg/baur/loader.go +++ b/pkg/baur/loader.go @@ -62,8 +62,6 @@ func NewLoader(repoCfg *cfg.Repository, gitCommitIDFunc func() (string, error), // If no specifier is passed all tasks of all apps are returned. // If multiple specifiers match the same task, it's only returned 1x in the returned slice. func (a *Loader) LoadTasks(specifier ...string) ([]*Task, error) { - result := make([]*Task, 0) - specs, err := parseSpecs(specifier) if err != nil { return nil, err @@ -80,7 +78,7 @@ func (a *Loader) LoadTasks(specifier ...string) ([]*Task, error) { return a.allTasks(apps) } - result, err = a.allTasks(apps) + result, err := a.allTasks(apps) if err != nil { return nil, err }