Support for Maps and Sets

[pbadenski]

I'm very keen on both being supported when cloning. I did some experimenting and I can see two ways of getting that done:

• add support to existing deep-copy (potentially that would mean switch major release to 2.0 since it definitely breaks backwards compatibility)
• create deep-copy-es6 with added functionality

Thoughts?

[simov]

I'm not sure how similar cloning implementation for Map and Set would look like. Probably a separate module would be better, though I would be interested to see how it look like when ready.

[pbadenski]

Makes sense. I will code up a proposal and let you know.

[terrymorse58]

It's not just Map and Set, there are other object "types" that are being removed or mangled on the copy. These are the ones I have tested and found the results incorrect:

• RegExp (becomes empty {})
• Int8Array (becomes Object)
• Uint8Array (becomes Object)
• Uint8ClampedArray (becomes Object)
• Int16Array (becomes Object)
• Uint16Array (becomes Object)
• Int32Array (becomes Object)
• Uint32Array (becomes Object)
• Float32Array (becomes Object)
• Float64Array (becomes Object)
• BigInt64Array (becomes Object)
• BigUint64Array (becomes Object)

Example from my RegExp test:

let src = [1, 2, /abc/, "foo"];
let dest = deepCopy(src);
dest10[3] = "BAR";
console.log(src); // [ 1, 2, /abc/, 'foo' ]
console.log(dest); // [ 1, 2, {}, 'BAR' ]

Also, it's not preserving non-enumerable properties on the copy. I suggest this could be a configurable option—that seems to be the common way to handle those in other modules.

I started a new module named deep-copy-all that handles these new object types. It includes a test suite to validate the handling of the new objects.