TypeError: systemMenu._actionsItem is undefined

[jordiromera]

On Debian testing and Gnome 3.34, turnoffdisplay has this error :

Extension "turnoffdisplay@simonthechipmunk.noreply.com" had error: TypeError: systemMenu._actionsItem is undefined

[kstange]

Just wanted to note on this that if you add buttons into systemMenu.menu you will be putting the button outside the container for the other buttons and it will wrap to its own line. systemMenu.buttonGroup needs to be used instead across the entire extension to fix the spacing and alignment of buttons.

[Quip11]

I applied the fix above and two other occurrences of _actionsItem.actor in css_adjust.js, and the extension appears to work in Gnome 3.34, except that the system menu gets very wide. If @kstange posts a fix, I'll try it.

[Quip11]

OK, here's a fix that uses buttonGroup. I'll see if I can create a pull request.

diff --git a/css_adjust.js b/css_adjust.js
index c6024da..7fddd15 100644
--- a/css_adjust.js
+++ b/css_adjust.js
@@ -40,12 +40,12 @@ function handle_aggregate_menu(mode, width) {
 	
 		
 		// monitor changes in the system area
-		menuChangedAdd = aggregateMenu._system._actionsItem.actor.connect('actor_added', function() { 
+		menuChangedAdd = aggregateMenu._system.buttonGroup.connect('actor_added', function() {
 				
 			checkAggregatemenuwidth(); 
 		});
 		
-		menuChangedRem = aggregateMenu._system._actionsItem.actor.connect('actor_removed', function() { 
+		menuChangedRem = aggregateMenu._system.buttonGroup.connect('actor_removed', function() {
 			
 			checkAggregatemenuwidth();							
 		});
@@ -80,7 +80,7 @@ function checkAggregatemenuwidth() {
 // run menu width adjustment if necessary
 
 
-	let actionChildren = aggregateMenu._system._actionsItem.actor.get_children();
+	let actionChildren = aggregateMenu._system.buttonGroup.get_children();
 	let allButtonWidth = actionChildren[1].get_width()*2;
 	
 	//calculate new width
diff --git a/extension.js b/extension.js
index 62ab366..d23364d 100644
--- a/extension.js
+++ b/extension.js
@@ -196,7 +196,7 @@ function _MenuEntry(set) {
 			button.connect('clicked', _DisplayOff);
 			// add the menuentry to the menu
 			//systemMenu._actionsItem.actor.insert_child_at_index(button, 4);
-			systemMenu._actionsItem.actor.add(button, { expand: true, x_fill: false });
+			systemMenu.buttonGroup.add(button, { expand: true, x_fill: false });
 		}
 
 	}
@@ -213,7 +213,7 @@ function _MenuEntry(set) {
 		else {
 
 			// remove the button
-			systemMenu._actionsItem.actor.remove_child(button);
+			systemMenu.buttonGroup.remove_child(button);
 		}
 
 		// reset menuitem/button variable
diff --git a/metadata.json b/metadata.json
index ff69594..3407a36 100644
--- a/metadata.json
+++ b/metadata.json
@@ -18,5 +18,5 @@
   "url": "https://github.com/simonthechipmunk/turnoffdisplay", 
   "uuid": "turnoffdisplay@simonthechipmunk.noreply.com", 
   "gettext-domain": "turnoffdisplay",
-  "version": 15
+  "version": 16
 }

[Quip11]

Well I can't create a pull request, but the above diff does fix the issue and puts the icon in the group as @kstange promised.

[Quip11]

OK, I figured out how to create a fork, push the above change, and submit a pull request. All yours.

[jordiromera]

Indeed, your hack is better. Thanks both of you