Skip to content

Wrong error message : Found invalid noise register setting of 8 #2

@bhrousseau

Description

@bhrousseau

When using vgmpacker, a wrong error message is printed on each run :

"Found invalid noise register setting of 8"

It's because the value 8 is used as an end marker :

		# Add EOF marker (0x08) to tone3 byte stream
		output_blocks[6].append(0x08)	# 0x08 is an invalid noise tone.

The code that checks invalid noise settings should take care of this EOF marker, or the check should be removed.

		# check there's no odd noise settings
		if True:
			invalid_noise_range = False
			for n in range(len(registers[6])):
				noise = registers[6][n]
				if noise > 7:
					print(" - Found invalid noise register setting of " + str(noise) + ", at offset " + str(n))
					invalid_noise_range = True

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions