Fails to validate valid tx

[DaniGuardiola]

When I paste the SigScript + Locking Script for some transactions, it fails to correctly do the hash160 operation, for some reason.

Examples I found:

• P2PKH btc testnet: https://live.blockcypher.com/btc-testnet/tx/1eadc4a09c6abc8f024f04031334941ee455cd4fb112850788214da5f631a3d5/ (first output)

Complete assembly:

483045022100a9926f2321a157989b453cbcc0b5f8addf64e081968f71140f11e13cd572e8e20220247868777cd462619af082379b6f28cd7660114aaddce31f9ad095054fbe419c01210272e9341c439e9de05ce2e31d0e7daedd7402c9e27c07e6951ec0038422d9f22a76a9147ab6ee8c168f32077c1cc83facb49a91d7ee5dae88ac

Generated hash160 is 089C63588D48F0BC16E13BD616D9F2F104E77AEC and it should be 7AB6EE8C168F32077C1CC83FACB49A91D7EE5DAE instead.

• P2SH btc testnet: same tx as above but second output

160014edd6180f7362763160c4a6b2aad6021cdf68f376a914ca21182b9eca3c99175dd89ce548b72db3244db087

• P2PKH btc mainnet: https://live.blockcypher.com/btc/tx/0c17bd0dfef8e2e6879e6f620b34820e90a8f60800a6c3bfec4dda74e64a04e7/ (second output)

483045022100d357c35cb990ce20e0b55f623cfdd0285d88b05a50d381c4d3f38d60fbfd1f01022031cfd7a5052a044d8b6db661ddbe1d42cd33993dfefb4cf08242b6d37e7dc880012102de7aa418220884ff2cfc17d53c4740306626304ec29547b2ea7db1f83cfd592676a914c404ac615993ac8c7b91a06283ba8c82e8e9098488ac

I don't have a clue why this is not working properly, maybe I am missing something? I don't think I am because the ASM code looks just fine.

[wschae]

Based on https://stackoverflow.com/questions/19233053/hashing-from-a-public-key-to-a-bitcoin-address-in-php, I updated Sha256 and Ripemd160 to take a byte string instead of a hex string to make it work. Try here for test. All the above TXs succeed. After a few more tests, I will send PR.