From ccee1b0362d21eeedf61040ad372bc8f414be8d1 Mon Sep 17 00:00:00 2001 From: chintankavathia Date: Fri, 13 Feb 2026 17:22:05 +0530 Subject: [PATCH] refactor(sort-bar): deprecate SiSortBarComponent and SiSortBarModule DEPRECATED: `SiSortBarComponent` and `SiSortBarModule` are deprecated. They originate from the older design system and do not align with current design guidelines. No known use case exists for this component. Both will be removed in v50. --- api-goldens/element-ng/sort-bar/index.api.md | 4 ++-- playwright/e2e/element-examples/static.spec.ts | 1 - ...bar--si-sort-bar-element-examples-chromium-dark-linux.png | 3 --- ...ar--si-sort-bar-element-examples-chromium-light-linux.png | 3 --- .../static.spec.ts-snapshots/si-sort-bar--si-sort-bar.yaml | 1 - projects/element-ng/sort-bar/si-sort-bar.component.ts | 5 +++++ projects/element-ng/sort-bar/si-sort-bar.module.ts | 5 +++++ .../si-sort-bar-deprecated.html} | 0 .../si-sort-bar-deprecated.ts} | 3 ++- 9 files changed, 14 insertions(+), 11 deletions(-) delete mode 100644 playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar-element-examples-chromium-dark-linux.png delete mode 100644 playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar-element-examples-chromium-light-linux.png delete mode 100644 playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar.yaml rename src/app/examples/{si-sort-bar/si-sort-bar.html => si-sort-bar-deprecated/si-sort-bar-deprecated.html} (100%) rename src/app/examples/{si-sort-bar/si-sort-bar.ts => si-sort-bar-deprecated/si-sort-bar-deprecated.ts} (82%) diff --git a/api-goldens/element-ng/sort-bar/index.api.md b/api-goldens/element-ng/sort-bar/index.api.md index 8a904729a..812cbd3d1 100644 --- a/api-goldens/element-ng/sort-bar/index.api.md +++ b/api-goldens/element-ng/sort-bar/index.api.md @@ -9,7 +9,7 @@ import * as i0 from '@angular/core'; import { OnInit } from '@angular/core'; import { TranslatableString } from '@siemens/element-translate-ng/translate'; -// @public (undocumented) +// @public @deprecated (undocumented) export class SiSortBarComponent implements OnInit { readonly defaultSortCriteria: i0.InputSignal; readonly sortChange: i0.OutputEmitterRef; @@ -17,7 +17,7 @@ export class SiSortBarComponent implements OnInit { readonly sortTitle: i0.InputSignal; } -// @public (undocumented) +// @public @deprecated (undocumented) export class SiSortBarModule { } diff --git a/playwright/e2e/element-examples/static.spec.ts b/playwright/e2e/element-examples/static.spec.ts index 9344a7b66..72649b08a 100644 --- a/playwright/e2e/element-examples/static.spec.ts +++ b/playwright/e2e/element-examples/static.spec.ts @@ -88,7 +88,6 @@ test('si-search-bar/si-search-bar-value', ({ si }) => si.static()); test('si-search-bar/si-search-bar', ({ si }) => si.static()); test('si-slider/si-slider', ({ si }) => si.static()); test('si-slider/si-slider-icon', ({ si }) => si.static()); -test('si-sort-bar/si-sort-bar', ({ si }) => si.static()); test('si-split/si-split-hide-header', ({ si }) => si.static()); test('si-split/si-split-mixed', ({ si }) => si.static()); test('si-summary-chip/si-summary-chip', ({ si }) => si.static()); diff --git a/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar-element-examples-chromium-dark-linux.png b/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar-element-examples-chromium-dark-linux.png deleted file mode 100644 index 6a79d1645..000000000 --- a/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar-element-examples-chromium-dark-linux.png +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:ef18e16a9ecb57cc6c25384db0c63bde789f41d6eade0fed5f901608d6a34936 -size 5978 diff --git a/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar-element-examples-chromium-light-linux.png b/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar-element-examples-chromium-light-linux.png deleted file mode 100644 index 79ec7bdbb..000000000 --- a/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar-element-examples-chromium-light-linux.png +++ /dev/null @@ -1,3 +0,0 @@ -version https://git-lfs.github.com/spec/v1 -oid sha256:c6598935f1613f9ba8a23f8a458152a0246cb73c121d177908759008414ad443 -size 5869 diff --git a/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar.yaml b/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar.yaml deleted file mode 100644 index f4ad3a84b..000000000 --- a/playwright/snapshots/static.spec.ts-snapshots/si-sort-bar--si-sort-bar.yaml +++ /dev/null @@ -1 +0,0 @@ -- text: "Sort by: name date value" \ No newline at end of file diff --git a/projects/element-ng/sort-bar/si-sort-bar.component.ts b/projects/element-ng/sort-bar/si-sort-bar.component.ts index 899cdba19..7265e5250 100644 --- a/projects/element-ng/sort-bar/si-sort-bar.component.ts +++ b/projects/element-ng/sort-bar/si-sort-bar.component.ts @@ -13,6 +13,11 @@ export interface SortCriteria { key: number | string; } +/** + * @deprecated SiSortBarComponent originate from the older design system and do not align with current + * design guidelines. No known use case exists for this component. + * It will be removed in v50. + */ @Component({ selector: 'si-sort-bar', imports: [SiIconComponent, SiTranslatePipe], diff --git a/projects/element-ng/sort-bar/si-sort-bar.module.ts b/projects/element-ng/sort-bar/si-sort-bar.module.ts index 6ce617504..db72ef513 100644 --- a/projects/element-ng/sort-bar/si-sort-bar.module.ts +++ b/projects/element-ng/sort-bar/si-sort-bar.module.ts @@ -6,6 +6,11 @@ import { NgModule } from '@angular/core'; import { SiSortBarComponent } from './si-sort-bar.component'; +/** + * @deprecated SiSortBarModule originate from the older design system and do not align with current + * design guidelines. No known use case exists for this module and component. + * It will be removed in v50. + */ @NgModule({ imports: [SiSortBarComponent], exports: [SiSortBarComponent] diff --git a/src/app/examples/si-sort-bar/si-sort-bar.html b/src/app/examples/si-sort-bar-deprecated/si-sort-bar-deprecated.html similarity index 100% rename from src/app/examples/si-sort-bar/si-sort-bar.html rename to src/app/examples/si-sort-bar-deprecated/si-sort-bar-deprecated.html diff --git a/src/app/examples/si-sort-bar/si-sort-bar.ts b/src/app/examples/si-sort-bar-deprecated/si-sort-bar-deprecated.ts similarity index 82% rename from src/app/examples/si-sort-bar/si-sort-bar.ts rename to src/app/examples/si-sort-bar-deprecated/si-sort-bar-deprecated.ts index 49372a66e..e67fedba0 100644 --- a/src/app/examples/si-sort-bar/si-sort-bar.ts +++ b/src/app/examples/si-sort-bar-deprecated/si-sort-bar-deprecated.ts @@ -2,6 +2,7 @@ * Copyright (c) Siemens 2016 - 2026 * SPDX-License-Identifier: MIT */ +/* eslint-disable @typescript-eslint/no-deprecated */ import { ChangeDetectionStrategy, Component, inject } from '@angular/core'; import { SiSortBarComponent } from '@siemens/element-ng/sort-bar'; import { LOG_EVENT } from '@siemens/live-preview'; @@ -9,7 +10,7 @@ import { LOG_EVENT } from '@siemens/live-preview'; @Component({ selector: 'app-sample', imports: [SiSortBarComponent], - templateUrl: './si-sort-bar.html', + templateUrl: './si-sort-bar-deprecated.html', changeDetection: ChangeDetectionStrategy.OnPush, host: { class: 'p-5' } })