Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a draft blog post for the upcoming Element v49 release. The post provides a good overview of the new features and changes. I've identified a few areas for improvement, mainly related to typos and grammatical corrections to enhance clarity. Most notably, there's a typo in the release version in the introduction, and a significant claim about zoneless change detection support that appears to contradict other documentation in the repository. Please review the detailed comments for specific suggestions.
spike-rabbit
force-pushed
the
docs/v49-blog
branch
2 times, most recently
from
7ff8d7a to
08c2528
Compare
chintankavathia
force-pushed
the
docs/v49-blog
branch
from
08c2528 to
2470305
Compare
docs/release-49.md
Outdated
| # Welcome Element 49! | ||
|
|
||
| We are excited to announce the release of Element 49, | ||
| a major step forward toward one Siemens Design Language (SDL). |
There was a problem hiding this comment.
Should we mention the @simpl/brand update?
There was a problem hiding this comment.
Not really needed in my opinion. We have this in the update guide.
ljanner
left a comment
ljanner
left a comment
There was a problem hiding this comment.
Generally the chapter titles don't follow a clear structure of capitalization.
I'm unsure what the correct approach is. I do like the pragmatic approach of going full sentence case, but I do understand that in a blog post additional emphasis can help. Currently it's just a bit inconsistent between the different chapters.
|
|
|
Documentation. Coverage Reports: |
|
shall we mention the new separate charts entry points? |
Makes sense. @akashsonune can you add a little section for this? Just insert it after the dashboard mfe chapter. |
6 participants
Do not merge, never!
This is just here to have a discussion before publishing on blog.siemens.com.
For rendered review, I also embedded this in the documentation.