From 8d599de92edc0026683fc74d34ec025e3a618f20 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Tue, 4 Oct 2022 00:22:17 +0000 Subject: [PATCH] vuln-fix: Temporary Directory Hijacking or Information Disclosure This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/10 Co-authored-by: Moderne --- .../backend/Websocket/support/TomcatWebSocketTestServer.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/java/ru/geekbrains/pocket/backend/Websocket/support/TomcatWebSocketTestServer.java b/src/test/java/ru/geekbrains/pocket/backend/Websocket/support/TomcatWebSocketTestServer.java index bb77692..818e7d6 100644 --- a/src/test/java/ru/geekbrains/pocket/backend/Websocket/support/TomcatWebSocketTestServer.java +++ b/src/test/java/ru/geekbrains/pocket/backend/Websocket/support/TomcatWebSocketTestServer.java @@ -28,6 +28,7 @@ import java.io.File; import java.io.IOException; +import java.nio.file.Files; import java.util.Arrays; import java.util.HashSet; @@ -69,9 +70,7 @@ public TomcatWebSocketTestServer(int port) { @SuppressWarnings("ResultOfMethodCallIgnored") private static File createBaseDir(int port) { try { - File file = File.createTempFile("tomcat.", "." + port); - file.delete(); - file.mkdir(); + File file = Files.createTempDirectory("tomcat." + "." + port).toFile(); file.deleteOnExit(); return file; } catch (IOException ex) {