Skip to content

Updates? #5

@wiverson

Description

@wiverson

Hi - I found the project, super cool. Noticed you haven't put out updates in a while. I made a few modifications on a local branch, including refactoring it to work with Maven (would like to push a version out to Maven central). FWIW seems to run fine on Big Sur with this initialization:

        WebView webview = new WebView()
                .size(800, 600)
                .title("Test")
                .resizable(true)
                .url("https://theoryofgeek.com/")
                .addJavascriptCallback("callback", x ->
                {
                    System.out.println(x);
                });
        webview.show();

I'd like to make a few tweaks to the API as well, e.g. instead of using finalize in WebappJniExtractor switch to a try-with-resources instead. Also add a bunch of additional test cases and perhaps some GitHub Actions to verify everything works on macOS, Windows. Probably update to the latest version of the core lib as well.

Would you prefer I submit this stuff to your repo as PRs, or just fork and run with it, or...?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions