Error: global leak detected: lr

[fb13]

Hi,

At some place in your code you are missing the "var" statement and thereby declare a global variable. I get the following error in a mocha test case: Error: global leak detected: lr

Potentially in the function crypt_raw.

Cheers

[eperedo]

Seems like this was fixed in version 0.1.0, there's any chance you can publish this version to npm?

Thank you!

[dtoubelis]

+1. The version from npm, which is 0.0.3 has the global leak and it is not present in master. So, could you please push the latest master to npm?

[nadav-dav]

👍

[manuel-di-iorio]

👍

[sandipwane]

Guys has fixed version been pushed to npm. I ran into same issue can't seem to fix this

[bcowgill]

this is still broken. crypt_raw refers to lr without a var lr at the top of the function thus blatting global.lr
bcrypt-nodejs@0.0.3

[bcowgill]

never mind, just saw the not maintained notice and reference to https://github.com/dcodeIO/bcrypt.js