OAuth2

[GilliganL]

Hi Steve,
Nice project! I am in a web development program and also an avid knitter. I came across your project while looking for a Ravelry OAuth2.0 module. I was wondering if that's something your working on? What do you think about creating a Passport strategy for Ravelry? I'm interested in helping out or taking it on myself.
Cheers!
Lynsey

[sfrieson]

Hey there Lynsey. Thanks for reaching out. I think this is a very interesting idea, and could be a nice improvement for this package. I must admit that this package is not fully complete, nor is it a main priority of mine at the moment. That being said, I'd be willing to work on this or work with you whether that be just reviewing a PR or working more closely together on it. A few questions:

• Do you have a timeline for requiring this feature?
• Is the specific requirement OAuth2, but a Nice to Have would be Passport support?
• Are you working with Express or a different server?

I'll start looking into this and re-familiarizing myself with the repo as I await your reply.

-Steven

[GilliganL]

Hi Steve, I don't have an exact timeline but would like to work on this for a project I'm just beginning to work on for school. There isn't a specific requirement as far as OAuth2/Passport. For this project I'd like to do one or the other. It's really about learning for me, so it'd be cool to do both. I am working with Express. The project I'm starting will use the MERN stack. I'm going to start going over the code you have to familiarize myself with it too. Thanks, Lynsey

…

On Fri, Sep 28, 2018 at 9:27 AM Steven Frieson ***@***.***> wrote: Hey there Lynsey. Thanks for reaching out. I think this is a very interesting idea, and could be a nice improvement for this package. I must admit that this package is not fully complete, nor is it a main priority of mine at the moment. That being said, I'd be willing to work on this or work with you whether that by . A few questions: - Do you have a timeline for requiring this feature? - Is the specific requirement OAuth2, but a Nice to Have would be Passport support? - Are you working with Express or a different server? I'll start looking into this and re-familiarizing myself with the repo as I await your reply. -Steven — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgCHNQB7qOaLsTKptNDoJdSOqvnIhiH9ks5ufj_hgaJpZM4W9ul8> .

[sfrieson]

I'll warn you, the code may not be the best organized codebase ever. This is one of the first projects I worked on after I finished my web dev bootcamp, and I also never used it for an actual project. The API in and of itself was the project.

The oauth dependency already included in the package does support OAuth2, so that would be the reasonable next step: using what is available. I also would like to avoid adding too many dependencies, so I'd prefer not to include Passport into this library but to be able to support a variety of authorization libraries if possible. So doing that might remove the dependence on oauth as well, allowing anyone to use their own preferred auth library.

That all being said, if you'd like to take on OAuth2 support with the currently installed oauth package. Go for it. If you find yourself not having the time for it or would like help, just message me back.

[GilliganL]

I'm in a bootcamp right now, which one did you go to? How has your experience been post-bootcamp? I'll talk about doing the OAuth2 and look over the code with him. If I want to add a passport strategy I'll create a completely new project so the dependency isn't an issue. I'll let you know if I come up with any questions. I really appreciate the help!

…

On Sun, Sep 30, 2018 at 1:16 PM Steven Frieson ***@***.***> wrote: I'll warn you, the code may not be the best organized codebase ever. This is one of the first projects I worked on after I finished my web dev bootcamp, and I also never used it for an actual project. The API in and of itself was the project. The oauth dependency already included in the package does support OAuth2, so that would be the reasonable next step: using what is available. I also would like to avoid adding too many dependencies, so I'd prefer not to include Passport into this library but to be able to support a variety of authorization libraries if possible. So doing that might remove the dependence on oauth as well, allowing anyone to use their own preferred auth library. That all being said, if you'd like to take on OAuth2 support with the currently installed oauth package. Go for it. If you find yourself not having the time for it or would like help, just message me back. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgCHNRSTM1DjgNxd8MD1vMXiD7-DCQ2zks5ugRiggaJpZM4W9ul8> .