Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.
This repository was archived by the owner on May 6, 2020. It is now read-only.

API consistency #37

@pczarn

Description

@pczarn

Builder interfaces already have many regularities. Here's what can be done to make them more regular.

  • fn new_with_callback
    • Should be renamed to with_callback.
    • Sometimes takes additional arguments.
  • Invoking sometimes implicitly finishes building. E.g. building continues when an expr is built for ConstBuilder, but building ends when a type is built.
  • fn build sometimes takes additional arguments.
  • All use of To... traits can be replaced with std::convert::Into.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions