From 4b96bda9fe2a05bbc260a000cd7fdc2705d15a02 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 16 Nov 2022 08:46:45 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- data/setup.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/data/setup.py b/data/setup.py index 85e0355..16ebc73 100644 --- a/data/setup.py +++ b/data/setup.py @@ -24,7 +24,26 @@ def unzip(): print(f'Unzipping deepsea train bundle into {DIR_PATH} ...') with tarfile.open(DIR_PATH + '.tar.gz') as f: - f.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f) def move():