Implement #205

Currently at Levenshtein ≥ 2, but this should be discussed!

Author: lmrodriguezr

app/models/name.rb

@@ -188,7 +188,7 @@ def all_public
     # parameters are:
     # - method: One of +:similarity+ (default) or +:levenshtein+
     # - threshold: Limit to find matches,
-    #   by default 0.7 (similarity) or 3 (levenshtein)
+    #   by default 0.7 (similarity) or 2 (levenshtein)
     # - limit: Maximum number of results to return
     # - selection: Pre-selection of names included in the search. One of:
     #   - all_valid: (default) All validly published names
@@ -223,7 +223,7 @@ def fuzzy_match(
           .order('score DESC')
           .limit(limit)
       when :levenshtein
-        threshold ||= 3
+        threshold ||= 2
         selection
           .select("id, name, levenshtein(name, #{clean_query}) AS score")
           .where('levenshtein(name, ?) <= ?', query, threshold)

app/models/name/quality_checks.rb

@@ -175,7 +175,13 @@ class QcWarning
         recommendations: %w[9.1]
       }.merge(@@link_to_edit_spelling),
       # - Recommendation 9.1 covered in § Rule 9b
-      # - Recommendation 9.2 [TODO: issue #6]:
+      # - Recommendation 9.2:
+      #   TODO [issue #205]: Discuss the default implementation, since it
+      #   involves Levenshtein ≥ 2 instead of 3, as stipulated in the SeqCode,
+      #   because the latter returns too many clearly distinct options. For
+      #   example, Burarchaeum would be "too similar" to: Halarchaeum,
+      #   Hadarchaeum, Salarchaeum, and Gugararchaeum, all of which are clearly
+      #   different
       similar_names_validly_published: {
         message: lambda { |w|
           similar = w.name.similar_names(:valid).limit(5)
@@ -189,7 +195,8 @@ class QcWarning
       }.merge(@@link_to_edit_spelling),
       similar_names_in_register_list: {
         message: lambda { |w|
-          similar = w.name.similar_names(:register).limit(5).map(&:name)
+          similar = w.name.similar_names(:register).limit(5)
+                     .map(&:reload).map(&:name_html)
           <<~MSG.html_safe
             Name is similar in spelling to: #{similar.to_sentence}.
             Consider variations that are less prone to confusion