Organize curator check display code

Author: lmrodriguezr

app/models/name/quality_checks.rb

@@ -773,6 +773,10 @@ def set
       @set_h.values.select(&:is_tutorial_error?)
     end
 
+    def [](type)
+      @checks_h[type.to_sym]
+    end
+
     def checks
       @checks_h.values
     end
@@ -791,7 +795,7 @@ def resort!
       @set_h = {}
       @checks_h = {}
       QcWarning.defaults.each_key do |k|
-        @set_h[k]   = new_set_h[k]     if new_set_h[k]
+        @set_h[k]    = new_set_h[k]    if new_set_h[k]
         @checks_h[k] = new_checks_h[k] if new_checks_h[k]
       end
     end

app/views/checks/_curator.html.erb

@@ -0,0 +1,42 @@
+<%
+  warn_class =
+    if !warn.check
+      'check-skip'
+    elsif warn.check.pass
+      'check-pass'
+    else
+      'check-fail'
+    end
+%>
+<dt class="<%= warn_class %>">
+  <span class="check-links">
+    <%= link_to('#', title: 'Skip',
+                data: { do: 'skip', kind: warn.type }) do %>
+      <%= fa_icon('minus-circle') %>
+    <% end %>
+    <%= link_to('#', title: 'Pass',
+                data: { do: 'pass', kind: warn.type }) do %>
+      <%= fa_icon('check-circle') %>
+    <% end %>
+    <%= link_to('#', title: 'Fail',
+                data: { do: 'fail', kind: warn.type }) do %>
+      <%= fa_icon('exclamation-circle') %>
+    <% end %>
+  </span>
+  <span><%= warn.title %></span>
+</dt>
+<dd class="pb-2">
+  <% if warn[:rules] || warn[:recommendations] || warn[:rule_notes] %>
+    <%= warn[:message] %>
+    <div class="text-muted">
+      <b>§ SeqCode</b>:
+        <% %w[rule rule_note recommendation].each do |section| %>
+          <% warn[:"#{section}s"]&.each do |i| %>
+            •
+            <% text = name_of_seqcode_section(section, i) %>
+            <%= link_to_seqcode_excerpt(section, i, text) %>
+          <% end %>
+        <% end %>
+    </div>
+  <% end %>
+</dd>

app/views/names/_curator_checks.html.erb

@@ -87,48 +87,7 @@
         <% first = false %>
         <% @name.qc_warnings.checks.each do |warn| %>
           <% next unless warn.checklist == section %>
-          <%
-            warn_class =
-              if !warn.check
-                'check-skip'
-              elsif warn.check.pass
-                'check-pass'
-              else
-                'check-fail'
-              end
-          %>
-          <dt class="<%= warn_class %>">
-            <span class="check-links">
-              <%= link_to('#', title: 'Skip',
-                          data: { do: 'skip', kind: warn.type }) do %>
-                <%= fa_icon('minus-circle') %>
-              <% end %>
-              <%= link_to('#', title: 'Pass',
-                          data: { do: 'pass', kind: warn.type }) do %>
-                <%= fa_icon('check-circle') %>
-              <% end %>
-              <%= link_to('#', title: 'Fail',
-                          data: { do: 'fail', kind: warn.type }) do %>
-                <%= fa_icon('exclamation-circle') %>
-              <% end %>
-            </span>
-            <span><%= warn.title %></span>
-          </dt>
-          <dd class="pb-2">
-            <% if warn[:rules] || warn[:recommendations] || warn[:rule_notes] %>
-              <%= warn[:message] %>
-              <div class="text-muted">
-                <b>§ SeqCode</b>:
-                  <% %w[rule rule_note recommendation].each do |section| %>
-                    <% warn[:"#{section}s"]&.each do |i| %>
-                      •
-                      <% text = name_of_seqcode_section(section, i) %>
-                      <%= link_to_seqcode_excerpt(section, i, text) %>
-                    <% end %>
-                  <% end %>
-              </div>
-            <% end %>
-          </dd>
+          <%= render(partial: 'checks/curator', locals: { warn: warn }) %>
         <% end %>
       <% end %>
 

app/views/registers/curation_genomics/_ambiguous_type_genome.html.erb

@@ -1,3 +1,4 @@
+<%= pager(@names) %>
 <table class="table table-hover table-responsive">
   <thead>
     <tr>
@@ -16,7 +17,13 @@
         <td><%= display_link(name) %></td>
         <td><%= display_link(genome) %></td>
         <td>
-          <% name.qc_warnings.each do |warn| %>
+          <%= render(
+                'check/curator',
+                locals: { warn: name.qc_warnings[@check] }
+              ) %>
+        </td>
+        <td>
+          <% name.qc_warnings.checks.each do |warn| %>
             <% if warn.type.to_s =~ /^discrepant_/ %>
               <%= render(partial: 'checks/check', locals: { warn: warn }) %>
             <% end %>
@@ -28,3 +35,4 @@
     <% end %>
   </tbody>
 </table>
+<%= pager(@names) %>