Correct POST form

Author: lmrodriguezr

app/models/register_coauthor.rb

@@ -9,10 +9,21 @@ class RegisterCoauthor < ApplicationRecord
 
   after_destroy(:update_coauthors_order)
 
+  ##
+  # Is this the first coauthor? Note that this means this is the
+  # second author of the list (since the submitting user is always
+  # first in the list of authors)
+  def first?
+    order == 1
+  end
+
+  ##
+  # Move the coauthor one position up in the order of coauthors
   def move_up
     return if order <= 1
 
-    register.register_coauthor.where(order: order - 1)
+    register
+      .register_coauthor.where(order: order - 1)
       .update(order: order) && update(order: order - 1)
   end
 

app/views/registers/coauthors.html.erb

@@ -23,17 +23,19 @@
         <%= display_link(author) %>
         <%= link_to(
               coauthors_register_url(
-                @register, coauthor: author.username, action: :unlink),
+                @register, action: :unlink,
+                register: { coauthor: author.username }),
               class: 'badge badge-pill badge-primary',
               method: :post, title: 'Unlink coauthor',
               data: { confirm: 'Are you sure?' }
             ) do %>
           <%= fa_icon('unlink') %> Remove as coauthor
         <% end %>
-        <% unless rc.order == 1 %>
+        <% unless rc.first? %>
           <%= link_to(
                 coauthors_register_url(
-                  @register, coauthor: author.username, action: :up),
+                  @register, action: :up,
+                  register: { coauthor: author.username }),
                 class: 'badge badge-pill badge-primary',
                 method: :post, title: 'Move coauthor up'
               ) do %>