Streamline shared publication registers

Author: lmrodriguezr

app/models/register.rb

@@ -299,6 +299,15 @@ def update_name_order
     names.map(&:update_name_order)
   end
 
+  def registers_with_shared_publication
+    return unless publication.present?
+    if validated?
+      publication.registers.where(validated: true) - [self]
+    else
+      publication.registers - [self]
+    end
+  end
+
   def merge_into(main_register, user)
     # Assertions
     errors.add(

app/views/registers/_alert_messages.html.erb

@@ -23,15 +23,13 @@
   </div>
 <% end %>
 
-<% if @register.publication.try(:registers).present? &&
-        @register.publication.registers.count > 1 %>
+<% if @register.registers_with_shared_publication.present? %>
   <div class="alert alert-<%= @register.validated? ? :info : :warning %>">
     <h4>Effective publication associated to multiple register lists</h4>
     The effective publication of this list
     (<%= @register.publication.short_citation %>) is also associated with:
     <ul>
-      <% @register.publication.registers.each do |register| %>
-        <% next if register == @register %>
+      <% @register.registers_with_shared_publication.each do |register| %>
         <li><%= display_link(register) %>: <%= register.propose_title %></li>
       <% end %>
     </ul>